d023f3d25d
Back in the v1alpha2 days the fuzzer test needed to be disabled. To ensure that there were no config breaks and everything worked correctly extensive replacement tests were put in place that functioned as unit tests for the kubeadm config utils as well. The fuzzer test has been reenabled for a long time now and there's no need for these replacements. Hence, over time most of these were disabled, deleted and refactored. The last remnants are part of the LoadJoinConfigurationFromFile test. The test data for those old tests remains largely unused today, but it still receives updates as it contains kubelet's and kube-proxy's component configs. Updates to these configs are usually done because the maintainers of those need to add a new field. Hence, to cleanup old code and reduce maintenance burden, the last test that depends on this test data is finally refactored and cleaned up to represent a simple unit test of `LoadJoinConfigurationFromFile`. Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
121 lines
2.8 KiB
Go
121 lines
2.8 KiB
Go
/*
|
|
Copyright 2018 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package config
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/lithammer/dedent"
|
|
)
|
|
|
|
func TestLoadJoinConfigurationFromFile(t *testing.T) {
|
|
// Create temp folder for the test case
|
|
tmpdir, err := ioutil.TempDir("", "")
|
|
if err != nil {
|
|
t.Fatalf("Couldn't create tmpdir: %v", err)
|
|
}
|
|
defer os.RemoveAll(tmpdir)
|
|
|
|
// cfgFiles is in cluster_test.go
|
|
var tests = []struct {
|
|
name string
|
|
fileContents string
|
|
expectErr bool
|
|
}{
|
|
{
|
|
name: "empty file causes error",
|
|
expectErr: true,
|
|
},
|
|
{
|
|
name: "Invalid v1beta1 causes error",
|
|
fileContents: dedent.Dedent(`
|
|
apiVersion: kubeadm.k8s.io/v1beta1
|
|
kind: JoinConfiguration
|
|
`),
|
|
expectErr: true,
|
|
},
|
|
{
|
|
name: "valid v1beta1 is loaded",
|
|
fileContents: dedent.Dedent(`
|
|
apiVersion: kubeadm.k8s.io/v1beta1
|
|
kind: JoinConfiguration
|
|
caCertPath: /etc/kubernetes/pki/ca.crt
|
|
discovery:
|
|
bootstrapToken:
|
|
apiServerEndpoint: kube-apiserver:6443
|
|
token: abcdef.0123456789abcdef
|
|
unsafeSkipCAVerification: true
|
|
timeout: 5m0s
|
|
tlsBootstrapToken: abcdef.0123456789abcdef
|
|
`),
|
|
},
|
|
{
|
|
name: "Invalid v1beta2 causes error",
|
|
fileContents: dedent.Dedent(`
|
|
apiVersion: kubeadm.k8s.io/v1beta2
|
|
kind: JoinConfiguration
|
|
`),
|
|
expectErr: true,
|
|
},
|
|
{
|
|
name: "valid v1beta2 is loaded",
|
|
fileContents: dedent.Dedent(`
|
|
apiVersion: kubeadm.k8s.io/v1beta2
|
|
kind: JoinConfiguration
|
|
caCertPath: /etc/kubernetes/pki/ca.crt
|
|
discovery:
|
|
bootstrapToken:
|
|
apiServerEndpoint: kube-apiserver:6443
|
|
token: abcdef.0123456789abcdef
|
|
unsafeSkipCAVerification: true
|
|
timeout: 5m0s
|
|
tlsBootstrapToken: abcdef.0123456789abcdef
|
|
`),
|
|
},
|
|
}
|
|
|
|
for _, rt := range tests {
|
|
t.Run(rt.name, func(t2 *testing.T) {
|
|
cfgPath := filepath.Join(tmpdir, rt.name)
|
|
err := ioutil.WriteFile(cfgPath, []byte(rt.fileContents), 0644)
|
|
if err != nil {
|
|
t.Errorf("Couldn't create file: %v", err)
|
|
return
|
|
}
|
|
|
|
obj, err := LoadJoinConfigurationFromFile(cfgPath)
|
|
if rt.expectErr {
|
|
if err == nil {
|
|
t.Error("Unexpected success")
|
|
}
|
|
} else {
|
|
if err != nil {
|
|
t.Errorf("Error reading file: %v", err)
|
|
return
|
|
}
|
|
|
|
if obj == nil {
|
|
t.Error("Unexpected nil return value")
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|