github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
ada53fab42
kubernetes/pkg/kubelet
History
Kubernetes Submit Queue 866293b704 Merge pull request #33366 from rhcarvalho/execincontainer-timeout-argument 
Automatic merge from submit-queue

Add timeout argument to ExecInContainer

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**: This is related to https://github.com/kubernetes/kubernetes/issues/26895. It brings a timeout to the signature of `ExecInContainer` so that we can take timeouts into account in the future. Unlike my first attempt in https://github.com/kubernetes/kubernetes/pull/27956, it doesn't immediately observe the timeout, because it is impossible to do it with the current state of the Docker Remote API (the default exec handler implementation).

**Special notes for your reviewer**: This shares commits with https://github.com/kubernetes/kubernetes/pull/27956, but without some of them that have more controversial implications (actually supporting the timeouts). The original PR shall be closed in the current state to preserve the history (instead of dropping commits in that PR).

Pinging the original people working on this change: @ncdc @sttts @vishh @dims 

**Release note**:

<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->

``` release-note
NONE
```
2016-11-08 01:41:19 -08:00
..
api run hack/update-generated-runtime.sh 2016-11-07 11:07:56 +08:00
cadvisor Fixed kubelet build. 2016-11-01 16:34:47 -04:00
client Allow apiserver to choose preferred kubelet address type 2016-10-31 16:02:38 -04:00
cm Rename experimental-runtime-integration-type to experimental-cri 2016-11-07 11:29:24 -08:00
config Replace negotiation with a new method that can extract info 2016-10-28 11:30:11 -04:00
container Add timeout argument to ExecInContainer 2016-11-07 13:00:59 +01:00
custommetrics autogenerated 2016-10-21 17:32:32 -07:00
dockershim Merge pull request #33366 from rhcarvalho/execincontainer-timeout-argument 2016-11-08 01:41:19 -08:00
dockertools Merge pull request #33366 from rhcarvalho/execincontainer-timeout-argument 2016-11-08 01:41:19 -08:00
envvars autogenerated 2016-10-21 17:32:32 -07:00
events autogenerated 2016-10-21 17:32:32 -07:00
eviction eviction message now includes resource that was exhausted 2016-11-04 09:30:02 -07:00
images autogenerated 2016-10-21 17:32:32 -07:00
kuberuntime Merge pull request #33366 from rhcarvalho/execincontainer-timeout-argument 2016-11-08 01:41:19 -08:00
leaky autogenerated 2016-10-21 17:32:32 -07:00
lifecycle Add timeout argument to ExecInContainer 2016-11-07 13:00:59 +01:00
metrics Add instrumented CRI service which is enabled for both grpc and non-grpc 2016-10-25 10:59:27 -07:00
network Unittests 2016-10-31 13:05:20 -07:00
pleg autogenerated 2016-10-21 17:32:32 -07:00
pod autogenerated 2016-10-21 17:32:32 -07:00
prober Add timeout argument to ExecInContainer 2016-11-07 13:00:59 +01:00
qos autogenerated 2016-10-21 17:32:32 -07:00
remote Add Status implementation. 2016-11-05 00:02:05 -07:00
rkt Add timeout argument to ExecInContainer 2016-11-07 13:00:59 +01:00
rktshim CRI: Rename container/sandbox states 2016-11-01 13:18:21 -07:00
server Add timeout argument to ExecInContainer 2016-11-07 13:00:59 +01:00
status autogenerated 2016-10-21 17:32:32 -07:00
sysctl autogenerated 2016-10-21 17:32:32 -07:00
types autogenerated 2016-10-21 17:32:32 -07:00
util Separate Direct and Indirect streaming paths, implement indirect path with CRI 2016-11-03 13:26:33 -07:00
volumemanager Remove GetRootContext from VolumeHost 2016-11-03 12:21:19 -04:00
active_deadline_test.go Refactor util clock into it's own pkg 2016-07-28 02:29:04 -04:00
active_deadline.go Refactor util clock into it's own pkg 2016-07-28 02:29:04 -04:00
BUILD Merge pull request #35491 from pmorie/byebye-getrootcontext 2016-11-06 01:09:19 -08:00
disk_manager_test.go Revert "Declare out of disk when there is no free inodes" 2016-07-06 08:19:09 -07:00
disk_manager.go Revert "Declare out of disk when there is no free inodes" 2016-07-06 08:19:09 -07:00
doc.go Use Go canonical import paths 2016-07-16 13:48:21 -04:00
kubelet_cadvisor_test.go Print/log pointers of structs with %#v instead of %+v 2016-08-01 22:27:56 +02:00
kubelet_cadvisor.go Eviction manager needs to start as runtime dependent module 2016-07-22 10:19:40 -04:00
kubelet_getters_test.go Remove "All rights reserved" from all the headers. 2016-06-29 17:47:36 -07:00
kubelet_getters.go Fix volume states out of sync problem after kubelet restarts 2016-10-25 12:29:12 -07:00
kubelet_network_test.go Revert "Revert "syncNetworkUtil in kubelet and fix loadbalancerSourceRange on GCE"" 2016-08-18 10:19:48 -07:00
kubelet_network.go Populate NetworkReady Status. 2016-11-05 00:02:05 -07:00
kubelet_node_status_test.go Rename experimental-runtime-integration-type to experimental-cri 2016-11-07 11:29:24 -08:00
kubelet_node_status.go Fix setNodeAddress in combination with cloud providers 2016-11-07 14:34:34 +01:00
kubelet_pods_test.go Add timeout argument to ExecInContainer 2016-11-07 13:00:59 +01:00
kubelet_pods.go Add timeout argument to ExecInContainer 2016-11-07 13:00:59 +01:00
kubelet_resources_test.go Fix default resource limits (node capacities) for downward api volumes 2016-08-16 14:41:17 -04:00
kubelet_resources.go Fix default resource limits (node capacities) for downward api volumes 2016-08-16 14:41:17 -04:00
kubelet_test.go Merge pull request #35526 from justinsb/fix_35521_b 2016-11-06 12:53:14 -08:00
kubelet_volumes_test.go Move Kubelet pod-management code into kubelet_pods.go 2016-09-26 17:16:59 -04:00
kubelet_volumes.go Remove volume SELinux relabeling when pod uses host IPC or PID ns 2016-10-26 10:39:46 -04:00
kubelet.go Rename experimental-runtime-integration-type to experimental-cri 2016-11-07 11:29:24 -08:00
networks.go Unittests 2016-10-31 13:05:20 -07:00
oom_watcher_test.go Remove "All rights reserved" from all the headers. 2016-06-29 17:47:36 -07:00
oom_watcher.go Remove "All rights reserved" from all the headers. 2016-06-29 17:47:36 -07:00
OWNERS
pod_container_deletor_test.go Delete all dead containers only after pod syncing is done. 2016-08-15 14:36:51 -07:00
pod_container_deletor.go Delete all dead containers only after pod syncing is done. 2016-08-15 14:36:51 -07:00
pod_workers_test.go Log an event when container runtime exceeds grace-period during eviction 2016-09-07 13:28:08 -04:00
pod_workers.go Log an event when container runtime exceeds grace-period during eviction 2016-09-07 13:28:08 -04:00
reason_cache_test.go Remove "All rights reserved" from all the headers. 2016-06-29 17:47:36 -07:00
reason_cache.go Remove "All rights reserved" from all the headers. 2016-06-29 17:47:36 -07:00
runonce_test.go Merge pull request #35526 from justinsb/fix_35521_b 2016-11-06 12:53:14 -08:00
runonce.go pods can not admitted should return directly 2016-07-30 11:47:50 +08:00
runtime.go Create hostNetwork pods even if network plugin not ready 2016-11-04 00:11:55 -04:00
util.go Kubelet code move: volume / util 2016-08-22 23:35:11 -04:00
volume_host.go Remove GetRootContext from VolumeHost 2016-11-03 12:21:19 -04:00