Files
kubernetes/cmd/kubeadm/app/phases/kubelet/config_test.go
Lubomir I. Ivanov b90b280c5a kubeadm: fix join bug where kubeletconfig was not patched in memory
During kubeadm join in 1.30 kubeadm started respecting
the kubeletconfiguration healthz address/port. Previously
it hardcoded the health check to localhost:defaultport.

A corner case was not handled where the user applies --patches
on join to modify the local kubeletconfiguration. This results
in kubeletconfiguration patch target patches not being applied to
the KubeletConfiguration in memory and the health check
running on the address:port which are present in the kubelet-config
configmap.

Fix that by explicitly calling a new function to patch the
KubeletConfiguration in memory. This is scoped to only handle
the healthz checks *after* the kubelet config.yaml was already
patched and written to disk.
2024-07-20 19:31:19 +03:00

157 lines
4.7 KiB
Go

/*
Copyright 2017 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package kubelet
import (
"bytes"
"fmt"
"io"
"os"
"path/filepath"
"testing"
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/client-go/kubernetes/fake"
core "k8s.io/client-go/testing"
kubeletconfig "k8s.io/kubelet/config/v1beta1"
"k8s.io/utils/ptr"
kubeadmapi "k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm"
"k8s.io/kubernetes/cmd/kubeadm/app/componentconfigs"
configutil "k8s.io/kubernetes/cmd/kubeadm/app/util/config"
)
func TestCreateConfigMap(t *testing.T) {
nodeName := "fake-node"
client := fake.NewSimpleClientset()
client.PrependReactor("get", "nodes", func(action core.Action) (bool, runtime.Object, error) {
return true, &v1.Node{
ObjectMeta: metav1.ObjectMeta{
Name: nodeName,
},
Spec: v1.NodeSpec{},
}, nil
})
client.PrependReactor("create", "roles", func(action core.Action) (bool, runtime.Object, error) {
return true, nil, nil
})
client.PrependReactor("create", "rolebindings", func(action core.Action) (bool, runtime.Object, error) {
return true, nil, nil
})
client.PrependReactor("create", "configmaps", func(action core.Action) (bool, runtime.Object, error) {
return true, nil, nil
})
internalcfg, err := configutil.DefaultedStaticInitConfiguration()
if err != nil {
t.Fatalf("unexpected failure when defaulting InitConfiguration: %v", err)
}
if err := CreateConfigMap(&internalcfg.ClusterConfiguration, client); err != nil {
t.Errorf("CreateConfigMap: unexpected error %v", err)
}
}
func TestCreateConfigMapRBACRules(t *testing.T) {
client := fake.NewSimpleClientset()
client.PrependReactor("create", "roles", func(action core.Action) (bool, runtime.Object, error) {
return true, nil, nil
})
client.PrependReactor("create", "rolebindings", func(action core.Action) (bool, runtime.Object, error) {
return true, nil, nil
})
if err := createConfigMapRBACRules(client); err != nil {
t.Errorf("createConfigMapRBACRules: unexpected error %v", err)
}
}
func TestApplyKubeletConfigPatches(t *testing.T) {
var (
input = []byte("bar: 0\nfoo: 0\n")
patch = []byte("bar: 1\n")
expectedOutput = []byte("bar: 1\nfoo: 0\n")
)
dir, err := os.MkdirTemp("", "patches")
if err != nil {
t.Fatalf("could not create temp dir: %v", err)
}
defer os.RemoveAll(dir)
if err := os.WriteFile(filepath.Join(dir, "kubeletconfiguration.yaml"), patch, 0644); err != nil {
t.Fatalf("could not write patch file: %v", err)
}
output, err := applyKubeletConfigPatches(input, dir, io.Discard)
if err != nil {
t.Fatalf("could not apply patch: %v", err)
}
if !bytes.Equal(output, expectedOutput) {
t.Fatalf("expected output:\n%s\ngot\n%s\n", expectedOutput, output)
}
}
func TestApplyPatchesToConfig(t *testing.T) {
const (
expectedAddress = "barfoo"
expectedPort = 4321
)
kc := &kubeletconfig.KubeletConfiguration{
HealthzBindAddress: "foobar",
HealthzPort: ptr.To[int32](1234),
}
cfg := &kubeadmapi.ClusterConfiguration{}
cfg.ComponentConfigs = kubeadmapi.ComponentConfigMap{}
localAPIEndpoint := &kubeadmapi.APIEndpoint{}
nodeRegOps := &kubeadmapi.NodeRegistrationOptions{}
componentconfigs.Default(cfg, localAPIEndpoint, nodeRegOps)
cfg.ComponentConfigs[componentconfigs.KubeletGroup].Set(kc)
// Change to a fake function that does patching with string replace.
applyKubeletConfigPatchesFunc = func(b []byte, _ string, _ io.Writer) ([]byte, error) {
b = bytes.ReplaceAll(b, []byte("foobar"), []byte(expectedAddress))
b = bytes.ReplaceAll(b, []byte("1234"), []byte(fmt.Sprintf("%d", expectedPort)))
return b, nil
}
defer func() {
applyKubeletConfigPatchesFunc = applyKubeletConfigPatches
}()
if err := ApplyPatchesToConfig(cfg, "fakedir"); err != nil {
t.Fatalf("unexpected error: %v", err)
}
new := cfg.ComponentConfigs[componentconfigs.KubeletGroup].Get()
newTyped, ok := new.(*kubeletconfig.KubeletConfiguration)
if !ok {
t.Fatal("could not cast kubelet config")
}
if newTyped.HealthzBindAddress != expectedAddress {
t.Fatalf("expected address: %s, got: %s", expectedAddress, newTyped.HealthzBindAddress)
}
if *newTyped.HealthzPort != expectedPort {
t.Fatalf("expected port: %d, got: %d", expectedPort, *newTyped.HealthzPort)
}
}