github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
b51e5c0127
kubernetes/pkg/client
History
k8s-merge-robot 07d24e4557 Merge pull request #28004 from mikedanese/fix-nil 
Automatic merge from submit-queue

return nil from NewClientConfig instead of empty struct

This is a go convention and fixes an nil pointer in kubelet when passing in bad command line options:

```
I0624 04:12:33.333246   25404 plugins.go:141] Loaded network plugin "kubenet"
E0624 04:12:33.333390   25404 runtime.go:58] Recovered from panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/util/runtime/runtime.go:52
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/util/runtime/runtime.go:40
/usr/local/go/src/runtime/asm_amd64.s:472
/usr/local/go/src/runtime/panic.go:443
/usr/local/go/src/runtime/panic.go:62
/usr/local/go/src/runtime/sigpanic_unix.go:24
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/core/unversioned/service.go:132
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/kubelet/kubelet.go:254
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/client/cache/listwatch.go:80
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/client/cache/reflector.go:262
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/client/cache/reflector.go:204
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/util/wait/wait.go:86
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/util/wait/wait.go:87
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/util/wait/wait.go:49
```
cc @caesarxuchao @lavalamp
2016-06-24 15:15:08 -07:00
..
cache Rephrase 'pv not found in cache' warnings. 2016-06-21 14:56:11 +02:00
chaosclient Uncomment the code that cause by #19254 2016-04-25 23:21:31 +08:00
clientset_generated autogenerated 2016-06-23 22:15:03 -07:00
leaderelection pkg/client/leaderelection: log err when retrieving endpoint 2016-05-23 14:37:19 -07:00
metrics HTTP Client request metrics: consolidating + client->server endpoint label, cleanups 2015-11-05 18:12:22 -05:00
record Make fake event recorder thread safe. 2016-05-04 14:20:13 +02:00
restclient Fix Retry-After in clients 2016-06-07 21:04:44 +02:00
testdata Added test cases for NewKubeletClient with TLS enabled 2014-12-18 00:57:33 -08:00
testing/core Add patch status to Node internalclientset 2016-06-19 23:54:02 -07:00
transport Merge pull request #26559 from wojtek-t/max_idle_conns_per_host 2016-06-01 11:41:42 -07:00
typed let dynamic client handle non-registered ListOptions; 2016-06-22 13:18:50 -07:00
unversioned Adding lock files for kubeconfig updating 2016-06-24 13:11:52 -07:00
OWNERS Move blunderbuss assignees into tree 2016-03-02 20:46:32 -05:00