
When a resource gets deleted during migration, the SVM SSA patch calls are interpreted as a logical create request. Since the object from storage is nil, the merged result is just a type meta object, which lacks a name in the body. This fails when the API server checks that the name from the request URL and the body are the same. Note that a create request is something that SVM controller should never do. Once the UID is set on the patch, the API server will fail the request at a slightly earlier point with an "uid mismatch" conflict error, which the SVM controller can handle gracefully. Setting UID by itself is not sufficient. When a resource gets deleted and recreated, if RV is not set but UID is set, we would get an immutable field validation error for attempting to update the UID. To address this, we set the resource version on the SSA patch as well. This will cause that update request to also fail with a conflict error. Added the create verb on all resources for SVM controller RBAC as otherwise the API server will reject the request before it fails with a conflict error. The change addresses a host of other issues with the SVM controller: 1. Include failure message in SVM resource 2. Do not block forever on unsynced GC monitor 3. Do not immediately fail on GC monitor being missing, allow for a grace period since discovery may be out of sync 4. Set higher QPS and burst to handle large migrations Test changes: 1. Clean up CRD webhook convertor logs 2. Allow SVM tests to be run multiple times to make finding flakes easier 3. Create and delete CRs during CRD test to force out any flakes 4. Add a stress test with multiple parallel migrations 5. Enable RBAC on KAS 6. Run KCM directly to exercise wiring and RBAC 7. Better logs during CRD migration 8. Scan audit logs to confirm SVM controller never creates Signed-off-by: Monis Khan <mok@microsoft.com>
224 lines
7.2 KiB
Go
224 lines
7.2 KiB
Go
/*
|
|
Copyright 2018 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package utils
|
|
|
|
import (
|
|
"bufio"
|
|
"fmt"
|
|
"io"
|
|
"reflect"
|
|
"sort"
|
|
"strings"
|
|
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"k8s.io/apimachinery/pkg/runtime/schema"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
"k8s.io/apiserver/pkg/admission/plugin/webhook/mutating"
|
|
auditinternal "k8s.io/apiserver/pkg/apis/audit"
|
|
"k8s.io/apiserver/pkg/audit"
|
|
)
|
|
|
|
// AuditEvent is a simplified representation of an audit event for testing purposes
|
|
type AuditEvent struct {
|
|
ID types.UID
|
|
Level auditinternal.Level
|
|
Stage auditinternal.Stage
|
|
RequestURI string
|
|
Verb string
|
|
Code int32
|
|
User string
|
|
ImpersonatedUser string
|
|
ImpersonatedGroups string
|
|
Resource string
|
|
Namespace string
|
|
RequestObject bool
|
|
ResponseObject bool
|
|
AuthorizeDecision string
|
|
|
|
// The Check functions in this package takes ownerships of these maps. You should
|
|
// not reference these maps after calling the Check functions.
|
|
AdmissionWebhookMutationAnnotations map[string]string
|
|
AdmissionWebhookPatchAnnotations map[string]string
|
|
|
|
// Only populated when a filter is provided to testEventFromInternalFiltered
|
|
CustomAuditAnnotations map[string]string
|
|
}
|
|
|
|
type AuditAnnotationsFilter func(key, val string) bool
|
|
|
|
// MissingEventsReport provides an analysis if any events are missing
|
|
type MissingEventsReport struct {
|
|
FirstEventChecked *auditinternal.Event
|
|
LastEventChecked *auditinternal.Event
|
|
NumEventsChecked int
|
|
MissingEvents []AuditEvent
|
|
AllEvents []AuditEvent
|
|
}
|
|
|
|
// String returns a human readable string representation of the report
|
|
func (m *MissingEventsReport) String() string {
|
|
return fmt.Sprintf(`missing %d events
|
|
|
|
- first event checked: %#v
|
|
|
|
- last event checked: %#v
|
|
|
|
- number of events checked: %d
|
|
|
|
- missing events: %#v`, len(m.MissingEvents), m.FirstEventChecked, m.LastEventChecked, m.NumEventsChecked, m.MissingEvents)
|
|
}
|
|
|
|
// CheckAuditLines searches the audit log for the expected audit lines.
|
|
func CheckAuditLines(stream io.Reader, expected []AuditEvent, version schema.GroupVersion) (missingReport *MissingEventsReport, err error) {
|
|
return CheckAuditLinesFiltered(stream, expected, version, nil)
|
|
}
|
|
|
|
// CheckAuditLinesFiltered searches the audit log for the expected audit lines, customAnnotationsFilter
|
|
// controls which audit annotations are added to AuditEvent.CustomAuditAnnotations.
|
|
// If the customAnnotationsFilter is nil, AuditEvent.CustomAuditAnnotations will be empty.
|
|
func CheckAuditLinesFiltered(stream io.Reader, expected []AuditEvent, version schema.GroupVersion, customAnnotationsFilter AuditAnnotationsFilter) (missingReport *MissingEventsReport, err error) {
|
|
expectations := newAuditEventTracker(expected)
|
|
|
|
scanner := bufio.NewScanner(stream)
|
|
|
|
missingReport = &MissingEventsReport{
|
|
MissingEvents: expected,
|
|
}
|
|
|
|
var i int
|
|
for i = 0; scanner.Scan(); i++ {
|
|
line := scanner.Text()
|
|
|
|
e := &auditinternal.Event{}
|
|
decoder := audit.Codecs.UniversalDecoder(version)
|
|
if err := runtime.DecodeInto(decoder, []byte(line), e); err != nil {
|
|
return missingReport, fmt.Errorf("failed decoding buf: %s, apiVersion: %s", line, version)
|
|
}
|
|
if i == 0 {
|
|
missingReport.FirstEventChecked = e
|
|
}
|
|
missingReport.LastEventChecked = e
|
|
|
|
event, err := testEventFromInternalFiltered(e, customAnnotationsFilter)
|
|
if err != nil {
|
|
return missingReport, err
|
|
}
|
|
|
|
expectations.Mark(event)
|
|
missingReport.AllEvents = append(missingReport.AllEvents, event)
|
|
}
|
|
if err := scanner.Err(); err != nil {
|
|
return missingReport, err
|
|
}
|
|
|
|
missingReport.MissingEvents = expectations.Missing()
|
|
missingReport.NumEventsChecked = i
|
|
return missingReport, nil
|
|
}
|
|
|
|
// testEventFromInternalFiltered takes an internal audit event and returns a test event, customAnnotationsFilter
|
|
// controls which audit annotations are added to AuditEvent.CustomAuditAnnotations.
|
|
// If the customAnnotationsFilter is nil, AuditEvent.CustomAuditAnnotations will be empty.
|
|
func testEventFromInternalFiltered(e *auditinternal.Event, customAnnotationsFilter AuditAnnotationsFilter) (AuditEvent, error) {
|
|
event := AuditEvent{
|
|
Level: e.Level,
|
|
Stage: e.Stage,
|
|
RequestURI: e.RequestURI,
|
|
Verb: e.Verb,
|
|
User: e.User.Username,
|
|
}
|
|
if e.ObjectRef != nil {
|
|
event.Namespace = e.ObjectRef.Namespace
|
|
event.Resource = e.ObjectRef.Resource
|
|
}
|
|
if e.ResponseStatus != nil {
|
|
event.Code = e.ResponseStatus.Code
|
|
}
|
|
if e.ResponseObject != nil {
|
|
event.ResponseObject = true
|
|
}
|
|
if e.RequestObject != nil {
|
|
event.RequestObject = true
|
|
}
|
|
if e.ImpersonatedUser != nil {
|
|
event.ImpersonatedUser = e.ImpersonatedUser.Username
|
|
sort.Strings(e.ImpersonatedUser.Groups)
|
|
event.ImpersonatedGroups = strings.Join(e.ImpersonatedUser.Groups, ",")
|
|
}
|
|
event.AuthorizeDecision = e.Annotations["authorization.k8s.io/decision"]
|
|
for k, v := range e.Annotations {
|
|
if strings.HasPrefix(k, mutating.PatchAuditAnnotationPrefix) {
|
|
if event.AdmissionWebhookPatchAnnotations == nil {
|
|
event.AdmissionWebhookPatchAnnotations = map[string]string{}
|
|
}
|
|
event.AdmissionWebhookPatchAnnotations[k] = v
|
|
} else if strings.HasPrefix(k, mutating.MutationAuditAnnotationPrefix) {
|
|
if event.AdmissionWebhookMutationAnnotations == nil {
|
|
event.AdmissionWebhookMutationAnnotations = map[string]string{}
|
|
}
|
|
event.AdmissionWebhookMutationAnnotations[k] = v
|
|
} else if customAnnotationsFilter != nil && customAnnotationsFilter(k, v) {
|
|
if event.CustomAuditAnnotations == nil {
|
|
event.CustomAuditAnnotations = map[string]string{}
|
|
}
|
|
event.CustomAuditAnnotations[k] = v
|
|
}
|
|
}
|
|
return event, nil
|
|
}
|
|
|
|
// auditEvent is a private wrapper on top of AuditEvent used by auditEventTracker
|
|
type auditEvent struct {
|
|
event AuditEvent
|
|
found bool
|
|
}
|
|
|
|
// auditEventTracker keeps track of AuditEvent expectations and marks matching events as found
|
|
type auditEventTracker struct {
|
|
events []*auditEvent
|
|
}
|
|
|
|
// newAuditEventTracker creates a tracker that tracks whether expect events are found
|
|
func newAuditEventTracker(expected []AuditEvent) *auditEventTracker {
|
|
expectations := &auditEventTracker{events: []*auditEvent{}}
|
|
for _, event := range expected {
|
|
// we copy the references to the maps in event
|
|
expectations.events = append(expectations.events, &auditEvent{event: event, found: false})
|
|
}
|
|
return expectations
|
|
}
|
|
|
|
// Mark marks the given event as found if it's expected
|
|
func (t *auditEventTracker) Mark(event AuditEvent) {
|
|
for _, e := range t.events {
|
|
if reflect.DeepEqual(e.event, event) {
|
|
e.found = true
|
|
}
|
|
}
|
|
}
|
|
|
|
// Missing reports events that are expected but not found
|
|
func (t *auditEventTracker) Missing() []AuditEvent {
|
|
var missing []AuditEvent
|
|
for _, e := range t.events {
|
|
if !e.found {
|
|
missing = append(missing, e.event)
|
|
}
|
|
}
|
|
return missing
|
|
}
|