6a6771b514
When a resource gets deleted during migration, the SVM SSA patch calls are interpreted as a logical create request. Since the object from storage is nil, the merged result is just a type meta object, which lacks a name in the body. This fails when the API server checks that the name from the request URL and the body are the same. Note that a create request is something that SVM controller should never do. Once the UID is set on the patch, the API server will fail the request at a slightly earlier point with an "uid mismatch" conflict error, which the SVM controller can handle gracefully. Setting UID by itself is not sufficient. When a resource gets deleted and recreated, if RV is not set but UID is set, we would get an immutable field validation error for attempting to update the UID. To address this, we set the resource version on the SSA patch as well. This will cause that update request to also fail with a conflict error. Added the create verb on all resources for SVM controller RBAC as otherwise the API server will reject the request before it fails with a conflict error. The change addresses a host of other issues with the SVM controller: 1. Include failure message in SVM resource 2. Do not block forever on unsynced GC monitor 3. Do not immediately fail on GC monitor being missing, allow for a grace period since discovery may be out of sync 4. Set higher QPS and burst to handle large migrations Test changes: 1. Clean up CRD webhook convertor logs 2. Allow SVM tests to be run multiple times to make finding flakes easier 3. Create and delete CRs during CRD test to force out any flakes 4. Add a stress test with multiple parallel migrations 5. Enable RBAC on KAS 6. Run KCM directly to exercise wiring and RBAC 7. Better logs during CRD migration 8. Scan audit logs to confirm SVM controller never creates Signed-off-by: Monis Khan <mok@microsoft.com>
86 lines
2.7 KiB
Go
86 lines
2.7 KiB
Go
/*
|
|
Copyright 2024 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package storageversionmigrator
|
|
|
|
import (
|
|
"fmt"
|
|
"strconv"
|
|
|
|
"k8s.io/apimachinery/pkg/runtime/schema"
|
|
|
|
corev1 "k8s.io/api/core/v1"
|
|
svmv1alpha1 "k8s.io/api/storagemigration/v1alpha1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
)
|
|
|
|
func convertResourceVersionToInt(rv string) (int64, error) {
|
|
resourceVersion, err := strconv.ParseInt(rv, 10, 64)
|
|
if err != nil {
|
|
return 0, fmt.Errorf("failed to parse resource version %q: %w", rv, err)
|
|
}
|
|
|
|
return resourceVersion, nil
|
|
}
|
|
|
|
func getGVRFromResource(svm *svmv1alpha1.StorageVersionMigration) schema.GroupVersionResource {
|
|
return schema.GroupVersionResource{
|
|
Group: svm.Spec.Resource.Group,
|
|
Version: svm.Spec.Resource.Version,
|
|
Resource: svm.Spec.Resource.Resource,
|
|
}
|
|
}
|
|
|
|
// IsConditionTrue returns true if the StorageVersionMigration has the given condition
|
|
// It is exported for use in tests
|
|
func IsConditionTrue(svm *svmv1alpha1.StorageVersionMigration, conditionType svmv1alpha1.MigrationConditionType) bool {
|
|
return indexOfCondition(svm, conditionType) != -1
|
|
}
|
|
|
|
func indexOfCondition(svm *svmv1alpha1.StorageVersionMigration, conditionType svmv1alpha1.MigrationConditionType) int {
|
|
for i, c := range svm.Status.Conditions {
|
|
if c.Type == conditionType && c.Status == corev1.ConditionTrue {
|
|
return i
|
|
}
|
|
}
|
|
return -1
|
|
}
|
|
|
|
func setStatusConditions(
|
|
toBeUpdatedSVM *svmv1alpha1.StorageVersionMigration,
|
|
conditionType svmv1alpha1.MigrationConditionType,
|
|
reason, message string,
|
|
) *svmv1alpha1.StorageVersionMigration {
|
|
if !IsConditionTrue(toBeUpdatedSVM, conditionType) {
|
|
if conditionType == svmv1alpha1.MigrationSucceeded || conditionType == svmv1alpha1.MigrationFailed {
|
|
runningConditionIdx := indexOfCondition(toBeUpdatedSVM, svmv1alpha1.MigrationRunning)
|
|
if runningConditionIdx != -1 {
|
|
toBeUpdatedSVM.Status.Conditions[runningConditionIdx].Status = corev1.ConditionFalse
|
|
}
|
|
}
|
|
|
|
toBeUpdatedSVM.Status.Conditions = append(toBeUpdatedSVM.Status.Conditions, svmv1alpha1.MigrationCondition{
|
|
Type: conditionType,
|
|
Status: corev1.ConditionTrue,
|
|
LastUpdateTime: metav1.Now(),
|
|
Reason: reason,
|
|
Message: message,
|
|
})
|
|
}
|
|
|
|
return toBeUpdatedSVM
|
|
}
|