Files
kubernetes/pkg
Kubernetes Submit Queue b99a9094cc Merge pull request #34380 from Random-Liu/fix-cri-image
Automatic merge from submit-queue

CRI: Image pullable support in dockershim

For #33189.

The new test `ImageID should be set to the manifest digest (from RepoDigests) when available` introduced in #33014 is failing, because:
1) `docker-pullable://` conversion is not supported in dockershim;
2) `kuberuntime` and `dockershim` is using `ListImages with image name filter` to check whether image presents. However, `ListImages` doesn't support filter with `digest`.

This PR:
1) Change `kuberuntime.IsImagePresent` to use `runtime.ImageStatus` and `dockershim.InspectImage` instead. ***Notice an API change: `ImageStatus` should return `(nil, nil)` for non-existing image.***
2) Add `docker-pullable://` support.
3) Fix `RemoveImage` in dockershim https://github.com/kubernetes/kubernetes/pull/29316.

I've tried myself, the test can pass now.

@yujuhong @feiskyer @yifan-gu 
/cc @kubernetes/sig-node
2016-10-12 12:25:37 -07:00
..
2016-09-19 09:57:19 -04:00
2016-10-12 08:06:10 -04:00
2016-09-22 23:37:27 +08:00
2016-08-31 13:46:40 -07:00
2016-07-16 13:48:21 -04:00
2016-08-25 10:57:31 -07:00
2016-09-29 17:35:43 -07:00
2016-08-22 14:18:15 -04:00
2016-09-20 14:47:31 +08:00
2016-10-03 22:39:33 +02:00
2016-10-07 15:37:57 +02:00