705f97e171
Nit: remove capitalization of preferred Remove line from kubelet and add to separate PR for easier merge nit: dependency added to separate PR Add check to ensure strict policy cannot be set without feature gate enabled Topology Manager runs "none" policy by default. Added constants for policies and updated documentation.
94 lines
3.3 KiB
Go
94 lines
3.3 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package validation
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
utilerrors "k8s.io/apimachinery/pkg/util/errors"
|
|
kubeletconfig "k8s.io/kubernetes/pkg/kubelet/apis/config"
|
|
)
|
|
|
|
func TestValidateKubeletConfiguration(t *testing.T) {
|
|
successCase := &kubeletconfig.KubeletConfiguration{
|
|
CgroupsPerQOS: true,
|
|
EnforceNodeAllocatable: []string{"pods", "system-reserved", "kube-reserved"},
|
|
SystemReservedCgroup: "/system.slice",
|
|
KubeReservedCgroup: "/kubelet.service",
|
|
SystemCgroups: "",
|
|
CgroupRoot: "",
|
|
EventBurst: 10,
|
|
EventRecordQPS: 5,
|
|
HealthzPort: 10248,
|
|
ImageGCHighThresholdPercent: 85,
|
|
ImageGCLowThresholdPercent: 80,
|
|
IPTablesDropBit: 15,
|
|
IPTablesMasqueradeBit: 14,
|
|
KubeAPIBurst: 10,
|
|
KubeAPIQPS: 5,
|
|
MaxOpenFiles: 1000000,
|
|
MaxPods: 110,
|
|
OOMScoreAdj: -999,
|
|
PodsPerCore: 100,
|
|
Port: 65535,
|
|
ReadOnlyPort: 0,
|
|
RegistryBurst: 10,
|
|
RegistryPullQPS: 5,
|
|
HairpinMode: kubeletconfig.PromiscuousBridge,
|
|
NodeLeaseDurationSeconds: 1,
|
|
CPUCFSQuotaPeriod: metav1.Duration{Duration: 100 * time.Millisecond},
|
|
TopologyManagerPolicy: "none",
|
|
}
|
|
if allErrors := ValidateKubeletConfiguration(successCase); allErrors != nil {
|
|
t.Errorf("expect no errors, got %v", allErrors)
|
|
}
|
|
|
|
errorCase := &kubeletconfig.KubeletConfiguration{
|
|
CgroupsPerQOS: false,
|
|
EnforceNodeAllocatable: []string{"pods", "system-reserved", "kube-reserved", "illegal-key"},
|
|
SystemCgroups: "/",
|
|
CgroupRoot: "",
|
|
EventBurst: -10,
|
|
EventRecordQPS: -10,
|
|
HealthzPort: -10,
|
|
ImageGCHighThresholdPercent: 101,
|
|
ImageGCLowThresholdPercent: 101,
|
|
IPTablesDropBit: -10,
|
|
IPTablesMasqueradeBit: -10,
|
|
KubeAPIBurst: -10,
|
|
KubeAPIQPS: -10,
|
|
MaxOpenFiles: -10,
|
|
MaxPods: -10,
|
|
OOMScoreAdj: -1001,
|
|
PodsPerCore: -10,
|
|
Port: 0,
|
|
ReadOnlyPort: -10,
|
|
RegistryBurst: -10,
|
|
RegistryPullQPS: -10,
|
|
HairpinMode: "foo",
|
|
NodeLeaseDurationSeconds: -1,
|
|
CPUCFSQuotaPeriod: metav1.Duration{Duration: 0},
|
|
TopologyManagerPolicy: "",
|
|
}
|
|
const numErrs = 26
|
|
if allErrors := ValidateKubeletConfiguration(errorCase); len(allErrors.(utilerrors.Aggregate).Errors()) != numErrs {
|
|
t.Errorf("expect %d errors, got %v", numErrs, len(allErrors.(utilerrors.Aggregate).Errors()))
|
|
}
|
|
}
|