ab184e1b1f
Automatic merge from submit-queue Make desired objects in fed controller reconcilation function fully writable When creating desired objects for sub-cluster in reconciliate functions we don't make full copies. This may result in unexpected race condition in the future when someone actually adds some object modifications (not needed in most cases but anyway - the cost of extra copy will be relatively small comparing to inter-cluster traffic). In case of ReplicaSet and Deployment the spec copy was a shallow one - ok for setting just replicas but also error-prone in the future. cc: @quinton-hoole @nikhiljindal @madhusudancs
117 lines
3.0 KiB
Go
117 lines
3.0 KiB
Go
/*
|
|
Copyright 2016 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package util
|
|
|
|
import (
|
|
"testing"
|
|
|
|
api_v1 "k8s.io/kubernetes/pkg/api/v1"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestObjectMeta(t *testing.T) {
|
|
o1 := api_v1.ObjectMeta{
|
|
Namespace: "ns1",
|
|
Name: "s1",
|
|
UID: "1231231412",
|
|
ResourceVersion: "999",
|
|
}
|
|
o2 := copyObjectMeta(o1)
|
|
o3 := api_v1.ObjectMeta{
|
|
Namespace: "ns1",
|
|
Name: "s1",
|
|
UID: "1231231412",
|
|
Annotations: map[string]string{"A": "B"},
|
|
}
|
|
o4 := api_v1.ObjectMeta{
|
|
Namespace: "ns1",
|
|
Name: "s1",
|
|
UID: "1231255531412",
|
|
Annotations: map[string]string{"A": "B"},
|
|
}
|
|
o5 := api_v1.ObjectMeta{
|
|
Namespace: "ns1",
|
|
Name: "s1",
|
|
ResourceVersion: "1231231412",
|
|
Annotations: map[string]string{"A": "B"},
|
|
}
|
|
o6 := api_v1.ObjectMeta{
|
|
Namespace: "ns1",
|
|
Name: "s1",
|
|
ResourceVersion: "1231255531412",
|
|
Annotations: map[string]string{"A": "B"},
|
|
}
|
|
o7 := api_v1.ObjectMeta{
|
|
Namespace: "ns1",
|
|
Name: "s1",
|
|
ResourceVersion: "1231255531412",
|
|
Annotations: map[string]string{},
|
|
Labels: map[string]string{},
|
|
}
|
|
o8 := api_v1.ObjectMeta{
|
|
Namespace: "ns1",
|
|
Name: "s1",
|
|
ResourceVersion: "1231255531412",
|
|
}
|
|
assert.Equal(t, 0, len(o2.UID))
|
|
assert.Equal(t, 0, len(o2.ResourceVersion))
|
|
assert.Equal(t, o1.Name, o2.Name)
|
|
assert.True(t, ObjectMetaEquivalent(o1, o2))
|
|
assert.False(t, ObjectMetaEquivalent(o1, o3))
|
|
assert.True(t, ObjectMetaEquivalent(o3, o4))
|
|
assert.True(t, ObjectMetaEquivalent(o5, o6))
|
|
assert.True(t, ObjectMetaEquivalent(o3, o5))
|
|
assert.True(t, ObjectMetaEquivalent(o7, o8))
|
|
assert.True(t, ObjectMetaEquivalent(o8, o7))
|
|
}
|
|
|
|
func TestObjectMetaAndSpec(t *testing.T) {
|
|
s1 := api_v1.Service{
|
|
ObjectMeta: api_v1.ObjectMeta{
|
|
Namespace: "ns1",
|
|
Name: "s1",
|
|
},
|
|
Spec: api_v1.ServiceSpec{
|
|
ExternalName: "Service1",
|
|
},
|
|
}
|
|
s1b := s1
|
|
s2 := api_v1.Service{
|
|
ObjectMeta: api_v1.ObjectMeta{
|
|
Namespace: "ns1",
|
|
Name: "s2",
|
|
},
|
|
Spec: api_v1.ServiceSpec{
|
|
ExternalName: "Service1",
|
|
},
|
|
}
|
|
s3 := api_v1.Service{
|
|
ObjectMeta: api_v1.ObjectMeta{
|
|
Namespace: "ns1",
|
|
Name: "s1",
|
|
},
|
|
Spec: api_v1.ServiceSpec{
|
|
ExternalName: "Service2",
|
|
},
|
|
}
|
|
assert.True(t, ObjectMetaAndSpecEquivalent(&s1, &s1b))
|
|
assert.False(t, ObjectMetaAndSpecEquivalent(&s1, &s2))
|
|
assert.False(t, ObjectMetaAndSpecEquivalent(&s1, &s3))
|
|
assert.False(t, ObjectMetaAndSpecEquivalent(&s2, &s3))
|
|
}
|