github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
c294bf0d06
kubernetes/pkg/controller/volume/persistentvolume
History
Kubernetes Submit Queue 8f11cc78a8 Merge pull request #38339 from gnufied/backoff-on-volume-delete 
Automatic merge from submit-queue (batch tested with PRs 38377, 36365, 36648, 37691, 38339)

Exponential back off when volume delete fails

**What this PR does / why we need it**:

This PR implements ability in pv_controller to back off when deleting a volume fails from plugin API. 

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: 

Partly fixes #38295 , but I think volume delete is most problematic thing happening in pv_controller without any sort of backoff. 

After this change the attempts of volume deletion look like:

```
controller : I1208 00:18:35.532061   16388 aws_util.go:55] Error deleting EBS Disk volume aws://us-east-1d/vol-abcdefg: VolumeInUse: Volume vol-abcdefg is currently attached to i-1234567
controller : I1208 00:20:50.578325   16388 aws_util.go:55] Error deleting EBS Disk volume aws://us-east-1d/vol-abcdefg: VolumeInUse: Volume vol-abcdefg is currently attached to i-1234567
controller : I1208 00:23:05.563488   16388 aws_util.go:55] Error deleting EBS Disk volume aws://us-east-1d/vol-abcdefg: VolumeInUse: Volume vol-abcdefg is currently attached to i-1234567
controller : I1208 00:25:20.599158   16388 aws_util.go:55] Error deleting EBS Disk volume aws://us-east-1d/vol-abcdefg: VolumeInUse: Volume vol-abcdefg is currently attached to i-1234567
controller : I1208 00:27:35.560009   16388 aws_util.go:55] Error deleting EBS Disk volume aws://us-east-1d/vol-abcdefg: VolumeInUse: Volume vol-abcdefg is currently attached to i-1234567
controller : I1208 00:29:50.594967   16388 aws_util.go:55] Error deleting EBS Disk volume aws://us-east-1d/vol-abcdefg: VolumeInUse: Volume vol-abcdefg is currently attached to i-1234567
controller : I1208 00:32:05.539168   16388 aws_util.go:55] Error deleting EBS Disk volume aws://us-east-1d/vol-abcdefg: VolumeInUse: Volume vol-abcdefg is currently attached to i-1234567
controller : I1208 00:34:20.581665   16388 aws_util.go:55] Error deleting EBS Disk volume aws://us-east-1d/vol-abcdefg: VolumeInUse: Volume vol-abcdefg is currently attached to i-1234567
```
2016-12-08 10:52:03 -08:00
..
options autogenerated 2016-10-21 17:32:32 -07:00
binder_test.go cmd/kube-controller-manager 2016-11-23 15:53:09 -08:00
BUILD refactor: generated 2016-12-03 19:10:46 -05:00
delete_test.go cmd/kube-controller-manager 2016-11-23 15:53:09 -08:00
framework_test.go type found with controller comment. 2016-12-07 10:55:02 -08:00
index_test.go refactor: update bazel, codec, and gofmt 2016-12-03 19:10:53 -05:00
index.go refactor: update bazel, codec, and gofmt 2016-12-03 19:10:53 -05:00
OWNERS Reorganize volume controllers and manager 2016-07-01 18:50:25 -07:00
provision_test.go refactor: update bazel, codec, and gofmt 2016-12-03 19:10:53 -05:00
pv_controller_base.go Exponential back off when volume delete fails 2016-12-07 19:25:36 -05:00
pv_controller_test.go cmd/kube-controller-manager 2016-11-23 15:53:09 -08:00
pv_controller.go Exponential back off when volume delete fails 2016-12-07 19:25:36 -05:00
recycle_test.go cmd/kube-controller-manager 2016-11-23 15:53:09 -08:00
volume_host.go cmd/kube-controller-manager 2016-11-23 15:53:09 -08:00