1fe7ce21bc
This moves the priority types from the algorithm package to priorities package. Idea is to move the type to the packages where it is implemented. This will ease the future refactor process.
106 lines
3.0 KiB
Go
106 lines
3.0 KiB
Go
/*
|
|
Copyright 2015 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package factory
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"k8s.io/kubernetes/pkg/scheduler/algorithm/priorities"
|
|
"k8s.io/kubernetes/pkg/scheduler/api"
|
|
)
|
|
|
|
func TestAlgorithmNameValidation(t *testing.T) {
|
|
algorithmNamesShouldValidate := []string{
|
|
"1SomeAlgo1rithm",
|
|
"someAlgor-ithm1",
|
|
}
|
|
algorithmNamesShouldNotValidate := []string{
|
|
"-SomeAlgorithm",
|
|
"SomeAlgorithm-",
|
|
"Some,Alg:orithm",
|
|
}
|
|
for _, name := range algorithmNamesShouldValidate {
|
|
t.Run(name, func(t *testing.T) {
|
|
if !validName.MatchString(name) {
|
|
t.Errorf("should be a valid algorithm name but is not valid.")
|
|
}
|
|
})
|
|
}
|
|
for _, name := range algorithmNamesShouldNotValidate {
|
|
t.Run(name, func(t *testing.T) {
|
|
if validName.MatchString(name) {
|
|
t.Errorf("should be an invalid algorithm name but is valid.")
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidatePriorityConfigOverFlow(t *testing.T) {
|
|
tests := []struct {
|
|
description string
|
|
configs []priorities.PriorityConfig
|
|
expected bool
|
|
}{
|
|
{
|
|
description: "one of the weights is MaxInt",
|
|
configs: []priorities.PriorityConfig{{Weight: api.MaxInt}, {Weight: 5}},
|
|
expected: true,
|
|
},
|
|
{
|
|
description: "after multiplication with MaxPriority the weight is larger than MaxWeight",
|
|
configs: []priorities.PriorityConfig{{Weight: api.MaxInt/api.MaxPriority + api.MaxPriority}, {Weight: 5}},
|
|
expected: true,
|
|
},
|
|
{
|
|
description: "normal weights",
|
|
configs: []priorities.PriorityConfig{{Weight: 10000}, {Weight: 5}},
|
|
expected: false,
|
|
},
|
|
}
|
|
for _, test := range tests {
|
|
t.Run(test.description, func(t *testing.T) {
|
|
err := validateSelectedConfigs(test.configs)
|
|
if test.expected {
|
|
if err == nil {
|
|
t.Errorf("Expected Overflow")
|
|
}
|
|
} else {
|
|
if err != nil {
|
|
t.Errorf("Did not expect an overflow")
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestBuildScoringFunctionShapeFromRequestedToCapacityRatioArguments(t *testing.T) {
|
|
arguments := api.RequestedToCapacityRatioArguments{
|
|
UtilizationShape: []api.UtilizationShapePoint{
|
|
{Utilization: 10, Score: 1},
|
|
{Utilization: 30, Score: 5},
|
|
{Utilization: 70, Score: 2},
|
|
}}
|
|
builtShape := buildScoringFunctionShapeFromRequestedToCapacityRatioArguments(&arguments)
|
|
expectedShape, _ := priorities.NewFunctionShape([]priorities.FunctionShapePoint{
|
|
{Utilization: 10, Score: 1},
|
|
{Utilization: 30, Score: 5},
|
|
{Utilization: 70, Score: 2},
|
|
})
|
|
assert.Equal(t, expectedShape, builtShape)
|
|
}
|