eac2049fc9
Previously, the fake RESTClient in client-go required a Registry. It used the Registry to fetch the GroupVersion for the fake client. However, the way it did so was dubious in some cases (it hard-coded the default API group in places), and not strictly necssary. This updates the fake client to just recieve the GroupVersion and internal group name directly, instead of requiring a Registry, so that it can be consumed in unit tests where a Registry isn't necessarily readily available (e.g. elsewhere in client-go).
346 lines
9.1 KiB
Go
346 lines
9.1 KiB
Go
/*
|
|
Copyright 2016 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package set
|
|
|
|
import (
|
|
"bytes"
|
|
"net/http"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
restclient "k8s.io/client-go/rest"
|
|
"k8s.io/client-go/rest/fake"
|
|
"k8s.io/kubernetes/pkg/api"
|
|
"k8s.io/kubernetes/pkg/api/legacyscheme"
|
|
"k8s.io/kubernetes/pkg/apis/batch"
|
|
"k8s.io/kubernetes/pkg/apis/extensions"
|
|
cmdtesting "k8s.io/kubernetes/pkg/kubectl/cmd/testing"
|
|
"k8s.io/kubernetes/pkg/printers"
|
|
)
|
|
|
|
func TestUpdateSelectorForObjectTypes(t *testing.T) {
|
|
before := metav1.LabelSelector{MatchLabels: map[string]string{"fee": "true"},
|
|
MatchExpressions: []metav1.LabelSelectorRequirement{
|
|
{
|
|
Key: "foo",
|
|
Operator: metav1.LabelSelectorOpIn,
|
|
Values: []string{"on", "yes"},
|
|
},
|
|
}}
|
|
|
|
rc := api.ReplicationController{}
|
|
ser := api.Service{}
|
|
dep := extensions.Deployment{Spec: extensions.DeploymentSpec{Selector: &before}}
|
|
ds := extensions.DaemonSet{Spec: extensions.DaemonSetSpec{Selector: &before}}
|
|
rs := extensions.ReplicaSet{Spec: extensions.ReplicaSetSpec{Selector: &before}}
|
|
job := batch.Job{Spec: batch.JobSpec{Selector: &before}}
|
|
pvc := api.PersistentVolumeClaim{Spec: api.PersistentVolumeClaimSpec{Selector: &before}}
|
|
sa := api.ServiceAccount{}
|
|
type args struct {
|
|
obj runtime.Object
|
|
selector metav1.LabelSelector
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
wantErr bool
|
|
}{
|
|
{name: "rc",
|
|
args: args{
|
|
obj: &rc,
|
|
selector: metav1.LabelSelector{},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{name: "ser",
|
|
args: args{
|
|
obj: &ser,
|
|
selector: metav1.LabelSelector{},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{name: "dep",
|
|
args: args{
|
|
obj: &dep,
|
|
selector: metav1.LabelSelector{},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{name: "ds",
|
|
args: args{
|
|
obj: &ds,
|
|
selector: metav1.LabelSelector{},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{name: "rs",
|
|
args: args{
|
|
obj: &rs,
|
|
selector: metav1.LabelSelector{},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{name: "job",
|
|
args: args{
|
|
obj: &job,
|
|
selector: metav1.LabelSelector{},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{name: "pvc - no updates",
|
|
args: args{
|
|
obj: &pvc,
|
|
selector: metav1.LabelSelector{},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{name: "sa - no selector",
|
|
args: args{
|
|
obj: &sa,
|
|
selector: metav1.LabelSelector{},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
if err := updateSelectorForObject(tt.args.obj, tt.args.selector); (err != nil) != tt.wantErr {
|
|
t.Errorf("%q. updateSelectorForObject() error = %v, wantErr %v", tt.name, err, tt.wantErr)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestUpdateNewSelectorValuesForObject(t *testing.T) {
|
|
ser := api.Service{}
|
|
type args struct {
|
|
obj runtime.Object
|
|
selector metav1.LabelSelector
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
wantErr bool
|
|
}{
|
|
{name: "empty",
|
|
args: args{
|
|
obj: &ser,
|
|
selector: metav1.LabelSelector{
|
|
MatchLabels: map[string]string{},
|
|
MatchExpressions: []metav1.LabelSelectorRequirement{},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{name: "label-only",
|
|
args: args{
|
|
obj: &ser,
|
|
selector: metav1.LabelSelector{
|
|
MatchLabels: map[string]string{"b": "u"},
|
|
MatchExpressions: []metav1.LabelSelectorRequirement{},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
if err := updateSelectorForObject(tt.args.obj, tt.args.selector); (err != nil) != tt.wantErr {
|
|
t.Errorf("%q. updateSelectorForObject() error = %v, wantErr %v", tt.name, err, tt.wantErr)
|
|
}
|
|
|
|
assert.EqualValues(t, tt.args.selector.MatchLabels, ser.Spec.Selector, tt.name)
|
|
|
|
}
|
|
}
|
|
|
|
func TestUpdateOldSelectorValuesForObject(t *testing.T) {
|
|
ser := api.Service{Spec: api.ServiceSpec{Selector: map[string]string{"fee": "true"}}}
|
|
type args struct {
|
|
obj runtime.Object
|
|
selector metav1.LabelSelector
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
wantErr bool
|
|
}{
|
|
{name: "empty",
|
|
args: args{
|
|
obj: &ser,
|
|
selector: metav1.LabelSelector{
|
|
MatchLabels: map[string]string{},
|
|
MatchExpressions: []metav1.LabelSelectorRequirement{},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{name: "label-only",
|
|
args: args{
|
|
obj: &ser,
|
|
selector: metav1.LabelSelector{
|
|
MatchLabels: map[string]string{"fee": "false", "x": "y"},
|
|
MatchExpressions: []metav1.LabelSelectorRequirement{},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{name: "expr-only - err",
|
|
args: args{
|
|
obj: &ser,
|
|
selector: metav1.LabelSelector{
|
|
MatchLabels: map[string]string{},
|
|
MatchExpressions: []metav1.LabelSelectorRequirement{
|
|
{
|
|
Key: "a",
|
|
Operator: "In",
|
|
Values: []string{"x", "y"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{name: "both - err",
|
|
args: args{
|
|
obj: &ser,
|
|
selector: metav1.LabelSelector{
|
|
MatchLabels: map[string]string{"b": "u"},
|
|
MatchExpressions: []metav1.LabelSelectorRequirement{
|
|
{
|
|
Key: "a",
|
|
Operator: "In",
|
|
Values: []string{"x", "y"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
err := updateSelectorForObject(tt.args.obj, tt.args.selector)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("%q. updateSelectorForObject() error = %v, wantErr %v", tt.name, err, tt.wantErr)
|
|
} else if !tt.wantErr {
|
|
assert.EqualValues(t, tt.args.selector.MatchLabels, ser.Spec.Selector, tt.name)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestGetResourcesAndSelector(t *testing.T) {
|
|
type args struct {
|
|
args []string
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
wantResources []string
|
|
wantSelector *metav1.LabelSelector
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "basic match",
|
|
args: args{args: []string{"rc/foo", "healthy=true"}},
|
|
wantResources: []string{"rc/foo"},
|
|
wantErr: false,
|
|
wantSelector: &metav1.LabelSelector{
|
|
MatchLabels: map[string]string{"healthy": "true"},
|
|
MatchExpressions: []metav1.LabelSelectorRequirement{},
|
|
},
|
|
},
|
|
{
|
|
name: "basic expression",
|
|
args: args{args: []string{"rc/foo", "buildType notin (debug, test)"}},
|
|
wantResources: []string{"rc/foo"},
|
|
wantErr: false,
|
|
wantSelector: &metav1.LabelSelector{
|
|
MatchLabels: map[string]string{},
|
|
MatchExpressions: []metav1.LabelSelectorRequirement{
|
|
{
|
|
Key: "buildType",
|
|
Operator: "NotIn",
|
|
Values: []string{"debug", "test"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "selector error",
|
|
args: args{args: []string{"rc/foo", "buildType notthis (debug, test)"}},
|
|
wantResources: []string{"rc/foo"},
|
|
wantErr: true,
|
|
wantSelector: &metav1.LabelSelector{
|
|
MatchLabels: map[string]string{},
|
|
MatchExpressions: []metav1.LabelSelectorRequirement{},
|
|
},
|
|
},
|
|
{
|
|
name: "no resource and selector",
|
|
args: args{args: []string{}},
|
|
wantResources: []string{},
|
|
wantErr: false,
|
|
wantSelector: nil,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
gotResources, gotSelector, err := getResourcesAndSelector(tt.args.args)
|
|
if err != nil {
|
|
if !tt.wantErr {
|
|
t.Errorf("%q. getResourcesAndSelector() error = %v, wantErr %v", tt.name, err, tt.wantErr)
|
|
}
|
|
continue
|
|
}
|
|
if !reflect.DeepEqual(gotResources, tt.wantResources) {
|
|
t.Errorf("%q. getResourcesAndSelector() gotResources = %v, want %v", tt.name, gotResources, tt.wantResources)
|
|
}
|
|
if !reflect.DeepEqual(gotSelector, tt.wantSelector) {
|
|
t.Errorf("%q. getResourcesAndSelector() gotSelector = %v, want %v", tt.name, gotSelector, tt.wantSelector)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSelectorTest(t *testing.T) {
|
|
f, tf, codec, ns := cmdtesting.NewAPIFactory()
|
|
tf.Client = &fake.RESTClient{
|
|
GroupVersion: legacyscheme.Registry.GroupOrDie(api.GroupName).GroupVersion,
|
|
NegotiatedSerializer: ns,
|
|
Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) {
|
|
t.Fatalf("unexpected request: %s %#v\n%#v", req.Method, req.URL, req)
|
|
return nil, nil
|
|
}),
|
|
}
|
|
tf.Namespace = "test"
|
|
tf.ClientConfig = &restclient.Config{ContentConfig: restclient.ContentConfig{GroupVersion: &legacyscheme.Registry.GroupOrDie(api.GroupName).GroupVersion}}
|
|
|
|
buf := bytes.NewBuffer([]byte{})
|
|
cmd := NewCmdSelector(f, buf)
|
|
cmd.SetOutput(buf)
|
|
cmd.Flags().Set("output", "name")
|
|
cmd.Flags().Set("local", "true")
|
|
cmd.Flags().Set("filename", "../../../../examples/storage/cassandra/cassandra-service.yaml")
|
|
|
|
mapper, typer := f.Object()
|
|
tf.Printer = &printers.NamePrinter{Decoders: []runtime.Decoder{codec}, Typer: typer, Mapper: mapper}
|
|
cmd.Run(cmd, []string{"environment=qa"})
|
|
|
|
if !strings.Contains(buf.String(), "services/cassandra") {
|
|
t.Errorf("did not set selector: %s", buf.String())
|
|
}
|
|
}
|