github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
cada0270fe
kubernetes/pkg/kubelet/server
History
Humble Chirammal cada0270fe Fix nil pointer dereference in metrics value calculator. 
The metrics structure passed to volume stat calculator
can contain real stats on subset of metrics fields. For example,
the metrics structure filled by a CSI driver can have
either INODES or BYTES filled, IOW it a valid return.
In such cases the volume stat calculator panic with below
trace:

0516 21:36:19.013143   14452 runtime.go:69] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
/home/hchiramm/gopath/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:76
/home/hchiramm/gopath/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:65
/home/hchiramm/gopath/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:51
/usr/local/go/src/runtime/panic.go:522
/usr/local/go/src/runtime/panic.go:82
/usr/local/go/src/runtime/signal_unix.go:390
/home/hchiramm/gopath/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/api/resource/quantity.go:697
/home/hchiramm/gopath/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/api/resource/quantity.go:685
/home/hchiramm/gopath/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/kubelet/server/stats/volume_stat_calculator.go:144
/home/hchiramm/gopath/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/kubelet/server/stats/volume_stat_calculator.go:125
/home/hchiramm/gopath/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/kubelet/server/stats/volume_stat_calculator.go:65
/home/hchiramm/gopath/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:152
/home/hchiramm/gopath/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:153
/usr/local/go/src/runtime/asm_amd64.s:1337

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-05-27 16:36:39 +05:30
..
metrics Remove the host label from the kubelet http traffic metrics 2019-05-10 13:46:35 -07:00
portforward New staging repository for cri-api 2019-03-26 18:21:04 -04:00
remotecommand Fix golint failures 2019-02-12 07:14:57 -05:00
stats Fix nil pointer dereference in metrics value calculator. 2019-05-27 16:36:39 +05:30
streaming New staging repository for cri-api 2019-03-26 18:21:04 -04:00
auth_test.go Wire kubelet authn/authz 2016-10-25 03:40:09 -04:00
auth.go Fix lint on pkg/kubelet/server/... 2019-02-21 10:31:41 -05:00
BUILD Add metrics to monitor the kubelet http server 2019-04-11 14:16:57 -07:00
doc.go Use Go canonical import paths 2016-07-16 13:48:21 -04:00
server_test.go Add metrics to monitor the kubelet http server 2019-04-11 14:16:57 -07:00
server_websocket_test.go Update unit test. 2018-05-31 15:26:32 -07:00
server.go Remove the host label from the kubelet http traffic metrics 2019-05-10 13:46:35 -07:00