kubernetes/pkg/controller/volume/attachdetach
Kubernetes Submit Queue c34b359bd7 Merge pull request #45923 from verult/cxing/NodeStatusUpdaterFix
Automatic merge from submit-queue (batch tested with PRs 46383, 45645, 45923, 44884, 46294)

Node status updater now deletes the node entry in attach updates...

… when node is missing in NodeInformer cache.

- Added RemoveNodeFromAttachUpdates as part of node status updater operations.



**What this PR does / why we need it**: Fixes issue of unnecessary node status updates when node is deleted.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #42438

**Special notes for your reviewer**: Unit tested added, but a more comprehensive test involving the attach detach controller requires certain testing functionality that is currently absent, and will require larger effort. Will be added at a later time.

There is an edge case caused by the following steps:
1) A node is deleted and restarted. The node exists, but is not yet recognized by Kubernetes.
2) A pod requiring a volume attach with nodeName specifically set to this node.

This would make the pod stuck in ContainerCreating state. This is low-pri since it's a specific edge case that can be avoided.

**Release note**:

```release-note
NONE
```
2017-05-26 12:58:02 -07:00
..
cache Merge pull request #45923 from verult/cxing/NodeStatusUpdaterFix 2017-05-26 12:58:02 -07:00
populator Add Keepterminatedpodvolumes as a annotation on node 2017-05-11 22:31:14 -04:00
reconciler fix regression in UX experience for double attach volume 2017-05-25 09:27:24 +08:00
statusupdater Node status updater now deletes the node entry in attach updates when node is missing in NodeInformer cache. Fixes #42438. 2017-05-24 18:31:47 -07:00
testing Don't try to attach volumes which are already attached to other nodes 2017-05-18 06:56:30 +02:00
util Add Keepterminatedpodvolumes as a annotation on node 2017-05-11 22:31:14 -04:00
attach_detach_controller_test.go detach the volume when pod is terminated 2017-05-11 22:18:22 -04:00
attach_detach_controller.go fix regression in UX experience for double attach volume 2017-05-25 09:27:24 +08:00
BUILD Fix issue #34242: Attach/detach should recover from a crash 2017-04-20 13:04:50 +02:00
OWNERS Update OWNERS approvers and reviewers: pkg/controller 2016-11-02 16:19:18 -07:00