kubernetes/cmd
Kubernetes Submit Queue 10b8665a1c
Merge pull request #63991 from neolit123/test-upgrade-diff
Automatic merge from submit-queue (batch tested with PRs 62025, 63851, 64077, 63967, 63991). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add unit tests to `kubeadm upgrade diff` and small improvements

**What this PR does / why we need it**:

has a couple of commits:

I.
```
1) Store the io.Writer and pass it to sub-commands in upgrade.go
2) Check if the manifest path is an empty string in diff.go:runDiff()
3) Use the io.Writer that upgrade.go defines instead of writing to
os.Stdout directly.
```
II.
```
Add the file diff_test.go, which has a single test:
  TestRunDiff

The test covers most error cases for the runDiff() function,
and also performs a valid diff.
```


**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes kubernetes/kubeadm#826

**Special notes for your reviewer**:
@liztio @luxas 

**Release note**:

```release-note
NONE
```
2018-05-22 08:40:30 -07:00
..
clicheck wire config flags through factory 2018-05-04 17:02:20 -04:00
cloud-controller-manager pass stop channel to node-controller 2018-05-15 17:08:35 +08:00
controller-manager Revert "Revert "scheduler: align with ctrl-managers and apiservers, add https+auth in options"" 2018-05-15 13:09:55 +02:00
gendocs wire config flags through factory 2018-05-04 17:02:20 -04:00
genkubedocs Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
genman wire config flags through factory 2018-05-04 17:02:20 -04:00
genswaggertypedocs Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
genutils Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
genyaml wire config flags through factory 2018-05-04 17:02:20 -04:00
hyperkube Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
importverifier fix message output for import verifier 2018-05-10 12:50:28 -04:00
kube-apiserver Use Dial with context 2018-05-19 08:14:37 +10:00
kube-controller-manager Merge pull request #63049 from andrewsykim/kcm-nodeipam 2018-05-11 11:07:12 -07:00
kube-proxy Add --ipvs-exclude-cidrs flag to kube-proxy. 2018-04-13 10:09:14 -07:00
kube-scheduler fix little bug in kube-scheduler options 2018-05-17 16:59:39 +08:00
kubeadm Merge pull request #63991 from neolit123/test-upgrade-diff 2018-05-22 08:40:30 -07:00
kubectl Merge pull request #60339 from mikedanese/deadpkg 2018-03-28 09:39:15 -07:00
kubelet Merge pull request #63221 from mtaufen/dkcfg-live-configmap 2018-05-21 17:05:42 -07:00
kubemark Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
linkcheck Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
BUILD gke-certificates-controller: rm -rf 2018-02-15 12:01:00 -08:00
OWNERS