fb4b380fe2
It's not enough to silently drop the volume type if the feature is disabled. Instead, the policy should fail validation, just as it would have if the API server didn't know about the feature at all.
105 lines
3.2 KiB
Go
105 lines
3.2 KiB
Go
/*
|
|
Copyright 2015 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package podsecuritypolicy
|
|
|
|
import (
|
|
"context"
|
|
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"k8s.io/apimachinery/pkg/util/validation/field"
|
|
"k8s.io/apiserver/pkg/registry/rest"
|
|
"k8s.io/apiserver/pkg/storage/names"
|
|
utilfeature "k8s.io/apiserver/pkg/util/feature"
|
|
"k8s.io/kubernetes/pkg/api/legacyscheme"
|
|
psputil "k8s.io/kubernetes/pkg/api/podsecuritypolicy"
|
|
"k8s.io/kubernetes/pkg/apis/policy"
|
|
"k8s.io/kubernetes/pkg/apis/policy/validation"
|
|
"k8s.io/kubernetes/pkg/features"
|
|
)
|
|
|
|
// strategy implements behavior for PodSecurityPolicy objects
|
|
type strategy struct {
|
|
runtime.ObjectTyper
|
|
names.NameGenerator
|
|
}
|
|
|
|
// Strategy is the default logic that applies when creating and updating PodSecurityPolicy
|
|
// objects via the REST API.
|
|
var Strategy = strategy{legacyscheme.Scheme, names.SimpleNameGenerator}
|
|
|
|
var _ = rest.RESTCreateStrategy(Strategy)
|
|
|
|
var _ = rest.RESTUpdateStrategy(Strategy)
|
|
|
|
func (strategy) NamespaceScoped() bool {
|
|
return false
|
|
}
|
|
|
|
func (strategy) AllowCreateOnUpdate() bool {
|
|
return false
|
|
}
|
|
|
|
func (strategy) AllowUnconditionalUpdate() bool {
|
|
return true
|
|
}
|
|
|
|
func (strategy) PrepareForCreate(ctx context.Context, obj runtime.Object) {
|
|
psp := obj.(*policy.PodSecurityPolicy)
|
|
|
|
psputil.DropDisabledFields(&psp.Spec, nil)
|
|
}
|
|
|
|
func (strategy) PrepareForUpdate(ctx context.Context, obj, old runtime.Object) {
|
|
newPsp := obj.(*policy.PodSecurityPolicy)
|
|
oldPsp := old.(*policy.PodSecurityPolicy)
|
|
|
|
psputil.DropDisabledFields(&newPsp.Spec, &oldPsp.Spec)
|
|
}
|
|
|
|
func (strategy) Canonicalize(obj runtime.Object) {
|
|
}
|
|
|
|
func (strategy) Validate(ctx context.Context, obj runtime.Object) field.ErrorList {
|
|
opts := validation.PodSecurityPolicyValidationOptions{
|
|
// Only allowed if the feature is enabled.
|
|
AllowEphemeralVolumeType: utilfeature.DefaultFeatureGate.Enabled(features.GenericEphemeralVolume),
|
|
}
|
|
return validation.ValidatePodSecurityPolicy(obj.(*policy.PodSecurityPolicy), opts)
|
|
}
|
|
|
|
func (strategy) ValidateUpdate(ctx context.Context, obj, old runtime.Object) field.ErrorList {
|
|
opts := validation.PodSecurityPolicyValidationOptions{
|
|
// Allowed if the feature is enabled or the old policy already had it.
|
|
// A policy that had the type set when that was valid must remain valid.
|
|
AllowEphemeralVolumeType: utilfeature.DefaultFeatureGate.Enabled(features.GenericEphemeralVolume) ||
|
|
volumeInUse(old.(*policy.PodSecurityPolicy), policy.Ephemeral),
|
|
}
|
|
return validation.ValidatePodSecurityPolicyUpdate(old.(*policy.PodSecurityPolicy), obj.(*policy.PodSecurityPolicy), opts)
|
|
}
|
|
|
|
func volumeInUse(oldPSP *policy.PodSecurityPolicy, volume policy.FSType) bool {
|
|
if oldPSP == nil {
|
|
return false
|
|
}
|
|
for _, v := range oldPSP.Spec.Volumes {
|
|
if v == volume {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|