
Prior to 1.22 a user could change NodePort values within a service during an update, and the apiserver would allocate values for any that were not specified. Consider a YAML like: ``` apiVersion: v1 kind: Service metadata: name: foo spec: type: NodePort ports: - name: p port: 80 - name: q port: 81 selector: app: foo ``` When this is created, nodeport values will be allocated for each port. Something like: ``` apiVersion: v1 kind: Service metadata: name: foo spec: clusterIP: 10.0.149.11 type: NodePort ports: - name: p nodePort: 30872 port: 80 protocol: TCP targetPort: 9376 - name: q nodePort: 31310 port: 81 protocol: TCP targetPort: 81 selector: app: foo ``` If the user PUTs (kubectl replace) the original YAML, we would see that `.nodePort = 0`, and allocate new ports. This was ugly at best. In 1.22 we fixed this to not allocate new values if we still had the old values, but instead re-assign them. Net new ports would still be seen as `.nodePort = 0` and so new allocations would be made. This broke a corner case as follows: Prior to 1.22, the user could PUT this YAML: ``` apiVersion: v1 kind: Service metadata: name: foo spec: type: NodePort ports: - name: p nodePort: 31310 # note this is the `q` value port: 80 - name: q # note this nodePort is not specified port: 81 selector: app: foo ``` The `p` port would take the `q` port's value. The `q` port would be seen as `.nodePort = 0` and a new value allocated. In 1.22 this results in an error (duplicate value in `p` and `q`). This is VERY minor but it is an API regression, which we try to avoid, and the fix is not too horrible. This commit adds more robust testing of this logic.
178 lines
5.4 KiB
Go
178 lines
5.4 KiB
Go
/*
|
|
Copyright 2021 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package testing
|
|
|
|
import (
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/util/intstr"
|
|
utilpointer "k8s.io/utils/pointer"
|
|
|
|
api "k8s.io/kubernetes/pkg/apis/core"
|
|
)
|
|
|
|
// Tweak is a function that modifies a Service.
|
|
type Tweak func(*api.Service)
|
|
|
|
// MakeService helps construct Service objects (which pass API validation) more
|
|
// legibly and tersely than a Go struct definition. By default this produces
|
|
// a ClusterIP service with a single port and a trivial selector. The caller
|
|
// can pass any number of tweak functions to further modify the result.
|
|
func MakeService(name string, tweaks ...Tweak) *api.Service {
|
|
// NOTE: Any field that would be populated by defaulting needs to be
|
|
// present and valid here.
|
|
svc := &api.Service{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: name,
|
|
Namespace: metav1.NamespaceDefault,
|
|
},
|
|
Spec: api.ServiceSpec{
|
|
Selector: map[string]string{"k": "v"},
|
|
SessionAffinity: api.ServiceAffinityNone,
|
|
},
|
|
}
|
|
// Default to ClusterIP
|
|
SetTypeClusterIP(svc)
|
|
// Default to 1 port
|
|
SetPorts(MakeServicePort("", 93, intstr.FromInt(76), api.ProtocolTCP))(svc)
|
|
// Default internalTrafficPolicy to "Cluster"
|
|
SetInternalTrafficPolicy(api.ServiceInternalTrafficPolicyCluster)(svc)
|
|
|
|
for _, tweak := range tweaks {
|
|
tweak(svc)
|
|
}
|
|
|
|
return svc
|
|
}
|
|
|
|
// SetTypeClusterIP sets the service type to ClusterIP and clears other fields.
|
|
func SetTypeClusterIP(svc *api.Service) {
|
|
svc.Spec.Type = api.ServiceTypeClusterIP
|
|
for i := range svc.Spec.Ports {
|
|
svc.Spec.Ports[i].NodePort = 0
|
|
}
|
|
svc.Spec.ExternalName = ""
|
|
svc.Spec.ExternalTrafficPolicy = ""
|
|
svc.Spec.AllocateLoadBalancerNodePorts = nil
|
|
}
|
|
|
|
// SetTypeNodePort sets the service type to NodePort and clears other fields.
|
|
func SetTypeNodePort(svc *api.Service) {
|
|
svc.Spec.Type = api.ServiceTypeNodePort
|
|
svc.Spec.ExternalTrafficPolicy = api.ServiceExternalTrafficPolicyTypeCluster
|
|
svc.Spec.ExternalName = ""
|
|
svc.Spec.AllocateLoadBalancerNodePorts = nil
|
|
}
|
|
|
|
// SetTypeLoadBalancer sets the service type to LoadBalancer and clears other fields.
|
|
func SetTypeLoadBalancer(svc *api.Service) {
|
|
svc.Spec.Type = api.ServiceTypeLoadBalancer
|
|
svc.Spec.ExternalTrafficPolicy = api.ServiceExternalTrafficPolicyTypeCluster
|
|
svc.Spec.AllocateLoadBalancerNodePorts = utilpointer.BoolPtr(true)
|
|
svc.Spec.ExternalName = ""
|
|
}
|
|
|
|
// SetTypeExternalName sets the service type to ExternalName and clears other fields.
|
|
func SetTypeExternalName(svc *api.Service) {
|
|
svc.Spec.Type = api.ServiceTypeExternalName
|
|
svc.Spec.ExternalName = "example.com"
|
|
svc.Spec.ExternalTrafficPolicy = ""
|
|
svc.Spec.ClusterIP = ""
|
|
svc.Spec.ClusterIPs = nil
|
|
svc.Spec.AllocateLoadBalancerNodePorts = nil
|
|
}
|
|
|
|
// SetPorts sets the service ports list.
|
|
func SetPorts(ports ...api.ServicePort) Tweak {
|
|
return func(svc *api.Service) {
|
|
svc.Spec.Ports = ports
|
|
}
|
|
}
|
|
|
|
// MakeServicePort helps construct ServicePort objects which pass API
|
|
// validation.
|
|
func MakeServicePort(name string, port int, tgtPort intstr.IntOrString, proto api.Protocol) api.ServicePort {
|
|
return api.ServicePort{
|
|
Name: name,
|
|
Port: int32(port),
|
|
TargetPort: tgtPort,
|
|
Protocol: proto,
|
|
}
|
|
}
|
|
|
|
// SetClusterIPs sets the service ClusterIP and ClusterIPs fields.
|
|
func SetClusterIPs(ips ...string) Tweak {
|
|
return func(svc *api.Service) {
|
|
svc.Spec.ClusterIP = ips[0]
|
|
svc.Spec.ClusterIPs = ips
|
|
}
|
|
}
|
|
|
|
// SetIPFamilies sets the service IPFamilies field.
|
|
func SetIPFamilies(families ...api.IPFamily) Tweak {
|
|
return func(svc *api.Service) {
|
|
svc.Spec.IPFamilies = families
|
|
}
|
|
}
|
|
|
|
// SetIPFamilyPolicy sets the service IPFamilyPolicy field.
|
|
func SetIPFamilyPolicy(policy api.IPFamilyPolicyType) Tweak {
|
|
return func(svc *api.Service) {
|
|
svc.Spec.IPFamilyPolicy = &policy
|
|
}
|
|
}
|
|
|
|
// SetNodePorts sets the values for each node port, in order. If less values
|
|
// are specified than there are ports, the rest are untouched.
|
|
func SetNodePorts(values ...int) Tweak {
|
|
return func(svc *api.Service) {
|
|
for i := range svc.Spec.Ports {
|
|
if i >= len(values) {
|
|
break
|
|
}
|
|
svc.Spec.Ports[i].NodePort = int32(values[i])
|
|
}
|
|
}
|
|
}
|
|
|
|
// SetInternalTrafficPolicy sets the internalTrafficPolicy field for a Service.
|
|
func SetInternalTrafficPolicy(policy api.ServiceInternalTrafficPolicyType) Tweak {
|
|
return func(svc *api.Service) {
|
|
svc.Spec.InternalTrafficPolicy = &policy
|
|
}
|
|
}
|
|
|
|
// SetExternalTrafficPolicy sets the externalTrafficPolicy field for a Service.
|
|
func SetExternalTrafficPolicy(policy api.ServiceExternalTrafficPolicyType) Tweak {
|
|
return func(svc *api.Service) {
|
|
svc.Spec.ExternalTrafficPolicy = policy
|
|
}
|
|
}
|
|
|
|
// SetAllocateLoadBalancerNodePorts sets the allocate LB node port field.
|
|
func SetAllocateLoadBalancerNodePorts(val bool) Tweak {
|
|
return func(svc *api.Service) {
|
|
svc.Spec.AllocateLoadBalancerNodePorts = utilpointer.BoolPtr(val)
|
|
}
|
|
}
|
|
|
|
// SetHealthCheckNodePort sets the healthCheckNodePort field for a Service.
|
|
func SetHealthCheckNodePort(value int32) Tweak {
|
|
return func(svc *api.Service) {
|
|
svc.Spec.HealthCheckNodePort = value
|
|
}
|
|
}
|