Kubernetes Submit Queue a1933f8efb Merge pull request #50225 from tcharding/kubectl-run-log ...

Automatic merge from submit-queue (batch tested with PRs 49847, 49743, 49853, 50225, 50479)

Remove duplicate logging code

**What this PR does / why we need it**:

Currently function `handleAttachPod` contains duplicate code which copies the AttachOptions output writer to the pod logging writer. This code can be refactored into a separate function. 

**Special notes for your reviewer**:

Refactor only, does not change program logic.

**Release note**:
```release-note
NONE
```

/sig cli
/kind cleanup

2017-08-12 02:35:59 -07:00

..

auth

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

config

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

rollout

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

set

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

templates

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

testdata/edit

Merge pull request #50205 from dixudx/fix_kubectl_edit_panic_nil_list

2017-08-11 19:44:04 -07:00

testing

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

util

Merge pull request #50205 from dixudx/fix_kubectl_edit_panic_nil_list

2017-08-11 19:44:04 -07:00

alpha.go

Create a kubectl alpha subcommand

2017-06-16 07:09:21 +00:00

annotate_test.go

fix parse pairs

2017-06-05 11:06:48 +08:00

annotate.go

remove dead code

2017-07-07 09:12:29 -04:00

apiversions.go

Fix kubectl api-versions caching

2017-06-24 01:14:31 -04:00

apply_edit_last_applied.go

kubectl: fix inaccurate usage messages for --windows-line-endings

2017-06-23 09:49:30 -07:00

apply_set_last_applied.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

apply_test.go

Protect against nil panic in apply

2017-07-18 12:55:34 -03:00

apply_view_last_applied.go

Merge pull request #45611 from atombender/issue-45608

2017-06-28 12:55:21 -07:00

apply.go

Protect against nil panic in apply

2017-07-18 12:55:34 -03:00

attach_test.go

clean up: put test description in head to locate quickly

2017-05-19 02:04:59 +08:00

attach.go

Prepare to introduce websockets for exec and portforward

2017-07-07 18:22:51 -04:00

autoscale.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

BUILD

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

certificates.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

clusterinfo_dump_test.go

Move the common test functions from cmd_test.go to cmd/testing/fake.go

2016-10-19 08:53:26 +10:00

clusterinfo_dump.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

clusterinfo.go

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

cmd_test.go

Move more printers to TablePrinter

2017-06-26 11:38:36 -04:00

cmd.go

Add customresourcedefinition and its shortcut in "kubectl get"

2017-07-18 15:31:56 +08:00

completion.go

Fix a bug that --flag=val causes completion error in zsh

2017-07-31 23:12:55 +09:00

convert.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

cp_test.go

add kubectl cp

2016-10-29 20:24:54 -07:00

cp.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

create_clusterrole_test.go

Merge pull request #46265 from waseem/printers-genericity

2017-06-02 19:53:40 -07:00

create_clusterrole.go

support NonResourceURL for kubectl create clusterrole

2017-05-26 10:07:44 +08:00

create_clusterrolebinding.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_configmap_test.go

client/restclient/fake move to client-go

2017-01-25 08:29:48 -05:00

create_configmap.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_deployment_test.go

kubectl/deployment: add BaseDeploymentGenerator to reduce duplication

2017-07-18 13:17:45 -07:00

create_deployment.go

kubectl/deployment: add BaseDeploymentGenerator to reduce duplication

2017-07-18 13:17:45 -07:00

create_namespace_test.go

client/restclient/fake move to client-go

2017-01-25 08:29:48 -05:00

create_namespace.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_pdb_test.go

add test for kubectl create pdb

2017-05-26 17:38:26 +08:00

create_pdb.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_quota_test.go

Fix test not use test flags

2017-05-24 10:14:00 +08:00

create_quota.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_role_test.go

Merge pull request #46706 from CaoShuFeng/unit-create-role

2017-06-03 18:30:40 -07:00

create_role.go

allow impersonate serviceaccount in cli

2017-06-29 14:56:46 +08:00

create_rolebinding_test.go

Supplement unit tests to kubectl create rolebinding command.

2017-03-29 16:36:22 +08:00

create_rolebinding.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_secret_test.go

client/restclient/fake move to client-go

2017-01-25 08:29:48 -05:00

create_secret.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

create_service_test.go

add test to cover more in kubectl create service

2017-05-16 18:45:38 +08:00

create_service.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

create_serviceaccount_test.go

client/restclient/fake move to client-go

2017-01-25 08:29:48 -05:00

create_serviceaccount.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_test.go

Distinguish between client and unstructuredclient in fake factory

2017-01-26 19:59:16 -05:00

create.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

delete_test.go

orphan when kubectl delete --cascade=false

2017-05-11 09:11:07 -04:00

delete.go

Remove extraneous white space

2017-08-03 00:01:54 +10:00

describe_test.go

describe: use unstructured objects

2017-01-26 19:59:25 -05:00

describe.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

drain_test.go

Changes for converting node to v1 in drain

2017-07-12 21:36:29 -04:00

drain.go

Merge pull request #50008 from atlassian/meta-controller-ref

2017-08-10 17:07:30 -07:00

edit_test.go

Detect missing steps in edit testcases

2017-08-10 11:01:01 -04:00

edit.go

Merge pull request #46091 from xilabao/new-output-in-edit

2017-07-16 18:04:42 -07:00

exec_test.go

move term to kubectl/util

2017-06-30 15:00:24 -07:00

exec.go

Prepare to introduce websockets for exec and portforward

2017-07-07 18:22:51 -04:00

explain.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

expose_test.go

Refactor commands to use new factory method

2017-02-23 00:28:32 -05:00

expose.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

get_test.go

get_test.go fix error format and info

2017-08-11 10:50:06 +08:00

get.go

Revert "Merge pull request #47353 from apelisse/http-cache"

2017-08-07 16:20:34 -04:00

help.go

Signed-off-by: bruceauyeung <ouyang.qinhua@zte.com.cn>

2017-04-25 15:07:01 +08:00

label_test.go

fix parse pairs

2017-06-05 11:06:48 +08:00

label.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

logs_test.go

client/restclient/fake move to client-go

2017-01-25 08:29:48 -05:00

logs.go

Merge pull request #47217 from CaoShuFeng/trival_fix

2017-07-05 03:21:30 -07:00

options.go

cmd/options: kubectl options writes to out stream

2017-05-28 11:23:44 -07:00

patch_test.go

Denote if a printer is generic.

2017-05-31 13:02:23 +05:30

patch.go

remove dead code

2017-07-07 09:12:29 -04:00

plugin_test.go

kubectl plugins have access config, global flags and environment

2017-05-19 19:17:43 -03:00

plugin.go

Flag support in kubectl plugins

2017-07-18 15:35:40 -03:00

portforward_test.go

kubectl/cmd: remove a bunch of unused parameters

2017-04-04 10:36:30 +01:00

portforward.go

Move SPDY specific code into its own package

2017-07-09 16:11:05 -04:00

proxy.go

Use the UpgradeAwareProxy in kubectl proxy

2017-08-04 12:48:21 -04:00

replace_test.go

Distinguish between client and unstructuredclient in fake factory

2017-01-26 19:59:16 -05:00

replace.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

rollingupdate_test.go

small change to clear

2017-05-11 20:09:31 +08:00

rollingupdate.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

run_test.go

enhance kubectl run error message

2017-07-26 11:24:03 +08:00

run.go

Remove duplicate logging code

2017-08-07 14:13:22 +10:00

scale.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

stop.go

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

taint_test.go

run hack/update-all

2017-06-22 11:31:03 -07:00

taint.go

Refactoring taints to reduce sprawl

2017-07-19 18:36:07 -04:00

top_node_test.go

hack/update-bazal.sh

2017-05-15 13:51:39 -07:00

top_node.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

top_pod_test.go

remove duplicated import and wrong alias name of api package

2017-07-25 10:04:25 +08:00

top_pod.go

kubectl/cmd: many small refactors

2017-06-27 16:25:20 -07:00

top_test.go

remove duplicated import and wrong alias name of api package

2017-07-25 10:04:25 +08:00

top.go

Extract a bunch more strings from kubectl

2017-04-06 20:12:50 -07:00

version.go

Make "kubectl version" json output more readable.

2017-07-18 11:21:35 +08:00