
If a client says they want the name to be generated, a 409 is not appropriate (since they didn't specify a name). Instead, we should return the next most appropriate error, which is a 5xx error indicating the request failed but the client *should* try again. Since there is no 5xx error that exactly fits this purpose, use 500 with StatusReasonTryAgainLater set. This commit does not implement client retry on TryAgainLater, but clients should retry up to a certain number of times.
203 lines
6.0 KiB
Go
203 lines
6.0 KiB
Go
/*
|
|
Copyright 2014 Google Inc. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package resttest
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/GoogleCloudPlatform/kubernetes/pkg/api"
|
|
"github.com/GoogleCloudPlatform/kubernetes/pkg/api/errors"
|
|
"github.com/GoogleCloudPlatform/kubernetes/pkg/apiserver"
|
|
"github.com/GoogleCloudPlatform/kubernetes/pkg/runtime"
|
|
"github.com/GoogleCloudPlatform/kubernetes/pkg/util"
|
|
)
|
|
|
|
type Tester struct {
|
|
*testing.T
|
|
storage apiserver.RESTStorage
|
|
storageError injectErrorFunc
|
|
clusterScope bool
|
|
}
|
|
|
|
type injectErrorFunc func(err error)
|
|
|
|
func New(t *testing.T, storage apiserver.RESTStorage, storageError injectErrorFunc) *Tester {
|
|
return &Tester{
|
|
T: t,
|
|
storage: storage,
|
|
storageError: storageError,
|
|
}
|
|
}
|
|
|
|
func (t *Tester) withStorageError(err error, fn func()) {
|
|
t.storageError(err)
|
|
defer t.storageError(nil)
|
|
fn()
|
|
}
|
|
|
|
func (t *Tester) ClusterScope() *Tester {
|
|
t.clusterScope = true
|
|
return t
|
|
}
|
|
|
|
func copyOrDie(obj runtime.Object) runtime.Object {
|
|
out, err := api.Scheme.Copy(obj)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
return out
|
|
}
|
|
|
|
func (t *Tester) TestCreate(valid runtime.Object, invalid ...runtime.Object) {
|
|
t.TestCreateHasMetadata(copyOrDie(valid))
|
|
t.TestCreateGeneratesName(copyOrDie(valid))
|
|
t.TestCreateGeneratesNameReturnsTryAgain(copyOrDie(valid))
|
|
if t.clusterScope {
|
|
t.TestCreateRejectsNamespace(copyOrDie(valid))
|
|
} else {
|
|
t.TestCreateRejectsMismatchedNamespace(copyOrDie(valid))
|
|
}
|
|
t.TestCreateInvokesValidation(invalid...)
|
|
}
|
|
|
|
func (t *Tester) TestCreateResetsUserData(valid runtime.Object) {
|
|
objectMeta, err := api.ObjectMetaFor(valid)
|
|
if err != nil {
|
|
t.Fatalf("object does not have ObjectMeta: %v\n%#v", err, valid)
|
|
}
|
|
|
|
now := util.Now()
|
|
objectMeta.UID = "bad-uid"
|
|
objectMeta.CreationTimestamp = now
|
|
|
|
channel, err := t.storage.(apiserver.RESTCreater).Create(api.NewDefaultContext(), valid)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
if obj := <-channel; obj.Object == nil {
|
|
t.Fatalf("Unexpected object from channel: %#v", obj)
|
|
}
|
|
if objectMeta.UID == "bad-uid" || objectMeta.CreationTimestamp == now {
|
|
t.Errorf("ObjectMeta did not reset basic fields: %#v", objectMeta)
|
|
}
|
|
}
|
|
|
|
func (t *Tester) TestCreateHasMetadata(valid runtime.Object) {
|
|
objectMeta, err := api.ObjectMetaFor(valid)
|
|
if err != nil {
|
|
t.Fatalf("object does not have ObjectMeta: %v\n%#v", err, valid)
|
|
}
|
|
|
|
objectMeta.Name = "test"
|
|
objectMeta.Namespace = api.NamespaceDefault
|
|
context := api.NewDefaultContext()
|
|
if t.clusterScope {
|
|
objectMeta.Namespace = api.NamespaceNone
|
|
context = api.NewContext()
|
|
}
|
|
|
|
channel, err := t.storage.(apiserver.RESTCreater).Create(context, valid)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
if obj := <-channel; obj.Object == nil {
|
|
t.Fatalf("Unexpected object from channel: %#v", obj)
|
|
}
|
|
if !api.HasObjectMetaSystemFieldValues(objectMeta) {
|
|
t.Errorf("storage did not populate object meta field values")
|
|
}
|
|
}
|
|
|
|
func (t *Tester) TestCreateGeneratesName(valid runtime.Object) {
|
|
objectMeta, err := api.ObjectMetaFor(valid)
|
|
if err != nil {
|
|
t.Fatalf("object does not have ObjectMeta: %v\n%#v", err, valid)
|
|
}
|
|
|
|
objectMeta.GenerateName = "test-"
|
|
|
|
_, err = t.storage.(apiserver.RESTCreater).Create(api.NewDefaultContext(), valid)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
if objectMeta.Name == "test-" || !strings.HasPrefix(objectMeta.Name, "test-") {
|
|
t.Errorf("unexpected name: %#v", valid)
|
|
}
|
|
}
|
|
|
|
func (t *Tester) TestCreateGeneratesNameReturnsTryAgain(valid runtime.Object) {
|
|
objectMeta, err := api.ObjectMetaFor(valid)
|
|
if err != nil {
|
|
t.Fatalf("object does not have ObjectMeta: %v\n%#v", err, valid)
|
|
}
|
|
|
|
objectMeta.GenerateName = "test-"
|
|
t.withStorageError(errors.NewAlreadyExists("kind", "thing"), func() {
|
|
ch, err := t.storage.(apiserver.RESTCreater).Create(api.NewDefaultContext(), valid)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
res := <-ch
|
|
if err := errors.FromObject(res.Object); err == nil || !errors.IsTryAgainLater(err) {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func (t *Tester) TestCreateInvokesValidation(invalid ...runtime.Object) {
|
|
for i, obj := range invalid {
|
|
ctx := api.NewDefaultContext()
|
|
_, err := t.storage.(apiserver.RESTCreater).Create(ctx, obj)
|
|
if !errors.IsInvalid(err) {
|
|
t.Errorf("%d: Expected to get an invalid resource error, got %v", i, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (t *Tester) TestCreateRejectsMismatchedNamespace(valid runtime.Object) {
|
|
objectMeta, err := api.ObjectMetaFor(valid)
|
|
if err != nil {
|
|
t.Fatalf("object does not have ObjectMeta: %v\n%#v", err, valid)
|
|
}
|
|
|
|
objectMeta.Namespace = "not-default"
|
|
|
|
_, err = t.storage.(apiserver.RESTCreater).Create(api.NewDefaultContext(), valid)
|
|
if err == nil {
|
|
t.Errorf("Expected an error, but we didn't get one")
|
|
} else if strings.Contains(err.Error(), "Controller.Namespace does not match the provided context") {
|
|
t.Errorf("Expected 'Controller.Namespace does not match the provided context' error, got '%v'", err.Error())
|
|
}
|
|
}
|
|
|
|
func (t *Tester) TestCreateRejectsNamespace(valid runtime.Object) {
|
|
objectMeta, err := api.ObjectMetaFor(valid)
|
|
if err != nil {
|
|
t.Fatalf("object does not have ObjectMeta: %v\n%#v", err, valid)
|
|
}
|
|
|
|
objectMeta.Namespace = "not-default"
|
|
|
|
_, err = t.storage.(apiserver.RESTCreater).Create(api.NewDefaultContext(), valid)
|
|
if err == nil {
|
|
t.Errorf("Expected an error, but we didn't get one")
|
|
} else if strings.Contains(err.Error(), "Controller.Namespace does not match the provided context") {
|
|
t.Errorf("Expected 'Controller.Namespace does not match the provided context' error, got '%v'", err.Error())
|
|
}
|
|
}
|