github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
d7f6154136
kubernetes/pkg/kubelet
History
Kubernetes Submit Queue d7f6154136
Merge pull request #57658 from andyxning/code_refactor 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove CgroupParent from RunContainerOptions

**What this PR does / why we need it**:
`CgroupParent` argument for a container is derived from sandbox config instead of container config in [dockershim](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/dockershim/helpers_linux.go#L125-L132). The logic to get `cgroupParent` for container is useless.
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:
I may be wrong for only considering docker runtime. But according to cri runtime api, only [`LinuxPodSandboxConfig` has a field `CgroupParent`](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/cri/v1alpha1/runtime/api.pb.go#L590). So i think it is only valid in sandbox config.

BTW, maybe we also need to delete [`CgroupParent` field in `RunContainerOptions` struct](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/container/runtime.go#L432).
**Release note**:

```release-note
None
```
2018-03-29 14:51:04 -07:00
..
apis regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
cadvisor Remove rktnetes code 2018-03-27 09:29:35 -07:00
certificate Merge pull request #59316 from smarterclayton/terminate_early 2018-02-21 15:40:41 -08:00
checkpoint Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
client Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
cm Merge pull request #61525 from tianshapjq/place-consts-together 2018-03-25 09:51:42 -07:00
config Remove rktnetes code 2018-03-27 09:29:35 -07:00
configmap Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
container Merge pull request #57658 from andyxning/code_refactor 2018-03-29 14:51:04 -07:00
custommetrics Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
dockershim Replace "golang.org/x/net/context" with "context" 2018-03-22 20:57:14 +08:00
envvars Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
events Improve messaging on resize 2018-01-29 15:07:51 -05:00
eviction refresh eviction interval periodically 2018-03-06 15:14:05 -08:00
gpu Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
images Promote LocalStorageCapacityIsolation feature to beta 2018-03-02 15:10:08 -08:00
kubeletconfig expunge the word 'manifest' from Kubelet's config API 2018-02-23 11:44:06 -08:00
kuberuntime Merge pull request #60851 from aveshagarwal/master-rhbz-1548987 2018-03-20 15:34:37 -07:00
leaky update BUILD files 2017-10-15 18:18:13 -07:00
lifecycle Support cluster-level extended resources in kubelet and kube-scheduler 2018-02-27 17:25:30 -08:00
logs Generated code 2018-02-23 01:42:35 +00:00
metrics Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
mountpod Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
network Merge pull request #60912 from m1093782566/refactor-hostport 2018-03-20 17:37:10 -07:00
pleg Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
pod Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
preemption Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
prober Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
qos Make a few code paths compile cleanly with 32-bit Go. 2018-02-27 13:53:32 -08:00
remote Replace "golang.org/x/net/context" with "context" 2018-03-22 20:57:14 +08:00
secret Autogenerated: hack/update-bazel.sh 2018-02-16 13:43:01 -08:00
server use status.Errorf instead of Deprecated func grpc.Errorf 2018-03-26 19:17:48 +08:00
stats Add CPU/Memory pod stats for CRI stats. 2018-02-26 19:29:47 +00:00
status Fix PodScheduled bug for static pod. 2018-03-22 01:04:08 +00:00
sysctl Remove rktnetes code 2018-03-27 09:29:35 -07:00
types Merge pull request #61432 from filbranden/killrkt1 2018-03-29 11:46:19 -07:00
util Detect backsteps correctly in base path detection 2018-03-13 02:23:06 -04:00
volumemanager Merge pull request #61373 from msau42/subpath-reconstruct 2018-03-22 06:20:28 -07:00
winstats fix "make test" 2018-02-24 17:39:21 +08:00
active_deadline_test.go
active_deadline.go
BUILD Remove rktnetes code 2018-03-27 09:29:35 -07:00
doc.go
kubelet_getters_test.go
kubelet_getters.go Fix issue with race condition during pod deletion 2018-03-15 15:35:37 -07:00
kubelet_network_test.go Move DNS related kubelet codes into its own package 2017-11-15 10:56:44 -08:00
kubelet_network.go fix all the typos across the project 2018-02-11 11:04:14 +08:00
kubelet_node_status_test.go Promote LocalStorageCapacityIsolation feature to beta 2018-03-02 15:10:08 -08:00
kubelet_node_status.go Promote LocalStorageCapacityIsolation feature to beta 2018-03-02 15:10:08 -08:00
kubelet_pods_test.go Add feature gate for subpath 2018-03-05 09:14:44 +01:00
kubelet_pods_windows_test.go Lock subPath volumes 2018-03-05 09:14:44 +01:00
kubelet_pods.go Merge pull request #57658 from andyxning/code_refactor 2018-03-29 14:51:04 -07:00
kubelet_resources_test.go
kubelet_resources.go apimachinery: remove Scheme.DeepCopy 2017-10-06 14:59:17 +02:00
kubelet_test.go Promote LocalStorageCapacityIsolation feature to beta 2018-03-02 15:10:08 -08:00
kubelet_volumes_test.go update import 2018-02-27 20:23:35 +08:00
kubelet_volumes.go Fix issue with race condition during pod deletion 2018-03-15 15:35:37 -07:00
kubelet.go Remove rktnetes code 2018-03-27 09:29:35 -07:00
oom_watcher_test.go
oom_watcher.go
OWNERS
pod_container_deletor_test.go
pod_container_deletor.go
pod_workers_test.go Correct TestUpdatePod comment 2017-10-20 09:41:18 +08:00
pod_workers.go fixes document grammar 2018-02-20 10:38:41 -05:00
reason_cache_test.go
reason_cache.go
runonce_test.go Share /var/lib/kubernetes on startup 2017-08-30 16:45:04 +02:00
runonce.go fix todo:add function getFailContainer to report which containers failed the pod 2018-03-15 09:38:02 +08:00
runtime.go Remove setInitError. 2018-01-29 21:44:54 -08:00
util.go
volume_host.go update import 2018-02-27 20:23:35 +08:00