Files

Uwe Krueger d8ee8e427e fix sync problem in streamwatcher

The streamwatcher has a synchronization problem that may lead to
a go routine blocking forever when closing a stream watch.

This occasionally happens, when informers are cancelled together with the
watch request using the stop channel, which leads to an increaing
number of blocked go routines, if imformers are dynamicaly created and deleted
again.

The function `receive` checks under a lock whether the watch has been stopped,
before an error is reported to the result channel.
The problem here is, that in between the watcher might be stopped by
calling the `Stop` method. In the actual code this is done by the
`cache.Reflector` using the streamwatcher by a defer which is executed after
the caller already stopped reading from the result channel.
As a result the stopping flag might be set after the check
and trying to send the error event blocks this send operation forever,
because there will never be a receiver again.

The fix introduces a dedicated local stop channel that is closed by the
`Stop` method and used in a select statement together with the send
operation to finally abort the loop.

2021-03-05 17:14:32 +01:00

publishing

staging/publishing: add -mod=mod for smoke tests for go1.16

2021-03-03 09:55:27 +05:30

src/k8s.io

fix sync problem in streamwatcher

2021-03-05 17:14:32 +01:00

OWNERS

*: remove nikhiljindal from OWNERS

2021-02-16 10:59:26 +05:30

README.md

Update README.md

2021-02-25 19:42:33 +08:00

README.md

External Repository Staging Area

This directory is the staging area for packages that have been split to their own repository. The content here will be periodically published to respective top-level k8s.io repositories.

Repositories currently staged here:

The code in the staging/ directory is authoritative, i.e. the only copy of the code. You can directly modify such code.

Using staged repositories from Kubernetes code

Kubernetes code uses the repositories in this directory via symlinks in the vendor/k8s.io directory into this staging area. For example, when Kubernetes code imports a package from the k8s.io/client-go repository, that import is resolved to staging/src/k8s.io/client-go relative to the project root:

// pkg/example/some_code.go
package example

import (
  "k8s.io/client-go/dynamic" // resolves to staging/src/k8s.io/client-go/dynamic
)

Once the change-over to external repositories is complete, these repositories will actually be vendored from k8s.io/<package-name>.

Creating a new repository in staging

Adding the staging repository in `kubernetes/kubernetes`:

Send an email to the SIG Architecture mailing list and the mailing list of the SIG which would own the repo requesting approval for creating the staging repository.
Once approval has been granted, create the new staging repository.
Add a symlink to the staging repo in vendor/k8s.io.
Update import-restrictions.yaml to add the list of other staging repos that this new repo can import.
Add all mandatory template files to the staging repo as mentioned in https://github.com/kubernetes/kubernetes-template-project.
Make sure that the .github/PULL_REQUEST_TEMPLATE.md and CONTRIBUTING.md files mention that PRs are not directly accepted to the repo.

Creating the published repository

Create an issue in the kubernetes/org repo to request creation of the respective published repository in the Kubernetes org. The published repository must have an initial empty commit. It also needs specific access rules and branch settings. See #kubernetes/org#58 for an example.
Setup branch protection and enable access to the stage-bots team by adding the repo in prow/config.yaml. See #kubernetes/test-infra#9292 for an example.
Once the repository has been created in the Kubernetes org, update the publishing-bot to publish the staging repository by updating:
- rules.yaml: Make sure that the list of dependencies reflects the staging repos in the Godeps.json file.
- fetch-all-latest-and-push.sh: Add the staging repo in the list of repos to be published.
Add the staging and published repositories as a subproject for the SIG that owns the repos in sigs.yaml.
Add the repo to the list of staging repos in this README.md file.

README.md

External Repository Staging Area

Using staged repositories from Kubernetes code

Creating a new repository in staging

Adding the staging repository in kubernetes/kubernetes:

Creating the published repository

Adding the staging repository in `kubernetes/kubernetes`: