de37b9d293
This patch makes the CRI `v1` API the new project-wide default version. To allow backwards compatibility, a fallback to `v1alpha2` has been added as well. This fallback can either used by automatically determined by the kubelet. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
442 lines
12 KiB
Go
442 lines
12 KiB
Go
//go:build !dockerless
|
|
// +build !dockerless
|
|
|
|
/*
|
|
Copyright 2016 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package dockershim
|
|
|
|
import (
|
|
"bytes"
|
|
"errors"
|
|
"fmt"
|
|
"sync"
|
|
"testing"
|
|
|
|
dockertypes "github.com/docker/docker/api/types"
|
|
dockernat "github.com/docker/go-connections/nat"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"k8s.io/api/core/v1"
|
|
runtimeapi "k8s.io/cri-api/pkg/apis/runtime/v1"
|
|
"k8s.io/kubernetes/pkg/kubelet/dockershim/libdocker"
|
|
)
|
|
|
|
func TestLabelsAndAnnotationsRoundTrip(t *testing.T) {
|
|
expectedLabels := map[string]string{"foo.123.abc": "baz", "bar.456.xyz": "qwe"}
|
|
expectedAnnotations := map[string]string{"uio.ert": "dfs", "jkl": "asd"}
|
|
// Merge labels and annotations into docker labels.
|
|
dockerLabels := makeLabels(expectedLabels, expectedAnnotations)
|
|
// Extract labels and annotations from docker labels.
|
|
actualLabels, actualAnnotations := extractLabels(dockerLabels)
|
|
assert.Equal(t, expectedLabels, actualLabels)
|
|
assert.Equal(t, expectedAnnotations, actualAnnotations)
|
|
}
|
|
|
|
// TestGetApparmorSecurityOpts tests the logic of generating container apparmor options from sandbox annotations.
|
|
func TestGetApparmorSecurityOpts(t *testing.T) {
|
|
makeConfig := func(profile string) *runtimeapi.LinuxContainerSecurityContext {
|
|
return &runtimeapi.LinuxContainerSecurityContext{
|
|
ApparmorProfile: profile,
|
|
}
|
|
}
|
|
|
|
tests := []struct {
|
|
msg string
|
|
config *runtimeapi.LinuxContainerSecurityContext
|
|
expectedOpts []string
|
|
}{{
|
|
msg: "No AppArmor options",
|
|
config: makeConfig(""),
|
|
expectedOpts: nil,
|
|
}, {
|
|
msg: "AppArmor runtime/default",
|
|
config: makeConfig("runtime/default"),
|
|
expectedOpts: []string{},
|
|
}, {
|
|
msg: "AppArmor local profile",
|
|
config: makeConfig(v1.AppArmorBetaProfileNamePrefix + "foo"),
|
|
expectedOpts: []string{"apparmor=foo"},
|
|
}}
|
|
|
|
for i, test := range tests {
|
|
opts, err := getApparmorSecurityOpts(test.config, '=')
|
|
assert.NoError(t, err, "TestCase[%d]: %s", i, test.msg)
|
|
assert.Len(t, opts, len(test.expectedOpts), "TestCase[%d]: %s", i, test.msg)
|
|
for _, opt := range test.expectedOpts {
|
|
assert.Contains(t, opts, opt, "TestCase[%d]: %s", i, test.msg)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestGetUserFromImageUser tests the logic of getting image uid or user name of image user.
|
|
func TestGetUserFromImageUser(t *testing.T) {
|
|
newI64 := func(i int64) *int64 { return &i }
|
|
for c, test := range map[string]struct {
|
|
user string
|
|
uid *int64
|
|
name string
|
|
}{
|
|
"no gid": {
|
|
user: "0",
|
|
uid: newI64(0),
|
|
},
|
|
"uid/gid": {
|
|
user: "0:1",
|
|
uid: newI64(0),
|
|
},
|
|
"empty user": {
|
|
user: "",
|
|
},
|
|
"multiple spearators": {
|
|
user: "1:2:3",
|
|
uid: newI64(1),
|
|
},
|
|
"root username": {
|
|
user: "root:root",
|
|
name: "root",
|
|
},
|
|
"username": {
|
|
user: "test:test",
|
|
name: "test",
|
|
},
|
|
} {
|
|
t.Logf("TestCase - %q", c)
|
|
actualUID, actualName := getUserFromImageUser(test.user)
|
|
assert.Equal(t, test.uid, actualUID)
|
|
assert.Equal(t, test.name, actualName)
|
|
}
|
|
}
|
|
|
|
func TestParsingCreationConflictError(t *testing.T) {
|
|
// Expected error message from docker.
|
|
msgs := []string{
|
|
"Conflict. The name \"/k8s_POD_pfpod_e2e-tests-port-forwarding-dlxt2_81a3469e-99e1-11e6-89f2-42010af00002_0\" is already in use by container 24666ab8c814d16f986449e504ea0159468ddf8da01897144a770f66dce0e14e. You have to remove (or rename) that container to be able to reuse that name.",
|
|
"Conflict. The name \"/k8s_POD_pfpod_e2e-tests-port-forwarding-dlxt2_81a3469e-99e1-11e6-89f2-42010af00002_0\" is already in use by container \"24666ab8c814d16f986449e504ea0159468ddf8da01897144a770f66dce0e14e\". You have to remove (or rename) that container to be able to reuse that name.",
|
|
}
|
|
|
|
for _, msg := range msgs {
|
|
matches := conflictRE.FindStringSubmatch(msg)
|
|
require.Len(t, matches, 2)
|
|
require.Equal(t, matches[1], "24666ab8c814d16f986449e504ea0159468ddf8da01897144a770f66dce0e14e")
|
|
}
|
|
}
|
|
|
|
func TestEnsureSandboxImageExists(t *testing.T) {
|
|
sandboxImage := "gcr.io/test/image"
|
|
authConfig := dockertypes.AuthConfig{Username: "user", Password: "pass"}
|
|
for desc, test := range map[string]struct {
|
|
injectImage bool
|
|
imgNeedsAuth bool
|
|
injectErr error
|
|
calls []string
|
|
err bool
|
|
configJSON string
|
|
}{
|
|
"should not pull image when it already exists": {
|
|
injectImage: true,
|
|
injectErr: nil,
|
|
calls: []string{"inspect_image"},
|
|
},
|
|
"should pull image when it doesn't exist": {
|
|
injectImage: false,
|
|
injectErr: libdocker.ImageNotFoundError{ID: "image_id"},
|
|
calls: []string{"inspect_image", "pull"},
|
|
},
|
|
"should return error when inspect image fails": {
|
|
injectImage: false,
|
|
injectErr: fmt.Errorf("arbitrary error"),
|
|
calls: []string{"inspect_image"},
|
|
err: true,
|
|
},
|
|
"should return error when image pull needs private auth, but none provided": {
|
|
injectImage: true,
|
|
imgNeedsAuth: true,
|
|
injectErr: libdocker.ImageNotFoundError{ID: "image_id"},
|
|
calls: []string{"inspect_image", "pull"},
|
|
err: true,
|
|
},
|
|
} {
|
|
t.Logf("TestCase: %q", desc)
|
|
_, fakeDocker, _ := newTestDockerService()
|
|
if test.injectImage {
|
|
images := []dockertypes.ImageSummary{{ID: sandboxImage}}
|
|
fakeDocker.InjectImages(images)
|
|
if test.imgNeedsAuth {
|
|
fakeDocker.MakeImagesPrivate(images, authConfig)
|
|
}
|
|
}
|
|
fakeDocker.InjectError("inspect_image", test.injectErr)
|
|
|
|
err := ensureSandboxImageExists(fakeDocker, sandboxImage)
|
|
assert.NoError(t, fakeDocker.AssertCalls(test.calls))
|
|
assert.Equal(t, test.err, err != nil)
|
|
}
|
|
}
|
|
|
|
func TestMakePortsAndBindings(t *testing.T) {
|
|
for desc, test := range map[string]struct {
|
|
pm []*runtimeapi.PortMapping
|
|
exposedPorts dockernat.PortSet
|
|
portmappings map[dockernat.Port][]dockernat.PortBinding
|
|
}{
|
|
"no port mapping": {
|
|
pm: nil,
|
|
exposedPorts: map[dockernat.Port]struct{}{},
|
|
portmappings: map[dockernat.Port][]dockernat.PortBinding{},
|
|
},
|
|
"tcp port mapping": {
|
|
pm: []*runtimeapi.PortMapping{
|
|
{
|
|
Protocol: runtimeapi.Protocol_TCP,
|
|
ContainerPort: 80,
|
|
HostPort: 80,
|
|
},
|
|
},
|
|
exposedPorts: map[dockernat.Port]struct{}{
|
|
"80/tcp": {},
|
|
},
|
|
portmappings: map[dockernat.Port][]dockernat.PortBinding{
|
|
"80/tcp": {
|
|
{
|
|
HostPort: "80",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
"udp port mapping": {
|
|
pm: []*runtimeapi.PortMapping{
|
|
{
|
|
Protocol: runtimeapi.Protocol_UDP,
|
|
ContainerPort: 80,
|
|
HostPort: 80,
|
|
},
|
|
},
|
|
exposedPorts: map[dockernat.Port]struct{}{
|
|
"80/udp": {},
|
|
},
|
|
portmappings: map[dockernat.Port][]dockernat.PortBinding{
|
|
"80/udp": {
|
|
{
|
|
HostPort: "80",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
"multiple port mappings": {
|
|
pm: []*runtimeapi.PortMapping{
|
|
{
|
|
Protocol: runtimeapi.Protocol_TCP,
|
|
ContainerPort: 80,
|
|
HostPort: 80,
|
|
},
|
|
{
|
|
Protocol: runtimeapi.Protocol_TCP,
|
|
ContainerPort: 80,
|
|
HostPort: 81,
|
|
},
|
|
},
|
|
exposedPorts: map[dockernat.Port]struct{}{
|
|
"80/tcp": {},
|
|
},
|
|
portmappings: map[dockernat.Port][]dockernat.PortBinding{
|
|
"80/tcp": {
|
|
{
|
|
HostPort: "80",
|
|
},
|
|
{
|
|
HostPort: "81",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
} {
|
|
t.Logf("TestCase: %s", desc)
|
|
actualExposedPorts, actualPortMappings := makePortsAndBindings(test.pm)
|
|
assert.Equal(t, test.exposedPorts, actualExposedPorts)
|
|
assert.Equal(t, test.portmappings, actualPortMappings)
|
|
}
|
|
}
|
|
|
|
func TestGenerateMountBindings(t *testing.T) {
|
|
mounts := []*runtimeapi.Mount{
|
|
// everything default
|
|
{
|
|
HostPath: "/mnt/1",
|
|
ContainerPath: "/var/lib/mysql/1",
|
|
},
|
|
// readOnly
|
|
{
|
|
HostPath: "/mnt/2",
|
|
ContainerPath: "/var/lib/mysql/2",
|
|
Readonly: true,
|
|
},
|
|
// SELinux
|
|
{
|
|
HostPath: "/mnt/3",
|
|
ContainerPath: "/var/lib/mysql/3",
|
|
SelinuxRelabel: true,
|
|
},
|
|
// Propagation private
|
|
{
|
|
HostPath: "/mnt/4",
|
|
ContainerPath: "/var/lib/mysql/4",
|
|
Propagation: runtimeapi.MountPropagation_PROPAGATION_PRIVATE,
|
|
},
|
|
// Propagation rslave
|
|
{
|
|
HostPath: "/mnt/5",
|
|
ContainerPath: "/var/lib/mysql/5",
|
|
Propagation: runtimeapi.MountPropagation_PROPAGATION_HOST_TO_CONTAINER,
|
|
},
|
|
// Propagation rshared
|
|
{
|
|
HostPath: "/mnt/6",
|
|
ContainerPath: "/var/lib/mysql/6",
|
|
Propagation: runtimeapi.MountPropagation_PROPAGATION_BIDIRECTIONAL,
|
|
},
|
|
// Propagation unknown (falls back to private)
|
|
{
|
|
HostPath: "/mnt/7",
|
|
ContainerPath: "/var/lib/mysql/7",
|
|
Propagation: runtimeapi.MountPropagation(42),
|
|
},
|
|
// Everything
|
|
{
|
|
HostPath: "/mnt/8",
|
|
ContainerPath: "/var/lib/mysql/8",
|
|
Readonly: true,
|
|
SelinuxRelabel: true,
|
|
Propagation: runtimeapi.MountPropagation_PROPAGATION_BIDIRECTIONAL,
|
|
},
|
|
}
|
|
expectedResult := []string{
|
|
"/mnt/1:/var/lib/mysql/1",
|
|
"/mnt/2:/var/lib/mysql/2:ro",
|
|
"/mnt/3:/var/lib/mysql/3:Z",
|
|
"/mnt/4:/var/lib/mysql/4",
|
|
"/mnt/5:/var/lib/mysql/5:rslave",
|
|
"/mnt/6:/var/lib/mysql/6:rshared",
|
|
"/mnt/7:/var/lib/mysql/7",
|
|
"/mnt/8:/var/lib/mysql/8:ro,Z,rshared",
|
|
}
|
|
result := generateMountBindings(mounts)
|
|
|
|
assert.Equal(t, expectedResult, result)
|
|
}
|
|
|
|
func TestLimitedWriter(t *testing.T) {
|
|
max := func(x, y int64) int64 {
|
|
if x > y {
|
|
return x
|
|
}
|
|
return y
|
|
}
|
|
for name, tc := range map[string]struct {
|
|
w bytes.Buffer
|
|
toWrite string
|
|
limit int64
|
|
wants string
|
|
wantsErr error
|
|
}{
|
|
"nil": {},
|
|
"neg": {
|
|
toWrite: "a",
|
|
wantsErr: errMaximumWrite,
|
|
limit: -1,
|
|
},
|
|
"1byte-over": {
|
|
toWrite: "a",
|
|
wantsErr: errMaximumWrite,
|
|
},
|
|
"1byte-maxed": {
|
|
toWrite: "a",
|
|
wants: "a",
|
|
limit: 1,
|
|
},
|
|
"1byte-under": {
|
|
toWrite: "a",
|
|
wants: "a",
|
|
limit: 2,
|
|
},
|
|
"6byte-over": {
|
|
toWrite: "foobar",
|
|
wants: "foo",
|
|
limit: 3,
|
|
wantsErr: errMaximumWrite,
|
|
},
|
|
"6byte-maxed": {
|
|
toWrite: "foobar",
|
|
wants: "foobar",
|
|
limit: 6,
|
|
},
|
|
"6byte-under": {
|
|
toWrite: "foobar",
|
|
wants: "foobar",
|
|
limit: 20,
|
|
},
|
|
} {
|
|
t.Run(name, func(t *testing.T) {
|
|
limit := tc.limit
|
|
w := sharedLimitWriter(&tc.w, &limit)
|
|
n, err := w.Write([]byte(tc.toWrite))
|
|
if int64(n) > max(0, tc.limit) {
|
|
t.Fatalf("bytes written (%d) exceeds limit (%d)", n, tc.limit)
|
|
}
|
|
if (err != nil) != (tc.wantsErr != nil) {
|
|
if err != nil {
|
|
t.Fatal("unexpected error:", err)
|
|
}
|
|
t.Fatal("expected error:", err)
|
|
}
|
|
if err != nil {
|
|
if !errors.Is(err, tc.wantsErr) {
|
|
t.Fatal("expected error: ", tc.wantsErr, " instead of: ", err)
|
|
}
|
|
if !errors.Is(err, errMaximumWrite) {
|
|
return
|
|
}
|
|
// check contents for errMaximumWrite
|
|
}
|
|
if s := tc.w.String(); s != tc.wants {
|
|
t.Fatalf("expected %q instead of %q", tc.wants, s)
|
|
}
|
|
})
|
|
}
|
|
|
|
// test concurrency. run this test a bunch of times to attempt to flush
|
|
// out any data races or concurrency issues.
|
|
for i := 0; i < 1000; i++ {
|
|
var (
|
|
b1, b2 bytes.Buffer
|
|
limit = int64(10)
|
|
w1 = sharedLimitWriter(&b1, &limit)
|
|
w2 = sharedLimitWriter(&b2, &limit)
|
|
ch = make(chan struct{})
|
|
wg sync.WaitGroup
|
|
)
|
|
wg.Add(2)
|
|
go func() { defer wg.Done(); <-ch; w1.Write([]byte("hello")) }()
|
|
go func() { defer wg.Done(); <-ch; w2.Write([]byte("world")) }()
|
|
close(ch)
|
|
wg.Wait()
|
|
if limit != 0 {
|
|
t.Fatalf("expected max limit to be reached, instead of %d", limit)
|
|
}
|
|
}
|
|
}
|