
Currently kubelet volume management works on the concept of desired and actual world of states. The volume manager periodically compares the two worlds and perform volume mount/unmount and/or attach/detach operations. When kubelet restarts, the cache of those two worlds are gone. Although desired world can be recovered through apiserver, actual world can not be recovered which may cause some volumes cannot be cleaned up if their information is deleted by apiserver. This change adds the reconstruction of the actual world by reading the pod directories from disk. The reconstructed volume information is added to both desired world and actual world if it cannot be found in either world. The rest logic would be as same as before, desired world populator may clean up the volume entry if it is no longer in apiserver, and then volume manager should invoke unmount to clean it up.
181 lines
4.3 KiB
Go
181 lines
4.3 KiB
Go
// +build linux
|
|
|
|
/*
|
|
Copyright 2015 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package cm
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"path"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"k8s.io/kubernetes/pkg/util/mount"
|
|
)
|
|
|
|
type fakeMountInterface struct {
|
|
mountPoints []mount.MountPoint
|
|
}
|
|
|
|
func (mi *fakeMountInterface) Mount(source string, target string, fstype string, options []string) error {
|
|
return fmt.Errorf("unsupported")
|
|
}
|
|
|
|
func (mi *fakeMountInterface) Unmount(target string) error {
|
|
return fmt.Errorf("unsupported")
|
|
}
|
|
|
|
func (mi *fakeMountInterface) List() ([]mount.MountPoint, error) {
|
|
return mi.mountPoints, nil
|
|
}
|
|
|
|
func (mi *fakeMountInterface) IsLikelyNotMountPoint(file string) (bool, error) {
|
|
return false, fmt.Errorf("unsupported")
|
|
}
|
|
func (mi *fakeMountInterface) GetDeviceNameFromMount(mountPath, pluginDir string) (string, error) {
|
|
return "", nil
|
|
}
|
|
|
|
func (mi *fakeMountInterface) DeviceOpened(pathname string) (bool, error) {
|
|
for _, mp := range mi.mountPoints {
|
|
if mp.Device == pathname {
|
|
return true, nil
|
|
}
|
|
}
|
|
return false, nil
|
|
}
|
|
|
|
func (mi *fakeMountInterface) PathIsDevice(pathname string) (bool, error) {
|
|
return true, nil
|
|
}
|
|
|
|
func fakeContainerMgrMountInt() mount.Interface {
|
|
return &fakeMountInterface{
|
|
[]mount.MountPoint{
|
|
{
|
|
Device: "cgroup",
|
|
Type: "cgroup",
|
|
Opts: []string{"rw", "relatime", "cpuset"},
|
|
},
|
|
{
|
|
Device: "cgroup",
|
|
Type: "cgroup",
|
|
Opts: []string{"rw", "relatime", "cpu"},
|
|
},
|
|
{
|
|
Device: "cgroup",
|
|
Type: "cgroup",
|
|
Opts: []string{"rw", "relatime", "cpuacct"},
|
|
},
|
|
{
|
|
Device: "cgroup",
|
|
Type: "cgroup",
|
|
Opts: []string{"rw", "relatime", "memory"},
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func TestCgroupMountValidationSuccess(t *testing.T) {
|
|
f, err := validateSystemRequirements(fakeContainerMgrMountInt())
|
|
assert.Nil(t, err)
|
|
assert.False(t, f.cpuHardcapping, "cpu hardcapping is expected to be disabled")
|
|
}
|
|
|
|
func TestCgroupMountValidationMemoryMissing(t *testing.T) {
|
|
mountInt := &fakeMountInterface{
|
|
[]mount.MountPoint{
|
|
{
|
|
Device: "cgroup",
|
|
Type: "cgroup",
|
|
Opts: []string{"rw", "relatime", "cpuset"},
|
|
},
|
|
{
|
|
Device: "cgroup",
|
|
Type: "cgroup",
|
|
Opts: []string{"rw", "relatime", "cpu"},
|
|
},
|
|
{
|
|
Device: "cgroup",
|
|
Type: "cgroup",
|
|
Opts: []string{"rw", "relatime", "cpuacct"},
|
|
},
|
|
},
|
|
}
|
|
_, err := validateSystemRequirements(mountInt)
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestCgroupMountValidationMultipleSubsytem(t *testing.T) {
|
|
mountInt := &fakeMountInterface{
|
|
[]mount.MountPoint{
|
|
{
|
|
Device: "cgroup",
|
|
Type: "cgroup",
|
|
Opts: []string{"rw", "relatime", "cpuset", "memory"},
|
|
},
|
|
{
|
|
Device: "cgroup",
|
|
Type: "cgroup",
|
|
Opts: []string{"rw", "relatime", "cpu"},
|
|
},
|
|
{
|
|
Device: "cgroup",
|
|
Type: "cgroup",
|
|
Opts: []string{"rw", "relatime", "cpuacct"},
|
|
},
|
|
},
|
|
}
|
|
_, err := validateSystemRequirements(mountInt)
|
|
assert.Nil(t, err)
|
|
}
|
|
|
|
func TestSoftRequirementsValidationSuccess(t *testing.T) {
|
|
req := require.New(t)
|
|
tempDir, err := ioutil.TempDir("", "")
|
|
req.NoError(err)
|
|
req.NoError(ioutil.WriteFile(path.Join(tempDir, "cpu.cfs_period_us"), []byte("0"), os.ModePerm))
|
|
req.NoError(ioutil.WriteFile(path.Join(tempDir, "cpu.cfs_quota_us"), []byte("0"), os.ModePerm))
|
|
mountInt := &fakeMountInterface{
|
|
[]mount.MountPoint{
|
|
{
|
|
Device: "cgroup",
|
|
Type: "cgroup",
|
|
Opts: []string{"rw", "relatime", "cpuset"},
|
|
},
|
|
{
|
|
Device: "cgroup",
|
|
Type: "cgroup",
|
|
Opts: []string{"rw", "relatime", "cpu"},
|
|
Path: tempDir,
|
|
},
|
|
{
|
|
Device: "cgroup",
|
|
Type: "cgroup",
|
|
Opts: []string{"rw", "relatime", "cpuacct", "memory"},
|
|
},
|
|
},
|
|
}
|
|
f, err := validateSystemRequirements(mountInt)
|
|
assert.NoError(t, err)
|
|
assert.True(t, f.cpuHardcapping, "cpu hardcapping is expected to be enabled")
|
|
}
|