7afaf23b01
The `make` rules which auto-generate some of our API stuff are incredibly baroque, and hard to maintain. They were originally added on the assumption that we would stop checking generated files into git. Since then we have moved away from that goal, and the worst problems with generated files have been resolved. Reasons to kill this: * It is slow on every build, as opposed to just being slow when running the generators. It is even slow to calculate that there's nothing to update. * Most development work doesn't involve changing APIs. * It only covers about half (or less) of the generated code, and making it cover more would be even slower. * Approximately 1 person knows how this all works. * We have CI to make sure changes do not get merged without updating this code. * We have corner cases where this does the WRONG thing and tracking those down is ugly and hard in perpetuity. So this commit puts all the same logic that WAS in the Makefile.generated_files into update-codegen.sh. I do not love this script, especially WRT sub-packages, but I am trying not to boil the ocean. I hope to follow up with some more cleanups over time. I have tested this manually and with the scripts and it still seems to catch errors properly. This includes a change to kube::util::read-array to make it not unset variables and not over-write non-array variables.
47 lines
1.8 KiB
Bash
Executable File
47 lines
1.8 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# Copyright 2014 The Kubernetes Authors.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
# This script verifies whether code update is needed or not against the
|
|
# specific sub-projects. The sub-projects are listed below this script(the
|
|
# line that starts with `CODEGEN_PKG`).
|
|
# Usage: `hack/verify-codegen.sh`.
|
|
|
|
set -o errexit
|
|
set -o nounset
|
|
set -o pipefail
|
|
|
|
KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
|
|
source "${KUBE_ROOT}/hack/lib/init.sh"
|
|
|
|
kube::golang::setup_env
|
|
|
|
# call verify on sub-project for now
|
|
#
|
|
# Note: these must be before the main script call because the later calls the sub-project's
|
|
# update-codegen.sh scripts. We wouldn't see any error on changes then.
|
|
export CODEGEN_PKG=./vendor/k8s.io/code-generator
|
|
vendor/k8s.io/code-generator/hack/verify-codegen.sh
|
|
vendor/k8s.io/kube-aggregator/hack/verify-codegen.sh
|
|
vendor/k8s.io/sample-apiserver/hack/verify-codegen.sh
|
|
vendor/k8s.io/sample-controller/hack/verify-codegen.sh
|
|
vendor/k8s.io/apiextensions-apiserver/hack/verify-codegen.sh
|
|
vendor/k8s.io/metrics/hack/verify-codegen.sh
|
|
|
|
# This won't actually update anything because of --verify-only, but it tells
|
|
# the openapi tool to verify against the real filenames.
|
|
export UPDATE_API_KNOWN_VIOLATIONS=true
|
|
"${KUBE_ROOT}/hack/update-codegen.sh" --verify-only "$@"
|