ebc8dc85aa
Automatic merge from submit-queue SetSelfLink is inefficient Generating self links, especially for lists, is inefficient. Replace use of net.URL.String() call with direct encoding that reduces number of allocations. Switch from calling meta.ExtractList|SetList to a function that iterates over each object in the list. In steady state for nodes performing frequently small get/list operations, and for larger LISTs significantly reduces CPU and allocations. @wojtek-t this is the next big chunk of CPU use during the large N nodes simulation test (11% of master CPU). Takes a few allocations out of the critical path
345 lines
8.2 KiB
Go
345 lines
8.2 KiB
Go
/*
|
|
Copyright 2014 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package meta_test
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"k8s.io/kubernetes/pkg/api"
|
|
"k8s.io/kubernetes/pkg/api/meta"
|
|
"k8s.io/kubernetes/pkg/api/unversioned"
|
|
"k8s.io/kubernetes/pkg/api/v1"
|
|
"k8s.io/kubernetes/pkg/runtime"
|
|
"k8s.io/kubernetes/pkg/util/diff"
|
|
|
|
"github.com/google/gofuzz"
|
|
)
|
|
|
|
func TestIsList(t *testing.T) {
|
|
tests := []struct {
|
|
obj runtime.Object
|
|
isList bool
|
|
}{
|
|
{&api.PodList{}, true},
|
|
{&api.Pod{}, false},
|
|
}
|
|
for _, item := range tests {
|
|
if e, a := item.isList, meta.IsListType(item.obj); e != a {
|
|
t.Errorf("%v: Expected %v, got %v", reflect.TypeOf(item.obj), e, a)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestExtractList(t *testing.T) {
|
|
list1 := []runtime.Object{
|
|
&api.Pod{ObjectMeta: api.ObjectMeta{Name: "1"}},
|
|
&api.Service{ObjectMeta: api.ObjectMeta{Name: "2"}},
|
|
}
|
|
list2 := &v1.List{
|
|
Items: []runtime.RawExtension{
|
|
{Raw: []byte("foo")},
|
|
{Raw: []byte("bar")},
|
|
{Object: &v1.Pod{ObjectMeta: v1.ObjectMeta{Name: "other"}}},
|
|
},
|
|
}
|
|
list3 := &fakePtrValueList{
|
|
Items: []*api.Pod{
|
|
{ObjectMeta: api.ObjectMeta{Name: "1"}},
|
|
{ObjectMeta: api.ObjectMeta{Name: "2"}},
|
|
},
|
|
}
|
|
list4 := &api.PodList{
|
|
Items: []api.Pod{
|
|
{ObjectMeta: api.ObjectMeta{Name: "1"}},
|
|
{ObjectMeta: api.ObjectMeta{Name: "2"}},
|
|
{ObjectMeta: api.ObjectMeta{Name: "3"}},
|
|
},
|
|
}
|
|
list5 := &v1.PodList{
|
|
Items: []v1.Pod{
|
|
{ObjectMeta: v1.ObjectMeta{Name: "1"}},
|
|
{ObjectMeta: v1.ObjectMeta{Name: "2"}},
|
|
{ObjectMeta: v1.ObjectMeta{Name: "3"}},
|
|
},
|
|
}
|
|
|
|
testCases := []struct {
|
|
in runtime.Object
|
|
out []interface{}
|
|
equal bool
|
|
}{
|
|
{
|
|
in: &api.List{},
|
|
out: []interface{}{},
|
|
},
|
|
{
|
|
in: &v1.List{},
|
|
out: []interface{}{},
|
|
},
|
|
{
|
|
in: &v1.PodList{},
|
|
out: []interface{}{},
|
|
},
|
|
{
|
|
in: &api.List{Items: list1},
|
|
out: []interface{}{list1[0], list1[1]},
|
|
},
|
|
{
|
|
in: list2,
|
|
out: []interface{}{&runtime.Unknown{Raw: list2.Items[0].Raw}, &runtime.Unknown{Raw: list2.Items[1].Raw}, list2.Items[2].Object},
|
|
equal: true,
|
|
},
|
|
{
|
|
in: list3,
|
|
out: []interface{}{list3.Items[0], list3.Items[1]},
|
|
},
|
|
{
|
|
in: list4,
|
|
out: []interface{}{&list4.Items[0], &list4.Items[1], &list4.Items[2]},
|
|
},
|
|
{
|
|
in: list5,
|
|
out: []interface{}{&list5.Items[0], &list5.Items[1], &list5.Items[2]},
|
|
},
|
|
}
|
|
for i, test := range testCases {
|
|
list, err := meta.ExtractList(test.in)
|
|
if err != nil {
|
|
t.Fatalf("%d: extract: Unexpected error %v", i, err)
|
|
}
|
|
if e, a := len(test.out), len(list); e != a {
|
|
t.Fatalf("%d: extract: Expected %v, got %v", i, e, a)
|
|
}
|
|
for j, e := range test.out {
|
|
if e != list[j] {
|
|
if !test.equal {
|
|
t.Fatalf("%d: extract: Expected list[%d] to be %#v, but found %#v", i, j, e, list[j])
|
|
}
|
|
if !reflect.DeepEqual(e, list[j]) {
|
|
t.Fatalf("%d: extract: Expected list[%d] to be %#v, but found %#v", i, j, e, list[j])
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestEachListItem(t *testing.T) {
|
|
list1 := []runtime.Object{
|
|
&api.Pod{ObjectMeta: api.ObjectMeta{Name: "1"}},
|
|
&api.Service{ObjectMeta: api.ObjectMeta{Name: "2"}},
|
|
}
|
|
list2 := &v1.List{
|
|
Items: []runtime.RawExtension{
|
|
{Raw: []byte("foo")},
|
|
{Raw: []byte("bar")},
|
|
{Object: &v1.Pod{ObjectMeta: v1.ObjectMeta{Name: "other"}}},
|
|
},
|
|
}
|
|
list3 := &fakePtrValueList{
|
|
Items: []*api.Pod{
|
|
{ObjectMeta: api.ObjectMeta{Name: "1"}},
|
|
{ObjectMeta: api.ObjectMeta{Name: "2"}},
|
|
},
|
|
}
|
|
list4 := &api.PodList{
|
|
Items: []api.Pod{
|
|
{ObjectMeta: api.ObjectMeta{Name: "1"}},
|
|
{ObjectMeta: api.ObjectMeta{Name: "2"}},
|
|
{ObjectMeta: api.ObjectMeta{Name: "3"}},
|
|
},
|
|
}
|
|
list5 := &v1.PodList{
|
|
Items: []v1.Pod{
|
|
{ObjectMeta: v1.ObjectMeta{Name: "1"}},
|
|
{ObjectMeta: v1.ObjectMeta{Name: "2"}},
|
|
{ObjectMeta: v1.ObjectMeta{Name: "3"}},
|
|
},
|
|
}
|
|
|
|
testCases := []struct {
|
|
in runtime.Object
|
|
out []interface{}
|
|
}{
|
|
{
|
|
in: &api.List{},
|
|
out: []interface{}{},
|
|
},
|
|
{
|
|
in: &v1.List{},
|
|
out: []interface{}{},
|
|
},
|
|
{
|
|
in: &v1.PodList{},
|
|
out: []interface{}{},
|
|
},
|
|
{
|
|
in: &api.List{Items: list1},
|
|
out: []interface{}{list1[0], list1[1]},
|
|
},
|
|
{
|
|
in: list2,
|
|
out: []interface{}{nil, nil, list2.Items[2].Object},
|
|
},
|
|
{
|
|
in: list3,
|
|
out: []interface{}{list3.Items[0], list3.Items[1]},
|
|
},
|
|
{
|
|
in: list4,
|
|
out: []interface{}{&list4.Items[0], &list4.Items[1], &list4.Items[2]},
|
|
},
|
|
{
|
|
in: list5,
|
|
out: []interface{}{&list5.Items[0], &list5.Items[1], &list5.Items[2]},
|
|
},
|
|
}
|
|
for i, test := range testCases {
|
|
list := []runtime.Object{}
|
|
err := meta.EachListItem(test.in, func(obj runtime.Object) error {
|
|
list = append(list, obj)
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("%d: each: Unexpected error %v", i, err)
|
|
}
|
|
if e, a := len(test.out), len(list); e != a {
|
|
t.Fatalf("%d: each: Expected %v, got %v", i, e, a)
|
|
}
|
|
for j, e := range test.out {
|
|
if e != list[j] {
|
|
t.Fatalf("%d: each: Expected list[%d] to be %#v, but found %#v", i, j, e, list[j])
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
type fakePtrInterfaceList struct {
|
|
Items *[]runtime.Object
|
|
}
|
|
|
|
func (obj fakePtrInterfaceList) GetObjectKind() unversioned.ObjectKind {
|
|
return unversioned.EmptyObjectKind
|
|
}
|
|
|
|
func TestExtractListOfInterfacePtrs(t *testing.T) {
|
|
pl := &fakePtrInterfaceList{
|
|
Items: &[]runtime.Object{},
|
|
}
|
|
list, err := meta.ExtractList(pl)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error %v", err)
|
|
}
|
|
if len(list) > 0 {
|
|
t.Fatalf("Expected empty list, got %#v", list)
|
|
}
|
|
}
|
|
|
|
type fakePtrValueList struct {
|
|
Items []*api.Pod
|
|
}
|
|
|
|
func (obj fakePtrValueList) GetObjectKind() unversioned.ObjectKind {
|
|
return unversioned.EmptyObjectKind
|
|
}
|
|
|
|
func TestSetList(t *testing.T) {
|
|
pl := &api.PodList{}
|
|
list := []runtime.Object{
|
|
&api.Pod{ObjectMeta: api.ObjectMeta{Name: "1"}},
|
|
&api.Pod{ObjectMeta: api.ObjectMeta{Name: "2"}},
|
|
&api.Pod{ObjectMeta: api.ObjectMeta{Name: "3"}},
|
|
}
|
|
err := meta.SetList(pl, list)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error %v", err)
|
|
}
|
|
if e, a := len(list), len(pl.Items); e != a {
|
|
t.Fatalf("Expected %v, got %v", e, a)
|
|
}
|
|
for i := range list {
|
|
if e, a := list[i].(*api.Pod).Name, pl.Items[i].Name; e != a {
|
|
t.Fatalf("Expected %v, got %v", e, a)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSetListToRuntimeObjectArray(t *testing.T) {
|
|
pl := &api.List{}
|
|
list := []runtime.Object{
|
|
&api.Pod{ObjectMeta: api.ObjectMeta{Name: "1"}},
|
|
&api.Pod{ObjectMeta: api.ObjectMeta{Name: "2"}},
|
|
&api.Pod{ObjectMeta: api.ObjectMeta{Name: "3"}},
|
|
}
|
|
err := meta.SetList(pl, list)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error %v", err)
|
|
}
|
|
if e, a := len(list), len(pl.Items); e != a {
|
|
t.Fatalf("Expected %v, got %v", e, a)
|
|
}
|
|
for i := range list {
|
|
if e, a := list[i], pl.Items[i]; e != a {
|
|
t.Fatalf("%d: unmatched: %s", i, diff.ObjectDiff(e, a))
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSetListToMatchingType(t *testing.T) {
|
|
pl := &runtime.UnstructuredList{}
|
|
list := []runtime.Object{
|
|
&runtime.Unstructured{Object: map[string]interface{}{"foo": 1}},
|
|
&runtime.Unstructured{Object: map[string]interface{}{"foo": 2}},
|
|
&runtime.Unstructured{Object: map[string]interface{}{"foo": 3}},
|
|
}
|
|
err := meta.SetList(pl, list)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error %v", err)
|
|
}
|
|
if e, a := len(list), len(pl.Items); e != a {
|
|
t.Fatalf("Expected %v, got %v", e, a)
|
|
}
|
|
for i := range list {
|
|
if e, a := list[i], pl.Items[i]; e != a {
|
|
t.Fatalf("%d: unmatched: %s", i, diff.ObjectDiff(e, a))
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSetExtractListRoundTrip(t *testing.T) {
|
|
fuzzer := fuzz.New().NilChance(0).NumElements(1, 5)
|
|
for i := 0; i < 5; i++ {
|
|
start := &api.PodList{}
|
|
fuzzer.Fuzz(&start.Items)
|
|
|
|
list, err := meta.ExtractList(start)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error %v", err)
|
|
continue
|
|
}
|
|
got := &api.PodList{}
|
|
err = meta.SetList(got, list)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error %v", err)
|
|
continue
|
|
}
|
|
if e, a := start, got; !reflect.DeepEqual(e, a) {
|
|
t.Fatalf("Expected %#v, got %#v", e, a)
|
|
}
|
|
}
|
|
}
|