f363a03f0b
- Rename MapDevice to MapPodDevice in BlockVolumeMapper - Add UnmapPodDevice in BlockVolumeUnmapper (This will be used by csi driver later) - Add CustomBlockVolumeMapper and CustomBlockVolumeUnmapper interface - Move SetUpDevice and MapPodDevice to CustomBlockVolumeMapper - Move TearDownDevice and UnmapPodDevice to CustomBlockVolumeUnmapper - Implement CustomBlockVolumeMapper only in local and csi plugin - Implement CustomBlockVolumeUnmapper only in fc, iscsi, rbd, and csi plugin - Change MapPodDevice to return path and SetUpDevice not to return path
434 lines
13 KiB
Go
434 lines
13 KiB
Go
/*
|
|
Copyright 2018 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package csi
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
api "k8s.io/api/core/v1"
|
|
"k8s.io/api/storage/v1beta1"
|
|
meta "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
utilfeature "k8s.io/apiserver/pkg/util/feature"
|
|
fakeclient "k8s.io/client-go/kubernetes/fake"
|
|
featuregatetesting "k8s.io/component-base/featuregate/testing"
|
|
"k8s.io/kubernetes/pkg/features"
|
|
"k8s.io/kubernetes/pkg/volume"
|
|
volumetest "k8s.io/kubernetes/pkg/volume/testing"
|
|
)
|
|
|
|
func prepareBlockMapperTest(plug *csiPlugin, specVolumeName string, t *testing.T) (*csiBlockMapper, *volume.Spec, *api.PersistentVolume, error) {
|
|
registerFakePlugin(testDriver, "endpoint", []string{"1.0.0"}, t)
|
|
pv := makeTestPV(specVolumeName, 10, testDriver, testVol)
|
|
spec := volume.NewSpecFromPersistentVolume(pv, pv.Spec.PersistentVolumeSource.CSI.ReadOnly)
|
|
mapper, err := plug.NewBlockVolumeMapper(
|
|
spec,
|
|
&api.Pod{ObjectMeta: meta.ObjectMeta{UID: testPodUID, Namespace: testns}},
|
|
volume.VolumeOptions{},
|
|
)
|
|
if err != nil {
|
|
return nil, nil, nil, fmt.Errorf("Failed to make a new Mapper: %v", err)
|
|
}
|
|
csiMapper := mapper.(*csiBlockMapper)
|
|
return csiMapper, spec, pv, nil
|
|
}
|
|
|
|
func TestBlockMapperGetGlobalMapPath(t *testing.T) {
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIBlockVolume, true)()
|
|
|
|
plug, tmpDir := newTestPlugin(t, nil)
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
// TODO (vladimirvivien) specName with slashes will not work
|
|
testCases := []struct {
|
|
name string
|
|
specVolumeName string
|
|
path string
|
|
}{
|
|
{
|
|
name: "simple specName",
|
|
specVolumeName: "spec-0",
|
|
path: filepath.Join(tmpDir, fmt.Sprintf("plugins/kubernetes.io/csi/volumeDevices/%s/%s", "spec-0", "dev")),
|
|
},
|
|
{
|
|
name: "specName with dots",
|
|
specVolumeName: "test.spec.1",
|
|
path: filepath.Join(tmpDir, fmt.Sprintf("plugins/kubernetes.io/csi/volumeDevices/%s/%s", "test.spec.1", "dev")),
|
|
},
|
|
}
|
|
for _, tc := range testCases {
|
|
t.Logf("test case: %s", tc.name)
|
|
csiMapper, spec, _, err := prepareBlockMapperTest(plug, tc.specVolumeName, t)
|
|
if err != nil {
|
|
t.Fatalf("Failed to make a new Mapper: %v", err)
|
|
}
|
|
|
|
path, err := csiMapper.GetGlobalMapPath(spec)
|
|
if err != nil {
|
|
t.Errorf("mapper GetGlobalMapPath failed: %v", err)
|
|
}
|
|
|
|
if tc.path != path {
|
|
t.Errorf("expecting path %s, got %s", tc.path, path)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBlockMapperGetStagingPath(t *testing.T) {
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIBlockVolume, true)()
|
|
|
|
plug, tmpDir := newTestPlugin(t, nil)
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
testCases := []struct {
|
|
name string
|
|
specVolumeName string
|
|
path string
|
|
}{
|
|
{
|
|
name: "simple specName",
|
|
specVolumeName: "spec-0",
|
|
path: filepath.Join(tmpDir, fmt.Sprintf("plugins/kubernetes.io/csi/volumeDevices/staging/%s", "spec-0")),
|
|
},
|
|
{
|
|
name: "specName with dots",
|
|
specVolumeName: "test.spec.1",
|
|
path: filepath.Join(tmpDir, fmt.Sprintf("plugins/kubernetes.io/csi/volumeDevices/staging/%s", "test.spec.1")),
|
|
},
|
|
}
|
|
for _, tc := range testCases {
|
|
t.Logf("test case: %s", tc.name)
|
|
csiMapper, _, _, err := prepareBlockMapperTest(plug, tc.specVolumeName, t)
|
|
if err != nil {
|
|
t.Fatalf("Failed to make a new Mapper: %v", err)
|
|
}
|
|
|
|
path := csiMapper.getStagingPath()
|
|
|
|
if tc.path != path {
|
|
t.Errorf("expecting path %s, got %s", tc.path, path)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBlockMapperGetPublishPath(t *testing.T) {
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIBlockVolume, true)()
|
|
|
|
plug, tmpDir := newTestPlugin(t, nil)
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
testCases := []struct {
|
|
name string
|
|
specVolumeName string
|
|
path string
|
|
}{
|
|
{
|
|
name: "simple specName",
|
|
specVolumeName: "spec-0",
|
|
path: filepath.Join(tmpDir, fmt.Sprintf("plugins/kubernetes.io/csi/volumeDevices/publish/%s", "spec-0")),
|
|
},
|
|
{
|
|
name: "specName with dots",
|
|
specVolumeName: "test.spec.1",
|
|
path: filepath.Join(tmpDir, fmt.Sprintf("plugins/kubernetes.io/csi/volumeDevices/publish/%s", "test.spec.1")),
|
|
},
|
|
}
|
|
for _, tc := range testCases {
|
|
t.Logf("test case: %s", tc.name)
|
|
csiMapper, _, _, err := prepareBlockMapperTest(plug, tc.specVolumeName, t)
|
|
if err != nil {
|
|
t.Fatalf("Failed to make a new Mapper: %v", err)
|
|
}
|
|
|
|
path := csiMapper.getPublishPath()
|
|
|
|
if tc.path != path {
|
|
t.Errorf("expecting path %s, got %s", tc.path, path)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBlockMapperGetDeviceMapPath(t *testing.T) {
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIBlockVolume, true)()
|
|
|
|
plug, tmpDir := newTestPlugin(t, nil)
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
testCases := []struct {
|
|
name string
|
|
specVolumeName string
|
|
path string
|
|
}{
|
|
{
|
|
name: "simple specName",
|
|
specVolumeName: "spec-0",
|
|
path: filepath.Join(tmpDir, fmt.Sprintf("pods/%s/volumeDevices/kubernetes.io~csi", testPodUID)),
|
|
},
|
|
{
|
|
name: "specName with dots",
|
|
specVolumeName: "test.spec.1",
|
|
path: filepath.Join(tmpDir, fmt.Sprintf("pods/%s/volumeDevices/kubernetes.io~csi", testPodUID)),
|
|
},
|
|
}
|
|
for _, tc := range testCases {
|
|
t.Logf("test case: %s", tc.name)
|
|
csiMapper, _, _, err := prepareBlockMapperTest(plug, tc.specVolumeName, t)
|
|
if err != nil {
|
|
t.Fatalf("Failed to make a new Mapper: %v", err)
|
|
}
|
|
|
|
path, volName := csiMapper.GetPodDeviceMapPath()
|
|
|
|
if tc.path != path {
|
|
t.Errorf("expecting path %s, got %s", tc.path, path)
|
|
}
|
|
|
|
if tc.specVolumeName != volName {
|
|
t.Errorf("expecting volName %s, got %s", tc.specVolumeName, volName)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBlockMapperSetupDevice(t *testing.T) {
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIBlockVolume, true)()
|
|
|
|
plug, tmpDir := newTestPlugin(t, nil)
|
|
defer os.RemoveAll(tmpDir)
|
|
fakeClient := fakeclient.NewSimpleClientset()
|
|
host := volumetest.NewFakeVolumeHostWithCSINodeName(
|
|
tmpDir,
|
|
fakeClient,
|
|
nil,
|
|
"fakeNode",
|
|
nil,
|
|
)
|
|
plug.host = host
|
|
|
|
csiMapper, _, pv, err := prepareBlockMapperTest(plug, "test-pv", t)
|
|
if err != nil {
|
|
t.Fatalf("Failed to make a new Mapper: %v", err)
|
|
}
|
|
|
|
pvName := pv.GetName()
|
|
nodeName := string(plug.host.GetNodeName())
|
|
|
|
csiMapper.csiClient = setupClient(t, true)
|
|
|
|
attachID := getAttachmentName(csiMapper.volumeID, string(csiMapper.driverName), string(nodeName))
|
|
attachment := makeTestAttachment(attachID, nodeName, pvName)
|
|
attachment.Status.Attached = true
|
|
_, err = csiMapper.k8s.StorageV1().VolumeAttachments().Create(attachment)
|
|
if err != nil {
|
|
t.Fatalf("failed to setup VolumeAttachment: %v", err)
|
|
}
|
|
t.Log("created attachement ", attachID)
|
|
|
|
err = csiMapper.SetUpDevice()
|
|
if err != nil {
|
|
t.Fatalf("mapper failed to SetupDevice: %v", err)
|
|
}
|
|
|
|
// Check if NodeStageVolume staged to the right path
|
|
stagingPath := csiMapper.getStagingPath()
|
|
svols := csiMapper.csiClient.(*fakeCsiDriverClient).nodeClient.GetNodeStagedVolumes()
|
|
svol, ok := svols[csiMapper.volumeID]
|
|
if !ok {
|
|
t.Error("csi server may not have received NodeStageVolume call")
|
|
}
|
|
if svol.Path != stagingPath {
|
|
t.Errorf("csi server expected device path %s, got %s", stagingPath, svol.Path)
|
|
}
|
|
|
|
// Check if NodePublishVolume published to the right path
|
|
pvols := csiMapper.csiClient.(*fakeCsiDriverClient).nodeClient.GetNodePublishedVolumes()
|
|
pvol, ok := pvols[csiMapper.volumeID]
|
|
if !ok {
|
|
t.Error("csi server may not have received NodePublishVolume call")
|
|
}
|
|
|
|
publishPath := csiMapper.getPublishPath()
|
|
if pvol.Path != publishPath {
|
|
t.Errorf("csi server expected path %s, got %s", publishPath, pvol.Path)
|
|
}
|
|
}
|
|
|
|
func TestBlockMapperMapPodDevice(t *testing.T) {
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIBlockVolume, true)()
|
|
|
|
plug, tmpDir := newTestPlugin(t, nil)
|
|
defer os.RemoveAll(tmpDir)
|
|
fakeClient := fakeclient.NewSimpleClientset()
|
|
host := volumetest.NewFakeVolumeHostWithCSINodeName(
|
|
tmpDir,
|
|
fakeClient,
|
|
nil,
|
|
"fakeNode",
|
|
nil,
|
|
)
|
|
plug.host = host
|
|
|
|
csiMapper, _, pv, err := prepareBlockMapperTest(plug, "test-pv", t)
|
|
if err != nil {
|
|
t.Fatalf("Failed to make a new Mapper: %v", err)
|
|
}
|
|
|
|
pvName := pv.GetName()
|
|
nodeName := string(plug.host.GetNodeName())
|
|
|
|
csiMapper.csiClient = setupClient(t, true)
|
|
|
|
attachID := getAttachmentName(csiMapper.volumeID, string(csiMapper.driverName), string(nodeName))
|
|
attachment := makeTestAttachment(attachID, nodeName, pvName)
|
|
attachment.Status.Attached = true
|
|
_, err = csiMapper.k8s.StorageV1().VolumeAttachments().Create(attachment)
|
|
if err != nil {
|
|
t.Fatalf("failed to setup VolumeAttachment: %v", err)
|
|
}
|
|
t.Log("created attachement ", attachID)
|
|
|
|
// Map device to global and pod device map path
|
|
path, err := csiMapper.MapPodDevice()
|
|
if err != nil {
|
|
t.Fatalf("mapper failed to GetGlobalMapPath: %v", err)
|
|
}
|
|
publishPath := csiMapper.getPublishPath()
|
|
if path != publishPath {
|
|
t.Errorf("path %s and %s doesn't match", path, publishPath)
|
|
}
|
|
}
|
|
|
|
func TestBlockMapperMapPodDeviceNotSupportAttach(t *testing.T) {
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIBlockVolume, true)()
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIDriverRegistry, true)()
|
|
|
|
fakeClient := fakeclient.NewSimpleClientset()
|
|
attachRequired := false
|
|
fakeDriver := &v1beta1.CSIDriver{
|
|
ObjectMeta: meta.ObjectMeta{
|
|
Name: testDriver,
|
|
},
|
|
Spec: v1beta1.CSIDriverSpec{
|
|
AttachRequired: &attachRequired,
|
|
},
|
|
}
|
|
_, err := fakeClient.StorageV1beta1().CSIDrivers().Create(fakeDriver)
|
|
if err != nil {
|
|
t.Fatalf("Failed to create a fakeDriver: %v", err)
|
|
}
|
|
|
|
// after the driver is created, create the plugin. newTestPlugin waits for the informer to sync,
|
|
// such that csiMapper.SetUpDevice below sees the VolumeAttachment object in the lister.
|
|
|
|
plug, tmpDir := newTestPlugin(t, fakeClient)
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
host := volumetest.NewFakeVolumeHostWithCSINodeName(
|
|
tmpDir,
|
|
fakeClient,
|
|
nil,
|
|
"fakeNode",
|
|
plug.csiDriverLister,
|
|
)
|
|
plug.host = host
|
|
csiMapper, _, _, err := prepareBlockMapperTest(plug, "test-pv", t)
|
|
if err != nil {
|
|
t.Fatalf("Failed to make a new Mapper: %v", err)
|
|
}
|
|
csiMapper.csiClient = setupClient(t, true)
|
|
|
|
// Map device to global and pod device map path
|
|
path, err := csiMapper.MapPodDevice()
|
|
if err != nil {
|
|
t.Fatalf("mapper failed to GetGlobalMapPath: %v", err)
|
|
}
|
|
publishPath := csiMapper.getPublishPath()
|
|
if path != publishPath {
|
|
t.Errorf("path %s and %s doesn't match", path, publishPath)
|
|
}
|
|
}
|
|
|
|
func TestBlockMapperTearDownDevice(t *testing.T) {
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIBlockVolume, true)()
|
|
|
|
plug, tmpDir := newTestPlugin(t, nil)
|
|
defer os.RemoveAll(tmpDir)
|
|
fakeClient := fakeclient.NewSimpleClientset()
|
|
host := volumetest.NewFakeVolumeHostWithCSINodeName(
|
|
tmpDir,
|
|
fakeClient,
|
|
nil,
|
|
"fakeNode",
|
|
nil,
|
|
)
|
|
plug.host = host
|
|
|
|
_, spec, pv, err := prepareBlockMapperTest(plug, "test-pv", t)
|
|
if err != nil {
|
|
t.Fatalf("Failed to make a new Mapper: %v", err)
|
|
}
|
|
|
|
// save volume data
|
|
dir := getVolumeDeviceDataDir(pv.ObjectMeta.Name, plug.host)
|
|
if err := os.MkdirAll(dir, 0755); err != nil && !os.IsNotExist(err) {
|
|
t.Errorf("failed to create dir [%s]: %v", dir, err)
|
|
}
|
|
|
|
if err := saveVolumeData(
|
|
dir,
|
|
volDataFileName,
|
|
map[string]string{
|
|
volDataKey.specVolID: pv.ObjectMeta.Name,
|
|
volDataKey.driverName: testDriver,
|
|
volDataKey.volHandle: testVol,
|
|
},
|
|
); err != nil {
|
|
t.Fatalf("failed to save volume data: %v", err)
|
|
}
|
|
|
|
unmapper, err := plug.NewBlockVolumeUnmapper(pv.ObjectMeta.Name, testPodUID)
|
|
if err != nil {
|
|
t.Fatalf("failed to make a new Unmapper: %v", err)
|
|
}
|
|
|
|
csiUnmapper := unmapper.(*csiBlockMapper)
|
|
csiUnmapper.csiClient = setupClient(t, true)
|
|
|
|
globalMapPath, err := csiUnmapper.GetGlobalMapPath(spec)
|
|
if err != nil {
|
|
t.Fatalf("unmapper failed to GetGlobalMapPath: %v", err)
|
|
}
|
|
|
|
err = csiUnmapper.TearDownDevice(globalMapPath, "/dev/test")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// ensure csi client call and node unpblished
|
|
pubs := csiUnmapper.csiClient.(*fakeCsiDriverClient).nodeClient.GetNodePublishedVolumes()
|
|
if _, ok := pubs[csiUnmapper.volumeID]; ok {
|
|
t.Error("csi server may not have received NodeUnpublishVolume call")
|
|
}
|
|
|
|
// ensure csi client call and node unstaged
|
|
vols := csiUnmapper.csiClient.(*fakeCsiDriverClient).nodeClient.GetNodeStagedVolumes()
|
|
if _, ok := vols[csiUnmapper.volumeID]; ok {
|
|
t.Error("csi server may not have received NodeUnstageVolume call")
|
|
}
|
|
}
|