The codec factory should support two distinct interfaces - negotiating for a serializer with a client, vs reading or writing data to a storage form (etcd, disk, etc). Make the EncodeForVersion and DecodeToVersion methods only take Encoder and Decoder, and slight refactoring elsewhere. In the storage factory, use a content type to control what serializer to pick, and use the universal deserializer. This ensures that storage can read JSON (which might be from older objects) while only writing protobuf. Add exceptions for those resources that may not be able to write to protobuf (specifically third party resources, but potentially others in the future).
224 lines
5.9 KiB
Go
224 lines
5.9 KiB
Go
/*
|
|
Copyright 2015 The Kubernetes Authors All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package registrytest
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"k8s.io/kubernetes/pkg/api"
|
|
"k8s.io/kubernetes/pkg/api/errors"
|
|
"k8s.io/kubernetes/pkg/api/meta"
|
|
"k8s.io/kubernetes/pkg/api/rest/resttest"
|
|
"k8s.io/kubernetes/pkg/api/testapi"
|
|
"k8s.io/kubernetes/pkg/fields"
|
|
"k8s.io/kubernetes/pkg/labels"
|
|
"k8s.io/kubernetes/pkg/registry/generic/registry"
|
|
"k8s.io/kubernetes/pkg/runtime"
|
|
"k8s.io/kubernetes/pkg/storage"
|
|
etcdstorage "k8s.io/kubernetes/pkg/storage/etcd"
|
|
"k8s.io/kubernetes/pkg/storage/etcd/etcdtest"
|
|
etcdtesting "k8s.io/kubernetes/pkg/storage/etcd/testing"
|
|
storagetesting "k8s.io/kubernetes/pkg/storage/testing"
|
|
)
|
|
|
|
func NewEtcdStorage(t *testing.T, group string) (storage.Interface, *etcdtesting.EtcdTestServer) {
|
|
server := etcdtesting.NewEtcdTestClientServer(t)
|
|
storage := etcdstorage.NewEtcdStorage(server.Client, testapi.Groups[group].StorageCodec(), etcdtest.PathPrefix(), false, etcdtest.DeserializationCacheSize)
|
|
return storage, server
|
|
}
|
|
|
|
type Tester struct {
|
|
tester *resttest.Tester
|
|
storage *registry.Store
|
|
}
|
|
type UpdateFunc func(runtime.Object) runtime.Object
|
|
|
|
func New(t *testing.T, storage *registry.Store) *Tester {
|
|
return &Tester{
|
|
tester: resttest.New(t, storage),
|
|
storage: storage,
|
|
}
|
|
}
|
|
|
|
func (t *Tester) TestNamespace() string {
|
|
return t.tester.TestNamespace()
|
|
}
|
|
|
|
func (t *Tester) ClusterScope() *Tester {
|
|
t.tester = t.tester.ClusterScope()
|
|
return t
|
|
}
|
|
|
|
func (t *Tester) AllowCreateOnUpdate() *Tester {
|
|
t.tester = t.tester.AllowCreateOnUpdate()
|
|
return t
|
|
}
|
|
|
|
func (t *Tester) GeneratesName() *Tester {
|
|
t.tester = t.tester.GeneratesName()
|
|
return t
|
|
}
|
|
|
|
func (t *Tester) ReturnDeletedObject() *Tester {
|
|
t.tester = t.tester.ReturnDeletedObject()
|
|
return t
|
|
}
|
|
|
|
func (t *Tester) TestCreate(valid runtime.Object, invalid ...runtime.Object) {
|
|
t.tester.TestCreate(
|
|
valid,
|
|
t.createObject,
|
|
t.getObject,
|
|
invalid...,
|
|
)
|
|
}
|
|
|
|
func (t *Tester) TestUpdate(valid runtime.Object, validUpdateFunc UpdateFunc, invalidUpdateFunc ...UpdateFunc) {
|
|
var invalidFuncs []resttest.UpdateFunc
|
|
for _, f := range invalidUpdateFunc {
|
|
invalidFuncs = append(invalidFuncs, resttest.UpdateFunc(f))
|
|
}
|
|
t.tester.TestUpdate(
|
|
valid,
|
|
t.createObject,
|
|
t.getObject,
|
|
resttest.UpdateFunc(validUpdateFunc),
|
|
invalidFuncs...,
|
|
)
|
|
}
|
|
|
|
func (t *Tester) TestDelete(valid runtime.Object) {
|
|
t.tester.TestDelete(
|
|
valid,
|
|
t.createObject,
|
|
t.getObject,
|
|
errors.IsNotFound,
|
|
)
|
|
}
|
|
|
|
func (t *Tester) TestDeleteGraceful(valid runtime.Object, expectedGrace int64) {
|
|
t.tester.TestDeleteGraceful(
|
|
valid,
|
|
t.createObject,
|
|
t.getObject,
|
|
expectedGrace,
|
|
)
|
|
}
|
|
|
|
func (t *Tester) TestGet(valid runtime.Object) {
|
|
t.tester.TestGet(valid)
|
|
}
|
|
|
|
func (t *Tester) TestList(valid runtime.Object) {
|
|
t.tester.TestList(
|
|
valid,
|
|
t.setObjectsForList,
|
|
)
|
|
}
|
|
|
|
func (t *Tester) TestWatch(valid runtime.Object, labelsPass, labelsFail []labels.Set, fieldsPass, fieldsFail []fields.Set) {
|
|
t.tester.TestWatch(
|
|
valid,
|
|
t.emitObject,
|
|
labelsPass,
|
|
labelsFail,
|
|
fieldsPass,
|
|
fieldsFail,
|
|
// TODO: This should be filtered, the registry should not be aware of this level of detail
|
|
[]string{etcdstorage.EtcdCreate, etcdstorage.EtcdDelete},
|
|
)
|
|
}
|
|
|
|
// =============================================================================
|
|
// get codec based on runtime.Object
|
|
func getCodec(obj runtime.Object) (runtime.Codec, error) {
|
|
fqKind, err := api.Scheme.ObjectKind(obj)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("unexpected encoding error: %v", err)
|
|
}
|
|
// TODO: caesarxuchao: we should detect which group an object belongs to
|
|
// by using the version returned by Schem.ObjectVersionAndKind() once we
|
|
// split the schemes for internal objects.
|
|
// TODO: caesarxuchao: we should add a map from kind to group in Scheme.
|
|
var codec runtime.Codec
|
|
if api.Scheme.Recognizes(testapi.Default.GroupVersion().WithKind(fqKind.Kind)) {
|
|
codec = testapi.Default.Codec()
|
|
} else if api.Scheme.Recognizes(testapi.Extensions.GroupVersion().WithKind(fqKind.Kind)) {
|
|
codec = testapi.Extensions.Codec()
|
|
} else {
|
|
return nil, fmt.Errorf("unexpected kind: %v", fqKind)
|
|
}
|
|
return codec, nil
|
|
}
|
|
|
|
// Helper functions
|
|
|
|
func (t *Tester) getObject(ctx api.Context, obj runtime.Object) (runtime.Object, error) {
|
|
accessor, err := meta.Accessor(obj)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
result, err := t.storage.Get(ctx, accessor.GetName())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return result, nil
|
|
}
|
|
|
|
func (t *Tester) createObject(ctx api.Context, obj runtime.Object) error {
|
|
accessor, err := meta.Accessor(obj)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
key, err := t.storage.KeyFunc(ctx, accessor.GetName())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return t.storage.Storage.Create(ctx, key, obj, nil, 0)
|
|
}
|
|
|
|
func (t *Tester) setObjectsForList(objects []runtime.Object) []runtime.Object {
|
|
key := t.storage.KeyRootFunc(t.tester.TestContext())
|
|
if err := storagetesting.CreateObjList(key, t.storage.Storage, objects); err != nil {
|
|
t.tester.Errorf("unexpected error: %v", err)
|
|
return nil
|
|
}
|
|
return objects
|
|
}
|
|
|
|
func (t *Tester) emitObject(obj runtime.Object, action string) error {
|
|
ctx := t.tester.TestContext()
|
|
var err error
|
|
|
|
switch action {
|
|
case etcdstorage.EtcdCreate:
|
|
err = t.createObject(ctx, obj)
|
|
case etcdstorage.EtcdDelete:
|
|
accessor, err := meta.Accessor(obj)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
_, err = t.storage.Delete(ctx, accessor.GetName(), nil)
|
|
default:
|
|
err = fmt.Errorf("unexpected action: %v", action)
|
|
}
|
|
|
|
return err
|
|
}
|