
Add retry mechanism to handle cases where after kubelet restarts, the device plugin unix socket(s) were created but not ready to serve yet. Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
387 lines
12 KiB
Go
387 lines
12 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package v1beta1
|
|
|
|
import (
|
|
"context"
|
|
"net"
|
|
"os"
|
|
"path/filepath"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/fsnotify/fsnotify"
|
|
"google.golang.org/grpc"
|
|
"google.golang.org/grpc/credentials/insecure"
|
|
|
|
"k8s.io/apimachinery/pkg/util/wait"
|
|
"k8s.io/klog/v2"
|
|
pluginapi "k8s.io/kubelet/pkg/apis/deviceplugin/v1beta1"
|
|
watcherapi "k8s.io/kubelet/pkg/apis/pluginregistration/v1"
|
|
)
|
|
|
|
// Stub implementation for DevicePlugin.
|
|
type Stub struct {
|
|
devs []*pluginapi.Device
|
|
socket string
|
|
resourceName string
|
|
preStartContainerFlag bool
|
|
getPreferredAllocationFlag bool
|
|
|
|
stop chan interface{}
|
|
wg sync.WaitGroup
|
|
update chan []*pluginapi.Device
|
|
|
|
server *grpc.Server
|
|
|
|
// allocFunc is used for handling allocation request
|
|
allocFunc stubAllocFunc
|
|
|
|
// getPreferredAllocFunc is used for handling getPreferredAllocation request
|
|
getPreferredAllocFunc stubGetPreferredAllocFunc
|
|
|
|
// registerControlFunc is used for controlling auto-registration of requests
|
|
registerControlFunc stubRegisterControlFunc
|
|
|
|
registrationStatus chan watcherapi.RegistrationStatus // for testing
|
|
endpoint string // for testing
|
|
|
|
kubeletRestartWatcher *fsnotify.Watcher
|
|
}
|
|
|
|
// stubGetPreferredAllocFunc is the function called when a getPreferredAllocation request is received from Kubelet
|
|
type stubGetPreferredAllocFunc func(r *pluginapi.PreferredAllocationRequest, devs map[string]pluginapi.Device) (*pluginapi.PreferredAllocationResponse, error)
|
|
|
|
func defaultGetPreferredAllocFunc(r *pluginapi.PreferredAllocationRequest, devs map[string]pluginapi.Device) (*pluginapi.PreferredAllocationResponse, error) {
|
|
var response pluginapi.PreferredAllocationResponse
|
|
|
|
return &response, nil
|
|
}
|
|
|
|
// stubAllocFunc is the function called when an allocation request is received from Kubelet
|
|
type stubAllocFunc func(r *pluginapi.AllocateRequest, devs map[string]pluginapi.Device) (*pluginapi.AllocateResponse, error)
|
|
|
|
func defaultAllocFunc(r *pluginapi.AllocateRequest, devs map[string]pluginapi.Device) (*pluginapi.AllocateResponse, error) {
|
|
var response pluginapi.AllocateResponse
|
|
|
|
return &response, nil
|
|
}
|
|
|
|
// stubRegisterControlFunc is the function called when a registration request is received from Kubelet
|
|
type stubRegisterControlFunc func() bool
|
|
|
|
func defaultRegisterControlFunc() bool {
|
|
return true
|
|
}
|
|
|
|
// NewDevicePluginStub returns an initialized DevicePlugin Stub.
|
|
func NewDevicePluginStub(devs []*pluginapi.Device, socket string, name string, preStartContainerFlag bool, getPreferredAllocationFlag bool) *Stub {
|
|
|
|
watcher, err := fsnotify.NewWatcher()
|
|
if err != nil {
|
|
klog.ErrorS(err, "Watcher creation failed")
|
|
panic(err)
|
|
}
|
|
|
|
return &Stub{
|
|
devs: devs,
|
|
socket: socket,
|
|
resourceName: name,
|
|
preStartContainerFlag: preStartContainerFlag,
|
|
getPreferredAllocationFlag: getPreferredAllocationFlag,
|
|
registerControlFunc: defaultRegisterControlFunc,
|
|
|
|
stop: make(chan interface{}),
|
|
update: make(chan []*pluginapi.Device),
|
|
|
|
allocFunc: defaultAllocFunc,
|
|
getPreferredAllocFunc: defaultGetPreferredAllocFunc,
|
|
kubeletRestartWatcher: watcher,
|
|
}
|
|
}
|
|
|
|
// SetGetPreferredAllocFunc sets allocFunc of the device plugin
|
|
func (m *Stub) SetGetPreferredAllocFunc(f stubGetPreferredAllocFunc) {
|
|
m.getPreferredAllocFunc = f
|
|
}
|
|
|
|
// SetAllocFunc sets allocFunc of the device plugin
|
|
func (m *Stub) SetAllocFunc(f stubAllocFunc) {
|
|
m.allocFunc = f
|
|
}
|
|
|
|
// SetRegisterControlFunc sets RegisterControlFunc of the device plugin
|
|
func (m *Stub) SetRegisterControlFunc(f stubRegisterControlFunc) {
|
|
m.registerControlFunc = f
|
|
}
|
|
|
|
// Start starts the gRPC server of the device plugin. Can only
|
|
// be called once.
|
|
func (m *Stub) Start() error {
|
|
klog.InfoS("Starting device plugin server")
|
|
err := m.cleanup()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
sock, err := net.Listen("unix", m.socket)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
m.wg.Add(1)
|
|
m.server = grpc.NewServer([]grpc.ServerOption{}...)
|
|
pluginapi.RegisterDevicePluginServer(m.server, m)
|
|
watcherapi.RegisterRegistrationServer(m.server, m)
|
|
|
|
err = m.kubeletRestartWatcher.Add(filepath.Dir(m.socket))
|
|
if err != nil {
|
|
klog.ErrorS(err, "Failed to add watch", "devicePluginPath", pluginapi.DevicePluginPath)
|
|
return err
|
|
}
|
|
|
|
go func() {
|
|
defer m.wg.Done()
|
|
m.server.Serve(sock)
|
|
}()
|
|
|
|
var lastDialErr error
|
|
wait.PollImmediate(1*time.Second, 10*time.Second, func() (bool, error) {
|
|
var conn *grpc.ClientConn
|
|
_, conn, lastDialErr = dial(m.socket)
|
|
if lastDialErr != nil {
|
|
return false, nil
|
|
}
|
|
conn.Close()
|
|
return true, nil
|
|
})
|
|
if lastDialErr != nil {
|
|
return lastDialErr
|
|
}
|
|
|
|
klog.InfoS("Starting to serve on socket", "socket", m.socket)
|
|
return nil
|
|
}
|
|
|
|
func (m *Stub) Restart() error {
|
|
klog.InfoS("Restarting Device Plugin server")
|
|
if m.server == nil {
|
|
return nil
|
|
}
|
|
|
|
m.server.Stop()
|
|
m.server = nil
|
|
|
|
return m.Start()
|
|
}
|
|
|
|
// Stop stops the gRPC server. Can be called without a prior Start
|
|
// and more than once. Not safe to be called concurrently by different
|
|
// goroutines!
|
|
func (m *Stub) Stop() error {
|
|
klog.InfoS("Stopping device plugin server")
|
|
if m.server == nil {
|
|
return nil
|
|
}
|
|
|
|
m.kubeletRestartWatcher.Close()
|
|
|
|
m.server.Stop()
|
|
m.wg.Wait()
|
|
m.server = nil
|
|
close(m.stop) // This prevents re-starting the server.
|
|
|
|
return m.cleanup()
|
|
}
|
|
|
|
func (m *Stub) Watch(kubeletEndpoint, resourceName, pluginSockDir string) {
|
|
for {
|
|
select {
|
|
// Detect a kubelet restart by watching for a newly created
|
|
// 'pluginapi.KubeletSocket' file. When this occurs, restart
|
|
// the device plugin server
|
|
case event := <-m.kubeletRestartWatcher.Events:
|
|
if event.Name == kubeletEndpoint && event.Op&fsnotify.Create == fsnotify.Create {
|
|
klog.InfoS("inotify: file created, restarting", "kubeletEndpoint", kubeletEndpoint)
|
|
var lastErr error
|
|
|
|
err := wait.PollUntilContextTimeout(context.Background(), 10*time.Second, 2*time.Minute, false, func(context.Context) (done bool, err error) {
|
|
restartErr := m.Restart()
|
|
if restartErr == nil {
|
|
return true, nil
|
|
}
|
|
klog.ErrorS(restartErr, "Retrying after error")
|
|
lastErr = restartErr
|
|
return false, nil
|
|
})
|
|
if err != nil {
|
|
klog.ErrorS(err, "Unable to restart server: wait timed out", "lastErr", lastErr.Error())
|
|
panic(err)
|
|
}
|
|
|
|
if ok := m.registerControlFunc(); ok {
|
|
if err := m.Register(kubeletEndpoint, resourceName, pluginSockDir); err != nil {
|
|
klog.ErrorS(err, "Unable to register to kubelet")
|
|
panic(err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Watch for any other fs errors and log them.
|
|
case err := <-m.kubeletRestartWatcher.Errors:
|
|
klog.ErrorS(err, "inotify error")
|
|
}
|
|
}
|
|
}
|
|
|
|
// GetInfo is the RPC which return pluginInfo
|
|
func (m *Stub) GetInfo(ctx context.Context, req *watcherapi.InfoRequest) (*watcherapi.PluginInfo, error) {
|
|
klog.InfoS("GetInfo")
|
|
return &watcherapi.PluginInfo{
|
|
Type: watcherapi.DevicePlugin,
|
|
Name: m.resourceName,
|
|
Endpoint: m.endpoint,
|
|
SupportedVersions: []string{pluginapi.Version}}, nil
|
|
}
|
|
|
|
// NotifyRegistrationStatus receives the registration notification from watcher
|
|
func (m *Stub) NotifyRegistrationStatus(ctx context.Context, status *watcherapi.RegistrationStatus) (*watcherapi.RegistrationStatusResponse, error) {
|
|
if m.registrationStatus != nil {
|
|
m.registrationStatus <- *status
|
|
}
|
|
if !status.PluginRegistered {
|
|
klog.InfoS("Registration failed", "err", status.Error)
|
|
}
|
|
return &watcherapi.RegistrationStatusResponse{}, nil
|
|
}
|
|
|
|
// Register registers the device plugin for the given resourceName with Kubelet.
|
|
func (m *Stub) Register(kubeletEndpoint, resourceName string, pluginSockDir string) error {
|
|
klog.InfoS("Register", "kubeletEndpoint", kubeletEndpoint, "resourceName", resourceName, "socket", pluginSockDir)
|
|
|
|
if pluginSockDir != "" {
|
|
if _, err := os.Stat(pluginSockDir + "DEPRECATION"); err == nil {
|
|
klog.InfoS("Deprecation file found. Skip registration")
|
|
return nil
|
|
}
|
|
}
|
|
klog.InfoS("Deprecation file not found. Invoke registration")
|
|
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
|
|
defer cancel()
|
|
|
|
conn, err := grpc.DialContext(ctx, kubeletEndpoint,
|
|
grpc.WithTransportCredentials(insecure.NewCredentials()),
|
|
grpc.WithBlock(),
|
|
grpc.WithContextDialer(func(ctx context.Context, addr string) (net.Conn, error) {
|
|
return (&net.Dialer{}).DialContext(ctx, "unix", addr)
|
|
}))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer conn.Close()
|
|
client := pluginapi.NewRegistrationClient(conn)
|
|
reqt := &pluginapi.RegisterRequest{
|
|
Version: pluginapi.Version,
|
|
Endpoint: filepath.Base(m.socket),
|
|
ResourceName: resourceName,
|
|
Options: &pluginapi.DevicePluginOptions{
|
|
PreStartRequired: m.preStartContainerFlag,
|
|
GetPreferredAllocationAvailable: m.getPreferredAllocationFlag,
|
|
},
|
|
}
|
|
|
|
_, err = client.Register(context.Background(), reqt)
|
|
if err != nil {
|
|
// Stop server
|
|
m.server.Stop()
|
|
klog.ErrorS(err, "Client unable to register to kubelet")
|
|
return err
|
|
}
|
|
klog.InfoS("Device Plugin registered with the Kubelet")
|
|
return err
|
|
}
|
|
|
|
// GetDevicePluginOptions returns DevicePluginOptions settings for the device plugin.
|
|
func (m *Stub) GetDevicePluginOptions(ctx context.Context, e *pluginapi.Empty) (*pluginapi.DevicePluginOptions, error) {
|
|
options := &pluginapi.DevicePluginOptions{
|
|
PreStartRequired: m.preStartContainerFlag,
|
|
GetPreferredAllocationAvailable: m.getPreferredAllocationFlag,
|
|
}
|
|
return options, nil
|
|
}
|
|
|
|
// PreStartContainer resets the devices received
|
|
func (m *Stub) PreStartContainer(ctx context.Context, r *pluginapi.PreStartContainerRequest) (*pluginapi.PreStartContainerResponse, error) {
|
|
klog.InfoS("PreStartContainer", "request", r)
|
|
return &pluginapi.PreStartContainerResponse{}, nil
|
|
}
|
|
|
|
// ListAndWatch lists devices and update that list according to the Update call
|
|
func (m *Stub) ListAndWatch(e *pluginapi.Empty, s pluginapi.DevicePlugin_ListAndWatchServer) error {
|
|
klog.InfoS("ListAndWatch")
|
|
|
|
s.Send(&pluginapi.ListAndWatchResponse{Devices: m.devs})
|
|
|
|
for {
|
|
select {
|
|
case <-m.stop:
|
|
return nil
|
|
case updated := <-m.update:
|
|
s.Send(&pluginapi.ListAndWatchResponse{Devices: updated})
|
|
}
|
|
}
|
|
}
|
|
|
|
// Update allows the device plugin to send new devices through ListAndWatch
|
|
func (m *Stub) Update(devs []*pluginapi.Device) {
|
|
m.update <- devs
|
|
}
|
|
|
|
// GetPreferredAllocation gets the preferred allocation from a set of available devices
|
|
func (m *Stub) GetPreferredAllocation(ctx context.Context, r *pluginapi.PreferredAllocationRequest) (*pluginapi.PreferredAllocationResponse, error) {
|
|
klog.InfoS("GetPreferredAllocation", "request", r)
|
|
|
|
devs := make(map[string]pluginapi.Device)
|
|
|
|
for _, dev := range m.devs {
|
|
devs[dev.ID] = *dev
|
|
}
|
|
|
|
return m.getPreferredAllocFunc(r, devs)
|
|
}
|
|
|
|
// Allocate does a mock allocation
|
|
func (m *Stub) Allocate(ctx context.Context, r *pluginapi.AllocateRequest) (*pluginapi.AllocateResponse, error) {
|
|
klog.InfoS("Allocate", "request", r)
|
|
|
|
devs := make(map[string]pluginapi.Device)
|
|
|
|
for _, dev := range m.devs {
|
|
devs[dev.ID] = *dev
|
|
}
|
|
|
|
return m.allocFunc(r, devs)
|
|
}
|
|
|
|
func (m *Stub) cleanup() error {
|
|
if err := os.Remove(m.socket); err != nil && !os.IsNotExist(err) {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|