
Previously it only took a bool, which limited the logic it could perform to determine if a pod should be admitted or not based on the merged hint from the policy.
59 lines
1.4 KiB
Go
59 lines
1.4 KiB
Go
/*
|
|
Copyright 2019 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package topologymanager
|
|
|
|
import (
|
|
"testing"
|
|
)
|
|
|
|
func TestPolicyRestrictedCanAdmitPodResult(t *testing.T) {
|
|
tcases := []struct {
|
|
name string
|
|
hint TopologyHint
|
|
expected bool
|
|
}{
|
|
{
|
|
name: "Preferred is set to false in topology hints",
|
|
hint: TopologyHint{nil, false},
|
|
expected: false,
|
|
},
|
|
{
|
|
name: "Preferred is set to true in topology hints",
|
|
hint: TopologyHint{nil, true},
|
|
expected: true,
|
|
},
|
|
}
|
|
|
|
for _, tc := range tcases {
|
|
policy := NewRestrictedPolicy()
|
|
result := policy.CanAdmitPodResult(&tc.hint)
|
|
|
|
if result.Admit != tc.expected {
|
|
t.Errorf("Expected Admit field in result to be %t, got %t", tc.expected, result.Admit)
|
|
}
|
|
|
|
if tc.expected == false {
|
|
if len(result.Reason) == 0 {
|
|
t.Errorf("Expected Reason field to be not empty")
|
|
}
|
|
if len(result.Message) == 0 {
|
|
t.Errorf("Expected Message field to be not empty")
|
|
}
|
|
}
|
|
}
|
|
}
|