github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #283 from rafalste/fix_nhit_param_value

Browse Source 
Accept max values of nhit PP as valid.
This commit is contained in:
Michał Wysoczański 2019-09-24 10:46:38 +02:00 committed by GitHub
commit 07aa29fc56
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/promotion/nhit/nhit.c
View File

@ -72,7 +72,7 @@ ocf_error_t nhit_set_param(ocf_promotion_policy_t policy, uint8_t param_id,
switch (param_id) { switch (param_id) {
case ocf_nhit_insertion_threshold: case ocf_nhit_insertion_threshold:
if (param_value >= OCF_NHIT_MIN_THRESHOLD && if (param_value >= OCF_NHIT_MIN_THRESHOLD &&
param_value < OCF_NHIT_MAX_THRESHOLD) { param_value <= OCF_NHIT_MAX_THRESHOLD) {
env_atomic_set(&ctx->insertion_threshold, param_value); env_atomic_set(&ctx->insertion_threshold, param_value);
} else { } else {
ocf_cache_log(policy->owner, log_err, "Invalid nhit " ocf_cache_log(policy->owner, log_err, "Invalid nhit "
@ -83,7 +83,7 @@ ocf_error_t nhit_set_param(ocf_promotion_policy_t policy, uint8_t param_id,
case ocf_nhit_trigger_threshold: case ocf_nhit_trigger_threshold:
if (param_value >= OCF_NHIT_MIN_TRIGGER && if (param_value >= OCF_NHIT_MIN_TRIGGER &&
param_value < OCF_NHIT_MAX_TRIGGER) { param_value <= OCF_NHIT_MAX_TRIGGER) {
env_atomic64_set(&ctx->trigger_threshold, env_atomic64_set(&ctx->trigger_threshold,
OCF_DIV_ROUND_UP((param_value * OCF_DIV_ROUND_UP((param_value *
ocf_metadata_get_cachelines_count(policy->owner)), ocf_metadata_get_cachelines_count(policy->owner)),