github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix leaking Volumes and OcfCtx's

Browse Source 
Signed-off-by: Jan Musial <jan.musial@intel.com>
This commit is contained in:
Jan Musial 2021-10-26 15:19:40 +02:00
parent 8f47cfa5bf
commit 1273e9ddfe
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/functional/pyocf/types/cache.py
View File

@ -210,7 +210,6 @@ class Cache:
) )
if status: if status:
raise OcfError("Creating cache instance failed", status) raise OcfError("Creating cache instance failed", status)
self.owner.caches.append(self)
self.mngt_queue = mngt_queue or Queue(self, "mgmt-{}".format(self.get_name())) self.mngt_queue = mngt_queue or Queue(self, "mgmt-{}".format(self.get_name()))
@ -224,6 +223,7 @@ class Cache:
raise OcfError("Error setting management queue", status) raise OcfError("Error setting management queue", status)
self.started = True self.started = True
self.owner.caches.append(self)
def change_cache_mode(self, cache_mode: CacheMode): def change_cache_mode(self, cache_mode: CacheMode):
self.write_lock() self.write_lock()
@ -494,6 +494,7 @@ class Cache:
c.wait() c.wait()
self.write_unlock() self.write_unlock()
self.device = None
if c.results["error"]: if c.results["error"]:
raise OcfError("Attaching cache device failed", c.results["error"]) raise OcfError("Attaching cache device failed", c.results["error"])
@ -714,9 +715,10 @@ class Cache:
self.mngt_queue.put() self.mngt_queue.put()
del self.io_queues[:] del self.io_queues[:]
self.started = False
self.write_unlock() self.write_unlock()
self.device = None
self.started = False
self.owner.caches.remove(self) self.owner.caches.remove(self)