github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #203 from micrakow/remove_dirty_check_flush_cmpl

Browse Source 
Remove cache dirty check at flush completion
This commit is contained in:
Michał Mielewczyk 2019-06-24 15:54:42 +02:00 committed by GitHub
commit 4a6fc035e9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
inc/ocf_mngt.h
View File

@ -605,6 +605,15 @@ typedef void (*ocf_mngt_cache_flush_end_t)(ocf_cache_t cache,
void ocf_mngt_cache_flush(ocf_cache_t cache, void ocf_mngt_cache_flush(ocf_cache_t cache,
ocf_mngt_cache_flush_end_t cmpl, void *priv); ocf_mngt_cache_flush_end_t cmpl, void *priv);
/**
* @brief Check if cache is dirty
*
* @param[in] cache Cache handle
*
* @retval true if cache is dirty, false otherwise
*/
bool ocf_mngt_cache_is_dirty(ocf_cache_t cache);
/** /**
* @brief Completion callback of core flush operation * @brief Completion callback of core flush operation
* *

2
src/mngt/ocf_mngt_common.h
View File

@ -21,8 +21,6 @@ int _ocf_cleaning_thread(void *priv);
int cache_mngt_thread_io_requests(void *data); int cache_mngt_thread_io_requests(void *data);
bool ocf_mngt_cache_is_dirty(ocf_cache_t cache);
int ocf_mngt_add_partition_to_cache(struct ocf_cache *cache, int ocf_mngt_add_partition_to_cache(struct ocf_cache *cache,
ocf_part_id_t part_id, const char *name, uint32_t min_size, ocf_part_id_t part_id, const char *name, uint32_t min_size,
uint32_t max_size, uint8_t priority, bool valid); uint32_t max_size, uint8_t priority, bool valid);

14
src/mngt/ocf_mngt_flush.c
View File

@ -598,20 +598,6 @@ static void _ocf_mngt_flush_finish(ocf_pipeline_t pipeline, void *priv,
ocf_cache_t cache = context->cache; ocf_cache_t cache = context->cache;
ocf_core_t core = context->core; ocf_core_t core = context->core;
if (!error) {
switch(context->op) {
case flush_cache:
case purge_cache:
ENV_BUG_ON(ocf_mngt_cache_is_dirty(cache));
break;
case flush_core:
case purge_core:
ENV_BUG_ON(env_atomic_read(
&core->runtime_meta->dirty_clines));
break;
}
}
_ocf_mngt_end_flush(cache); _ocf_mngt_end_flush(cache);
switch (context->op) { switch (context->op) {