github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix error handling in case of failed load

Browse Source 
Store default metadata values and restore them in case of failed load.

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
This commit is contained in:
Michal Mielewczyk 2019-06-18 23:27:40 -04:00
parent 2c5b37bd11
commit 52f6d6280b
2 changed files with 71 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
src/metadata/metadata_hash.c
View File

@ -1200,6 +1200,7 @@ struct ocf_metadata_hash_context {
void *priv;
ocf_pipeline_t pipeline;
ocf_cache_t cache;
struct ocf_metadata_raw segment_copy[metadata_segment_fixed_size_max];
};
static void ocf_metadata_hash_generic_complete(void *priv, int error)
@ -1223,6 +1224,34 @@ static void ocf_medatata_hash_load_segment(ocf_pipeline_t pipeline,
ocf_metadata_hash_generic_complete, context);
}
static void ocf_medatata_hash_store_segment(ocf_pipeline_t pipeline,
void *priv, ocf_pipeline_arg_t arg)
{
struct ocf_metadata_hash_context *context = priv;
int segment = ocf_pipeline_arg_get_int(arg);
struct ocf_metadata_hash_ctrl *ctrl;
ocf_cache_t cache = context->cache;
int error;
ctrl = (struct ocf_metadata_hash_ctrl *)cache->metadata.iface_priv;
context->segment_copy[segment].mem_pool =
env_malloc(ctrl->raw_desc[segment].mem_pool_limit, ENV_MEM_NORMAL);
if (!context->segment_copy[segment].mem_pool)
OCF_PL_FINISH_RET(pipeline, -OCF_ERR_NO_MEM);
error = env_memcpy(context->segment_copy[segment].mem_pool,
ctrl->raw_desc[segment].mem_pool_limit, METADATA_MEM_POOL(ctrl, segment),
ctrl->raw_desc[segment].mem_pool_limit);
if (error) {
env_free(context->segment_copy[segment].mem_pool);
context->segment_copy[segment].mem_pool = NULL;
OCF_PL_FINISH_RET(pipeline, error);
}
ocf_pipeline_next(pipeline);
}
static void ocf_medatata_hash_check_crc_sb_config(ocf_pipeline_t pipeline,
void *priv, ocf_pipeline_arg_t arg)
{
@ -1321,21 +1350,58 @@ static void ocf_medatata_hash_load_superblock_post(ocf_pipeline_t pipeline,
ocf_pipeline_next(pipeline);
}
static void ocf_metadata_hash_load_sb_restore(
struct ocf_metadata_hash_context *context)
{
ocf_cache_t cache = context->cache;
struct ocf_metadata_hash_ctrl *ctrl;
int segment, error;
ctrl = (struct ocf_metadata_hash_ctrl *)cache->metadata.iface_priv;
for (segment = metadata_segment_sb_config;
segment < metadata_segment_fixed_size_max; segment++) {
if (!context->segment_copy[segment].mem_pool)
continue;
error = env_memcpy(METADATA_MEM_POOL(ctrl, segment),
ctrl->raw_desc[segment].mem_pool_limit,
context->segment_copy[segment].mem_pool,
ctrl->raw_desc[segment].mem_pool_limit);
ENV_BUG_ON(error);
}
}
static void ocf_metadata_hash_load_superblock_finish(ocf_pipeline_t pipeline,
void *priv, int error)
{
struct ocf_metadata_hash_context *context = priv;
ocf_cache_t cache = context->cache;
int segment;
if (error) {
ocf_cache_log(cache, log_err, "Metadata read FAILURE\n");
ocf_metadata_error(cache);
ocf_metadata_hash_load_sb_restore(context);
}
for (segment = metadata_segment_sb_config;
segment < metadata_segment_fixed_size_max; segment++) {
if (context->segment_copy[segment].mem_pool)
env_free(context->segment_copy[segment].mem_pool);
}
context->cmpl(context->priv, error);
ocf_pipeline_destroy(pipeline);
}
struct ocf_pipeline_arg ocf_metadata_hash_load_sb_store_segment_args[] = {
OCF_PL_ARG_INT(metadata_segment_sb_config),
OCF_PL_ARG_INT(metadata_segment_sb_runtime),
OCF_PL_ARG_INT(metadata_segment_core_config),
OCF_PL_ARG_TERMINATOR(),
};
struct ocf_pipeline_arg ocf_metadata_hash_load_sb_load_segment_args[] = {
OCF_PL_ARG_INT(metadata_segment_sb_config),
OCF_PL_ARG_INT(metadata_segment_sb_runtime),
@ -1355,6 +1421,8 @@ struct ocf_pipeline_properties ocf_metadata_hash_load_sb_pipeline_props = {
.priv_size = sizeof(struct ocf_metadata_hash_context),
.finish = ocf_metadata_hash_load_superblock_finish,
.steps = {
OCF_PL_STEP_FOREACH(ocf_medatata_hash_store_segment,
ocf_metadata_hash_load_sb_store_segment_args),
OCF_PL_STEP_FOREACH(ocf_medatata_hash_load_segment,
ocf_metadata_hash_load_sb_load_segment_args),
OCF_PL_STEP(ocf_medatata_hash_check_crc_sb_config),

3
src/metadata/metadata_raw_dynamic.c
View File

@ -409,6 +409,9 @@ static int raw_dynamic_load_all_update(struct ocf_request *req)
OCF_DEBUG_PARAM(cache, "Non-zero loaded %llu", i);
if (ctrl->pages[context->i])
env_vfree(ctrl->pages[context->i]);
ctrl->pages[context->i] = context->page;
context->page = NULL;