github/ocf
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Adding partition locks

Browse Source 
Adding locks to assure partition list consistency. Partition
lists is typically modified under cacheline or hash bucket lock.
This is not sufficient synchronization as adding/removing cacheline
from partition list affects neighbouring cachelines state as well.

Signed-off-by: Adam Rutkowski <adam.j.rutkowski@intel.com>
This commit is contained in:
Adam Rutkowski
2019-09-23 11:08:27 -04:00
parent 41d3542952
commit 5e28474322
4 changed files with 35 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/concurrency/ocf_metadata_concurrency.c
View File

@@ -8,13 +8,25 @@
void ocf_metadata_concurrency_init(struct ocf_metadata_lock *metadata_lock)
{
unsigned i;
env_spinlock_init(&metadata_lock->eviction);
env_rwlock_init(&metadata_lock->status);
env_rwsem_init(&metadata_lock->global);
for (i = 0; i < OCF_IO_CLASS_MAX; i++) {
env_spinlock_init(&metadata_lock->partition[i]);
}
}
void ocf_metadata_concurrency_deinit(struct ocf_metadata_lock *metadata_lock)
{
unsigned i;
for (i = 0; i < OCF_IO_CLASS_MAX; i++) {
env_spinlock_destroy(&metadata_lock->partition[i]);
}
env_spinlock_destroy(&metadata_lock->eviction);
env_rwlock_destroy(&metadata_lock->status);
env_rwsem_destroy(&metadata_lock->global);

14
src/concurrency/ocf_metadata_concurrency.h
View File

@@ -33,6 +33,20 @@ static inline void ocf_metadata_eviction_unlock(
env_spinlock_unlock(&metadata_lock->eviction);
}
static inline void ocf_metadata_partition_lock(
struct ocf_metadata_lock *metadata_lock,
ocf_part_id_t part_id)
{
env_spinlock_lock(&metadata_lock->partition[part_id]);
}
static inline void ocf_metadata_partition_unlock(
struct ocf_metadata_lock *metadata_lock,
ocf_part_id_t part_id)
{
env_spinlock_unlock(&metadata_lock->partition[part_id]);
}
#define OCF_METADATA_EVICTION_LOCK() \
ocf_metadata_eviction_lock(&cache->metadata.lock)