From 0ede30d5527bb9efae27b7ad44b594ec73ad1b80 Mon Sep 17 00:00:00 2001 From: Robert Baldyga Date: Tue, 6 Sep 2022 11:59:02 +0200 Subject: [PATCH 1/2] example: Initialize volume memory pool Avoid uninitialized memory access. Signed-off-by: Robert Baldyga --- example/simple/src/volume.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/example/simple/src/volume.c b/example/simple/src/volume.c index 52585a4..5fe8597 100644 --- a/example/simple/src/volume.c +++ b/example/simple/src/volume.c @@ -1,5 +1,5 @@ /* - * Copyright(c) 2019-2021 Intel Corporation + * Copyright(c) 2019-2022 Intel Corporation * SPDX-License-Identifier: BSD-3-Clause */ @@ -21,6 +21,10 @@ static int volume_open(ocf_volume_t volume, void *volume_params) myvolume->name = ocf_uuid_to_str(uuid); myvolume->mem = malloc(VOL_SIZE); + if (!myvolume->mem) + return -ENOMEM; + + memset(myvolume->mem, 0, VOL_SIZE); printf("VOL OPEN: (name: %s)\n", myvolume->name); From 8453bb9da14a7de70241fd0cf6589e2561a9e97a Mon Sep 17 00:00:00 2001 From: Robert Baldyga Date: Tue, 6 Sep 2022 11:59:39 +0200 Subject: [PATCH 2/2] example: Destroy volume remnant after it's moved Signed-off-by: Robert Baldyga --- example/simple/src/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/example/simple/src/main.c b/example/simple/src/main.c index 9b23ec8..a644ff2 100644 --- a/example/simple/src/main.c +++ b/example/simple/src/main.c @@ -161,6 +161,8 @@ int initialize_cache(ocf_ctx_t ctx, ocf_cache_t *cache) if (ret) goto err_cache; + ocf_volume_destroy(volume); + return 0; err_cache: