github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor metadata collision API

Browse Source 
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
This commit is contained in:
Michal Mielewczyk 2025-03-21 10:03:54 +01:00
parent e1d2ff12d8
commit 67eb940589
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/metadata/metadata_status.h
View File

@ -317,28 +317,28 @@ static inline void metadata_set_valid_sec_one(struct ocf_cache *cache,
ocf_metadata_set_valid(cache, line, pos, pos); ocf_metadata_set_valid(cache, line, pos, pos);
} }
/* /*
* Marks given cache line's bits as invalid * Marks given cache line's sectors as invalid
* *
* @return true if any of the cache line's bits was valid and the cache line * @return true if line was valid and became invalid (all sectors invalid)
* became invalid (all bits invalid) after the operation * @return false if line was invalid and remains invalid or
* @return false in other cases * if line was valid and still has valid sectors
*/ */
static inline bool metadata_clear_valid_sec_changed( static inline bool metadata_clear_valid_sec_changed(
struct ocf_cache *cache, ocf_cache_line_t line, struct ocf_cache *cache, ocf_cache_line_t line,
uint8_t start, uint8_t stop, bool *is_valid) uint8_t start, uint8_t stop, bool *line_remains_valid)
{ {
bool was_any_valid, _line_remains_valid; bool line_was_valid, _line_remains_valid;
was_any_valid = ocf_metadata_test_valid(cache, line, 0, line_was_valid = ocf_metadata_test_valid(cache, line, 0,
ocf_line_end_sector(cache), false); ocf_line_end_sector(cache), false);
_line_remains_valid = ocf_metadata_clear_valid(cache, line, _line_remains_valid = ocf_metadata_clear_valid(cache, line,
start, stop); start, stop);
if (likely(is_valid)) if (likely(line_remains_valid != NULL))
*is_valid = _line_remains_valid; *line_remains_valid = _line_remains_valid;
return was_any_valid && !_line_remains_valid; return line_was_valid && !_line_remains_valid;
} }
#endif /* METADATA_STATUS_H_ */ #endif /* METADATA_STATUS_H_ */