From d0b00817f324dea2412a0e3acba3d0caa09511d2 Mon Sep 17 00:00:00 2001 From: Adam Rutkowski Date: Tue, 30 Nov 2021 19:34:52 +0100 Subject: [PATCH 1/2] fix cacheline reset in passive metadata update Signed-off-by: Adam Rutkowski --- src/metadata/metadata_passive_update.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/metadata/metadata_passive_update.c b/src/metadata/metadata_passive_update.c index ed6551f..93291a5 100644 --- a/src/metadata/metadata_passive_update.c +++ b/src/metadata/metadata_passive_update.c @@ -32,8 +32,12 @@ static inline void _reset_cline(ocf_cache_t cache, ocf_cache_line_t cline) ocf_lru_clean_cline(cache, &cache->user_parts[PARTITION_DEFAULT].part, cline); + metadata_init_status_bits(cache, cline); + ocf_lru_rm_cline(cache, cline); ocf_metadata_set_partition_id(cache, cline, PARTITION_FREELIST); + + ocf_metadata_set_core_info(cache, cline, OCF_CORE_MAX, ULLONG_MAX); } static inline void remove_from_freelist(ocf_cache_t cache, From b455a393dd6c86589b760fe25bab5597ea785b5d Mon Sep 17 00:00:00 2001 From: Adam Rutkowski Date: Tue, 30 Nov 2021 12:04:57 +0100 Subject: [PATCH 2/2] extra assertion in metadata passive update Signed-off-by: Adam Rutkowski --- src/metadata/metadata_passive_update.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/metadata/metadata_passive_update.c b/src/metadata/metadata_passive_update.c index 93291a5..207627a 100644 --- a/src/metadata/metadata_passive_update.c +++ b/src/metadata/metadata_passive_update.c @@ -208,6 +208,9 @@ static void cleanup_old_mapping(ocf_cache_t cache, ocf_cache_line_t start, if (!core) continue; + ENV_BUG_ON(ocf_metadata_get_partition_id(cache, cline) != + PARTITION_DEFAULT); + _dec_core_stats(core); ocf_hb_cline_prot_lock_wr(&cache->metadata.lock, lock_idx, core_id,