github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Call LRU set_hot() immediately after cache insert

Browse Source 
This assures that cacheline with LOOKUP_INSERTED status
is always present on the LRU list.

This fixes an ENV_BUG() caused by an attempt to remove
a cacheline from LRU list which was not there. This
happened when cacheline was mapped from freelist
(LOOKUP_INSERTED) but the entire request mapping failed
and generic cleanup routines attempted to invalidate cacheline,
including removing it from the LRU list. As engine_set_hot()
is called after successfull mapping, the inserted cacheline was
not yet present on the LRU list.

Signed-off-by: Adam Rutkowski <adam.j.rutkowski@intel.com>
This commit is contained in:
Adam Rutkowski 2021-03-16 19:59:09 -05:00
parent c6bf894f46
commit 736fb2efc0
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/engine/engine_common.c
View File

@ -203,11 +203,16 @@ static void ocf_engine_set_hot(struct ocf_request *req)
uint8_t status; uint8_t status;
unsigned i; unsigned i;
if (req->info.hit_no == 0 && req->info.invalid_no == 0) {
/* no previously mapped clines */
return;
}
for (i = 0; i < req->core_line_count; i++) { for (i = 0; i < req->core_line_count; i++) {
entry = &(req->map[i]); entry = &(req->map[i]);
status = entry->status; status = entry->status;
if (status == LOOKUP_HIT || status == LOOKUP_INSERTED) { if (status == LOOKUP_HIT) {
/* Update eviction (LRU) */ /* Update eviction (LRU) */
ocf_eviction_set_hot_cache_line(cache, entry->coll_idx); ocf_eviction_set_hot_cache_line(cache, entry->coll_idx);
} }
@ -347,6 +352,7 @@ static void ocf_engine_map_cache_line(struct ocf_request *req,
/* Update LRU:: Move this node to head of lru list. */ /* Update LRU:: Move this node to head of lru list. */
ocf_eviction_init_cache_line(cache, cache_line); ocf_eviction_init_cache_line(cache, cache_line);
ocf_eviction_set_hot_cache_line(cache, cache_line);
} }
static void ocf_engine_map_hndl_error(struct ocf_cache *cache, static void ocf_engine_map_hndl_error(struct ocf_cache *cache,