From 92a5ddd524a0db0cdedabb460ca41eb804d20634 Mon Sep 17 00:00:00 2001 From: Michal Mielewczyk Date: Fri, 19 Mar 2021 16:06:47 +0100 Subject: [PATCH] ut framework: don't mock env functions Signed-off-by: Michal Mielewczyk --- src/mngt/ocf_mngt_io_class.c | 1 - tests/unit/framework/prepare_sources_for_testing.py | 10 ++++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mngt/ocf_mngt_io_class.c b/src/mngt/ocf_mngt_io_class.c index 090a7a4..9685c97 100644 --- a/src/mngt/ocf_mngt_io_class.c +++ b/src/mngt/ocf_mngt_io_class.c @@ -137,7 +137,6 @@ static int _ocf_mngt_io_class_configure(ocf_cache_t cache, if (env_strncmp(name, OCF_IO_CLASS_NAME_MAX, dest_part->config->name, OCF_IO_CLASS_NAME_MAX)) { - ocf_cache_log(cache, log_err, "Can't change classification rule of the default IO class" " [ ERROR ]\n"); diff --git a/tests/unit/framework/prepare_sources_for_testing.py b/tests/unit/framework/prepare_sources_for_testing.py index d7ba6ef..83ac35d 100755 --- a/tests/unit/framework/prepare_sources_for_testing.py +++ b/tests/unit/framework/prepare_sources_for_testing.py @@ -146,6 +146,11 @@ class UnitTestsSourcesGenerator(object): wrap_file_path = wrap_file_path + "_generated_wraps.c" return wrap_file_path + def is_env_function(self, name): + prefixes = ["env", "bug", "memcpy", "memset", "memcmp", "strnlen", "strncmp", "strncpy"] + + return list(filter(name.startswith, prefixes)) != [] + def prepare_autowraps(self, test_file_path, preprocessed_file_path): functions_to_wrap = self.get_functions_calls( self.get_sources_to_test_repo() + test_file_path) @@ -160,10 +165,7 @@ class UnitTestsSourcesGenerator(object): with open(preprocessed_file_path) as f: code = f.readlines() for function in functions_to_wrap: - if function.startswith("env_") or function.startswith("bug") \ - or function.startswith("memcpy"): - # added memcpy function to list of ignored functions - # because this is macro + if self.is_env_function(function): continue for tag in tags_list: if function in tag: