github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix counting occupancy on WB write insert error

Browse Source 
During error handling in WB write insert we didn't invalidate affected
cache lines. Because of that the cache stopped properly (as it's
supposed to), but cache lines were marked as inserted which caused
occupancy stats to increase even though nothing was succesfully
inserted.

Signed-off-by: Jan Musial <jan.musial@intel.com>
This commit is contained in:
Jan Musial 2019-12-09 11:00:13 +01:00
parent d8a01e359e
commit 94d27c0f43
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/engine/engine_wb.c
View File

@ -8,6 +8,7 @@
#include "cache_engine.h" #include "cache_engine.h"
#include "engine_common.h" #include "engine_common.h"
#include "engine_wb.h" #include "engine_wb.h"
#include "engine_inv.h"
#include "../metadata/metadata.h" #include "../metadata/metadata.h"
#include "../ocf_request.h" #include "../ocf_request.h"
#include "../utils/utils_io.h" #include "../utils/utils_io.h"
@ -98,11 +99,9 @@ static void _ocf_write_wb_complete(struct ocf_request *req, int error)
if (req->error) { if (req->error) {
ocf_engine_error(req, true, "Failed to write data to cache"); ocf_engine_error(req, true, "Failed to write data to cache");
ocf_req_unlock_wr(req);
req->complete(req, req->error); req->complete(req, req->error);
ocf_req_put(req); ocf_engine_invalidate(req);
} else { } else {
ocf_engine_push_req_front_if(req, &_io_if_wb_flush_metadata, ocf_engine_push_req_front_if(req, &_io_if_wb_flush_metadata,
true); true);