github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor __set_cache_line_invalid() pt.2

Browse Source 
Get rid of nested ifs

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
This commit is contained in:
Michal Mielewczyk 2025-03-21 11:51:01 +01:00
parent 4a01ff957d
commit 96e527049a
1 changed files with 19 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/utils/utils_cache_line.c
View File

@ -20,20 +20,26 @@ static void __set_cache_line_invalid(struct ocf_cache *cache, uint8_t start_bit,
line_became_invalid = metadata_clear_valid_sec_changed(cache, line, line_became_invalid = metadata_clear_valid_sec_changed(cache, line,
start_bit, end_bit, &line_remains_valid); start_bit, end_bit, &line_remains_valid);
/* If we have waiters, do not remove cache line if (line_remains_valid) {
* for this cache line which will use one, clear ENV_BUG_ON(line_became_invalid);
* only valid bits return;
*/
if (!line_remains_valid && !ocf_cache_line_are_waiters(
ocf_cache_line_concurrency(cache), line)) {
if (line_became_invalid) {
env_atomic_dec(&core->runtime_meta->cached_clines);
env_atomic_dec(&core->runtime_meta->
part_counters[part_id].cached_clines);
}
ocf_lru_rm_cline(cache, line);
ocf_metadata_remove_cache_line(cache, line);
} }
/* If there are any waiters, don't transfer the line to the freelist.
* The new owner will take care about the repart anyways
*/
if (ocf_cache_line_are_waiters(ocf_cache_line_concurrency(cache), line))
return;
ocf_lru_rm_cline(cache, line);
ocf_metadata_remove_cache_line(cache, line);
if (!line_became_invalid)
return;
env_atomic_dec(&core->runtime_meta->cached_clines);
env_atomic_dec(&core->runtime_meta->
part_counters[part_id].cached_clines);
} }
void set_cache_line_invalid(struct ocf_cache *cache, uint8_t start_bit, void set_cache_line_invalid(struct ocf_cache *cache, uint8_t start_bit,