github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix freeing oversized discard requests

Browse Source 
When issuing discard request over 512KiB OCF would trim this request and
overwrite req->core_line_count which would then cause this request to be
freed from wrong mpool.

This is fixed now by saving core_line_count that was set when allocating
this request that is never overwritten. This alloc_core_line_count is
then used to free the request from correct mpool.

Signed-off-by: Jan Musial <jan.musial@intel.com>
This commit is contained in:
Jan Musial 2021-03-25 14:00:17 +01:00
parent b12e124954
commit 9c070c1d25
2 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/ocf_request.c
View File

@ -85,12 +85,16 @@ struct ocf_request *ocf_req_new(ocf_queue_t queue, ocf_core_t core,
req = env_mpool_new(cache->owner->resources.req, 1);
}
if (unlikely(!req))
return NULL;
if (map_allocated)
if (map_allocated) {
req->map = req->__map;
req->alloc_core_line_count = core_line_count;
} else {
req->alloc_core_line_count = 1;
}
OCF_DEBUG_TRACE(cache);
@ -204,13 +208,11 @@ void ocf_req_put(struct ocf_request *req)
if (!req->d2c && req->io_queue != req->cache->mngt_queue)
ocf_refcnt_dec(&req->cache->refcnt.metadata);
if (req->map == req->__map) {
env_mpool_del(req->cache->owner->resources.req, req,
req->core_line_count);
} else {
if (req->map != req->__map)
env_free(req->map);
env_mpool_del(req->cache->owner->resources.req, req, 1);
}
env_mpool_del(req->cache->owner->resources.req, req,
req->alloc_core_line_count);
ocf_queue_put(queue);
}

3
src/ocf_request.h
View File

@ -166,6 +166,9 @@ struct ocf_request {
uint32_t core_line_count;
/*! Core line count */
uint32_t alloc_core_line_count;
/*! Number of core lines at time of request allocation */
int error;
/*!< This filed indicates an error for OCF request */