github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove redundant list_del(ctx->caches) during init

Browse Source 
New caches are added to the list at the point where they are already
initialized and no errors are possible at this point, hence list_del() in error
handling is redundant.

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
This commit is contained in:
Michal Mielewczyk 2024-10-07 12:51:19 +02:00
parent d22885ef7d
commit c82fd173c6
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/mngt/ocf_mngt_cache.c
View File

@ -66,9 +66,6 @@ struct ocf_cache_mngt_init_params {
bool metadata_inited : 1; bool metadata_inited : 1;
/*!< Metadata is inited to valid state */ /*!< Metadata is inited to valid state */
bool added_to_list : 1;
/*!< Cache is added to context list */
bool cache_locked : 1; bool cache_locked : 1;
/*!< Cache has been locked */ /*!< Cache has been locked */
} flags; } flags;
@ -1476,15 +1473,7 @@ static void _ocf_mngt_init_handle_error(ocf_ctx_t ctx,
if (params->flags.metadata_inited) if (params->flags.metadata_inited)
ocf_metadata_deinit(cache); ocf_metadata_deinit(cache);
if (!params->flags.added_to_list)
return;
env_rmutex_lock(&ctx->lock);
list_del(&cache->list);
env_vfree(cache); env_vfree(cache);
env_rmutex_unlock(&ctx->lock);
} }
static void _ocf_mngt_cache_init(ocf_cache_t cache, static void _ocf_mngt_cache_init(ocf_cache_t cache,
@ -1563,7 +1552,6 @@ static int _ocf_mngt_cache_start(ocf_ctx_t ctx, ocf_cache_t *cache,
} }
list_add_tail(&tmp_cache->list, &ctx->caches); list_add_tail(&tmp_cache->list, &ctx->caches);
params.flags.added_to_list = true;
env_rmutex_unlock(&ctx->lock); env_rmutex_unlock(&ctx->lock);
ocf_cache_log(tmp_cache, log_debug, "Metadata initialized\n"); ocf_cache_log(tmp_cache, log_debug, "Metadata initialized\n");