From cd4d894348b4b0e5d91c2b7b401742e483dcaf0a Mon Sep 17 00:00:00 2001 From: Michal Mielewczyk Date: Mon, 11 Apr 2022 13:05:12 +0200 Subject: [PATCH] acp: skip the first bucket on recovering acp Since the threshold for the first bucket is always zero and the condition to exit from the loop is never met in the first iteration it is save to start iterating from `1` This change is meant to avoid confusing static code analyzers Signed-off-by: Michal Mielewczyk --- src/cleaning/acp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cleaning/acp.c b/src/cleaning/acp.c index 1a3a56f..bc2db7f 100644 --- a/src/cleaning/acp.c +++ b/src/cleaning/acp.c @@ -405,7 +405,7 @@ static void ocf_acp_recovery_chunk(struct ocf_acp_recovery_context *context, .chunk[chunk->core_id][chunk->chunk_id]; } - for (bucket_id = 0; bucket_id < ACP_MAX_BUCKETS; bucket_id++) { + for (bucket_id = 1; bucket_id < ACP_MAX_BUCKETS; bucket_id++) { bucket = &acp->bucket_info[bucket_id]; if (chunk->num_dirty < bucket->threshold) break;