Merge pull request #161 from robertbaldyga/disallow-cache-mode-max-io-class

Disallow ocf_cache_mode_max in io_class config
This commit is contained in:
Michal Rakowski 2019-05-21 13:08:10 +02:00 committed by GitHub
commit da52091fdc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -235,12 +235,8 @@ static int _ocf_mngt_io_class_validate_cfg(ocf_cache_t cache,
if (!cfg->name) if (!cfg->name)
return 0; return 0;
/* TODO(r.baldyga): ocf_cache_mode_max is allowed for compatibility
* with OCF 3.1 kernel adapter (upgrade in flight) and casadm.
* Forbid ocf_cache_mode_max after fixing these problems.
*/
if (cfg->cache_mode < ocf_cache_mode_none || if (cfg->cache_mode < ocf_cache_mode_none ||
cfg->cache_mode > ocf_cache_mode_max) { cfg->cache_mode >= ocf_cache_mode_max) {
return -OCF_ERR_INVAL; return -OCF_ERR_INVAL;
} }