github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Introduce d2c request

Browse Source 
This avoids unnecessary map allocation and initialization of unused fields of
request structure. It also allows to track thier number separately from
the regular requests

Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
This commit is contained in:
Robert Baldyga 2023-09-25 22:38:01 +02:00 committed by Michal Mielewczyk
parent 8b93b699c3
commit dc58eeae9b
3 changed files with 41 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mngt/ocf_mngt_cache.c
View File

@ -857,6 +857,8 @@ static int _ocf_mngt_init_new_cache(struct ocf_cache_mngt_init_params *params)
/* start with freezed metadata ref counter to indicate detached device*/
ocf_refcnt_freeze(&cache->refcnt.metadata);
ocf_refcnt_init(&cache->refcnt.d2c);
env_atomic_set(&(cache->last_access_ms),
env_ticks_to_msecs(env_get_tick_count()));

2
src/ocf_cache_priv.h
View File

@ -85,6 +85,8 @@ struct ocf_cache {
/* # of requests accessing attached metadata, excluding
* management reqs */
struct ocf_refcnt metadata __attribute__((aligned(64)));
/* # of requests in d2c mode */
struct ocf_refcnt d2c;
} refcnt;
struct {

44
src/ocf_request.c
View File

@ -164,6 +164,22 @@ struct ocf_request *ocf_req_new_cleaner(ocf_cache_t cache, ocf_queue_t queue,
return req;
}
static inline struct ocf_request *ocf_req_new_d2c(ocf_queue_t queue,
ocf_core_t core, uint64_t addr, uint32_t bytes, int rw)
{
ocf_cache_t cache = ocf_core_get_cache(core);
struct ocf_request *req;
req = env_mpool_new(cache->owner->resources.req, 1);
if (unlikely(!req))
return NULL;
ocf_req_init(req, cache, queue, core, addr, bytes, rw);
req->d2c = true;
return req;
}
struct ocf_request *ocf_req_new(ocf_queue_t queue, ocf_core_t core,
uint64_t addr, uint32_t bytes, int rw)
{
@ -174,6 +190,19 @@ struct ocf_request *ocf_req_new(ocf_queue_t queue, ocf_core_t core,
ENV_BUG_ON(ocf_queue_is_mngt(queue));
ocf_queue_get(queue);
if (!ocf_refcnt_inc(&cache->refcnt.metadata)) {
if (!ocf_refcnt_inc(&cache->refcnt.d2c))
ENV_BUG();
req = ocf_req_new_d2c(queue, core, addr, bytes, rw);
if (unlikely(!req)) {
ocf_queue_put(queue);
return NULL;
}
return req;
}
if (likely(bytes)) {
core_line_first = ocf_bytes_2_lines(cache, addr);
core_line_last = ocf_bytes_2_lines(cache, addr + bytes - 1);
@ -190,8 +219,11 @@ struct ocf_request *ocf_req_new(ocf_queue_t queue, ocf_core_t core,
req = env_mpool_new(cache->owner->resources.req, 1);
}
if (unlikely(!req))
if (unlikely(!req)) {
ocf_refcnt_dec(&cache->refcnt.metadata);
ocf_queue_put(queue);
return NULL;
}
if (map_allocated) {
req->map = req->__map;
@ -203,11 +235,7 @@ struct ocf_request *ocf_req_new(ocf_queue_t queue, ocf_core_t core,
OCF_DEBUG_TRACE(cache);
ocf_queue_get(queue);
ocf_req_init(req, cache, queue, core, addr, bytes, rw);
req->d2c = !ocf_refcnt_inc(&cache->refcnt.metadata);
ocf_req_init(req, cache, queue, NULL, addr, bytes, rw);
req->core_line_first = core_line_first;
req->core_line_last = core_line_last;
@ -358,7 +386,9 @@ void ocf_req_put(struct ocf_request *req)
OCF_DEBUG_TRACE(req->cache);
if ((!req->d2c && !req->is_mngt) || req->cleaner)
if (req->d2c)
ocf_refcnt_dec(&req->cache->refcnt.d2c);
else if (!req->is_mngt || req->cleaner)
ocf_refcnt_dec(&req->cache->refcnt.metadata);
if (unlikely(req->is_mngt)) {