github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid unnecessary metadata flushes in WT

Browse Source 
Flushing metadata in WT is required only if at least of the request's cacheline
changed its state to clean.

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
This commit is contained in:
Michal Mielewczyk 2021-06-23 09:27:36 +02:00
parent c9294d1f06
commit f0564dcf75
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/engine/engine_wt.c
View File

@ -110,8 +110,19 @@ static void _ocf_write_wt_req_complete(struct ocf_request *req)
req->complete(req, req->info.core_error ? req->error : 0); req->complete(req, req->info.core_error ? req->error : 0);
ocf_engine_invalidate(req); ocf_engine_invalidate(req);
} else {
return;
}
if (req->info.dirty_any) {
/* Some of the request's cachelines changed its state to clean */
ocf_engine_push_req_front_if(req, &_io_if_wt_flush_metadata, true); ocf_engine_push_req_front_if(req, &_io_if_wt_flush_metadata, true);
} else {
ocf_req_unlock_wr(ocf_cache_line_concurrency(req->cache), req);
req->complete(req, req->info.core_error ? req->error : 0);
ocf_req_put(req);
} }
} }
@ -164,6 +175,13 @@ static int _ocf_write_wt_do(struct ocf_request *req)
/* Get OCF request - increase reference counter */ /* Get OCF request - increase reference counter */
ocf_req_get(req); ocf_req_get(req);
if (!req->info.dirty_any) {
/* Set metadata bits before the request submission only if the dirty
status for any of the request's cachelines won't change */
_ocf_write_wt_update_bits(req);
ENV_BUG_ON(req->info.flush_metadata);
}
/* Submit IO */ /* Submit IO */
_ocf_write_wt_submit(req); _ocf_write_wt_submit(req);