github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

D2C: Prevent use after free

Browse Source 
Request could be completed and freed before the statistics were updated

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
This commit is contained in:
Michal Mielewczyk 2025-03-26 15:40:33 +01:00
parent baccc5560b
commit f1e25c923b
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/engine/engine_d2c.c
View File

@ -1,6 +1,6 @@
/* /*
* Copyright(c) 2012-2022 Intel Corporation * Copyright(c) 2012-2022 Intel Corporation
* Copyright(c) 2024 Huawei Technologies * Copyright(c) 2024-2025 Huawei Technologies
* SPDX-License-Identifier: BSD-3-Clause * SPDX-License-Identifier: BSD-3-Clause
*/ */
#include "ocf/ocf.h" #include "ocf/ocf.h"
@ -33,7 +33,10 @@ int ocf_d2c_io_fast(struct ocf_request *req)
{ {
OCF_DEBUG_TRACE(req->cache); OCF_DEBUG_TRACE(req->cache);
/* Get OCF request - increase reference counter */ /* Increase reference counter - once for submission and second time to
* avoid freeing the request before updating stats
*/
ocf_req_get(req);
ocf_req_get(req); ocf_req_get(req);
ocf_engine_forward_core_io_req(req, _ocf_d2c_completion); ocf_engine_forward_core_io_req(req, _ocf_d2c_completion);
@ -46,6 +49,8 @@ int ocf_d2c_io_fast(struct ocf_request *req)
ocf_core_stats_request_pt_update(req->core, req->part_id, req->rw, ocf_core_stats_request_pt_update(req->core, req->part_id, req->rw,
req->info.hit_no, req->core_line_count); req->info.hit_no, req->core_line_count);
ocf_req_put(req);
return 0; return 0;
} }