github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fine granularity lock in cache_mngt_core_deinit_attached_meta

Browse Source 
Signed-off-by: Adam Rutkowski <adam.j.rutkowski@intel.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
This commit is contained in:
Adam Rutkowski 2021-01-08 12:11:54 +01:00 committed by Michal Mielewczyk
parent 6d962b38e9
commit f206c64ff6
1 changed files with 36 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
src/mngt/ocf_mngt_common.c
View File

@ -54,41 +54,51 @@ void cache_mngt_core_remove_from_cleaning_pol(ocf_core_t core)
/* Deinitialize core metadata in attached metadata */ /* Deinitialize core metadata in attached metadata */
void cache_mngt_core_deinit_attached_meta(ocf_core_t core) void cache_mngt_core_deinit_attached_meta(ocf_core_t core)
{ {
int retry = 1;
uint64_t core_size = 0;
ocf_cleaning_t clean_pol_type;
ocf_cache_t cache = ocf_core_get_cache(core); ocf_cache_t cache = ocf_core_get_cache(core);
ocf_core_id_t core_id = ocf_core_get_id(core); ocf_core_id_t core_id = ocf_core_get_id(core);
ocf_core_id_t iter_core_id;
ocf_cache_line_t curr_cline, prev_cline;
uint32_t hash, num_hash = cache->device->hash_table_entries;
core_size = ocf_volume_get_length(&core->volume); for (hash = 0; hash < num_hash;) {
if (!core_size) prev_cline = cache->device->collision_table_entries;
core_size = ~0ULL; ocf_metadata_lock_hash_wr(&cache->metadata.lock, hash);
ocf_metadata_start_exclusive_access(&cache->metadata.lock); curr_cline = ocf_metadata_get_hash(cache, hash);
while (curr_cline != cache->device->collision_table_entries) {
ocf_metadata_get_core_info(cache, curr_cline, &iter_core_id,
NULL);
clean_pol_type = cache->conf_meta->cleaning_policy_type; if (iter_core_id != core_id) {
while (retry) { /* `prev_cline` is a pointer to last not sparsed cacheline in
retry = 0; * current hash */
if (cleaning_policy_ops[clean_pol_type].purge_range) { prev_cline = curr_cline;
retry = cleaning_policy_ops[clean_pol_type].purge_range(cache, curr_cline = ocf_metadata_get_collision_next(cache, curr_cline);
core_id, 0, core_size); continue;
}
if (!ocf_cache_line_try_lock_wr(cache, curr_cline))
break;
if (metadata_test_dirty(cache, curr_cline))
ocf_purge_cleaning_policy(cache, curr_cline);
ocf_metadata_sparse_cache_line(cache, curr_cline);
ocf_cache_line_unlock_wr(cache, curr_cline);
if (prev_cline != cache->device->collision_table_entries)
curr_cline = ocf_metadata_get_collision_next(cache, prev_cline);
else
curr_cline = ocf_metadata_get_hash(cache, hash);
} }
ocf_metadata_unlock_hash_wr(&cache->metadata.lock, hash);
if (!retry) { /* Check whether all the cachelines from the hash bucket were sparsed */
/* Remove from collision_table and Partition. Put in FREELIST */ if (curr_cline == cache->device->collision_table_entries)
retry = ocf_metadata_sparse_range(cache, core_id, 0, hash++;
core_size); else
}
if (retry) {
ocf_metadata_end_exclusive_access(&cache->metadata.lock);
env_msleep(100); env_msleep(100);
ocf_metadata_start_exclusive_access(
&cache->metadata.lock);
}
} }
ocf_metadata_end_exclusive_access(&cache->metadata.lock);
} }
/* Mark core as removed in metadata */ /* Mark core as removed in metadata */