github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,452 Commits 1 Branch 1 Tag 4.1 MiB
1b3f0d44a8
Commit Graph

811 Commits

Author SHA1 Message Date
Krzysztof Majzerowicz-Jaszcz
1b3f0d44a8 Fix error code for superblock checksum mismatch 
Fix error code for superblock checksum mismatch.
Superblock validation now returns a proper error on checksum check fail.

Signed-off-by: Krzysztof Majzerowicz-Jaszcz <krzysztof.majzerowicz-jaszcz@intel.com>
 2022-04-01 07:23:49 +00:00
Adam Rutkowski
09b73461b4 Always modify valid_core_map together with core_count 
.. to assure that superblock config state on drive is consistent

Signed-off-by: Adam Rutkowski <adam.j.rutkowski@intel.com>
 2022-03-31 13:37:42 +02:00
Robert Baldyga
9ebb0de878 Do not modify core_count on cache load / activate 
Increment core_count only on core addition, and decrement it only on core
removal.

Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-03-31 10:00:24 +02:00
Robert Baldyga
25434cb8d1 Explicitly validate valid_core_bitmap consistency 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-03-30 23:46:06 +02:00
Robert Baldyga
9c751dd2b8 Manage valid_core_bitmap properly 
Set bit only on core addition and clean it on core removal.

This allows to avoid conf metadata modification in load / standby load
paths, which effectively prevents issues with metadata mismatch during
consequent standby activate attempts after initial activate failure.
Previously the first attempt changed the metadata, so on comparison with
metadata on drive failed on any following attempt, leading to inability
to activate the cache.

Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-03-30 23:46:06 +02:00
Robert Baldyga
d550c8f4ef Fix minor coding style issues 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-03-30 22:15:50 +02:00
Robert Baldyga
ca8531a421
Merge pull request #685 from arutk/stats2 
Return error from stats API functions in standby
 2022-03-30 11:57:10 +02:00
Jan Musial
d1bd32add9 Fix potential unsigned overflow in calculations 
Signed-off-by: Jan Musial <jan.musial@intel.com>
 2022-03-30 08:24:39 +02:00
Adam Rutkowski
9a1f9d41b8 Return error from stats API functions in standby 
Signed-off-by: Adam Rutkowski <adam.j.rutkowski@intel.com>
 2022-03-29 22:20:04 +02:00
Robert Baldyga
af43a240d3 Return more specific error on CRC mismatch 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-03-28 22:42:59 +02:00
Robert Baldyga
84aa968877 Check for load error before accessing metadata content 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-03-28 22:08:05 +02:00
Robert Baldyga
174f7b5c2b
Merge pull request #682 from jfckm/zero-cache-volume-priv 
Zero cache_volume priv on close
 2022-03-28 16:02:02 +02:00
Jan Musial
43e643873a Zero cache_volume priv on close 
Signed-off-by: Jan Musial <jan.musial@intel.com>
 2022-03-28 14:50:25 +02:00
Adam Rutkowski
6b6300c646 Add extra data seek before data fill in mio 
Signed-off-by: Adam Rutkowski <adam.j.rutkowski@intel.com>
 2022-03-28 14:26:51 +02:00
Adam Rutkowski
4a839cd332 Verify standby/active cache state in OCF entry points 
Signed-off-by: Adam Rutkowski <adam.j.rutkowski@intel.com>
 2022-03-28 09:42:02 +02:00
Robert Baldyga
aa4622cc01 Make core remove error recoverable 
First try to clean only the mapping. This operation does not require any
rollback, so even if flushing collision fails, core object is still
intact. In case of error we inform user that core was not removed by
returning new error code (-OCF_ERR_CORE_NOT_REMOVED).

After flushing collision succeeds we remove core from metadata and
flush superblock at the end. At that point the core is fully removed
from OCF and even if superblock flush error occurs there is nothing we
can do about it, so we just return the error code.

Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-03-25 21:32:55 +01:00
Robert Baldyga
643e103fe7 Don't attempt to set data for flush/discard on cache volume 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-03-17 21:18:31 +01:00
Robert Baldyga
4fc3f8f0d1 Remove extra whitespace 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-03-09 11:44:27 +01:00
Robert Baldyga
d5b2c65a39 Remove "metadata_layout" parameter of the cache 
This feature is replaced with LRU list shuffling.

Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-03-07 17:48:25 +01:00
Robert Baldyga
9a956f59cd
Merge pull request #654 from Open-CAS/fix-flapping-merge 
Porting fix-flapping patches from v21.6.4 by arutk
 2022-03-05 01:31:23 +01:00
Adam Rutkowski
689c44c76b Remove ocf_metadata_probe_cores() implementation 
This function must be fixed to work with metadata flapping. Until then
mark as not supported

Signed-off-by: Adam Rutkowski <adam.j.rutkowski@intel.com>
Signed-off-by: Krzysztof Majzerowicz-Jaszcz <krzysztof.majzerowicz-jaszcz@intel.com>
 2022-03-04 19:13:40 +01:00
Adam Rutkowski
866bba72bf Explicitly validate superblock after load 
Signed-off-by: Adam Rutkowski <adam.j.rutkowski@intel.com>

Additional changes - load sb recovery CRC check

Signed-off-by: Krzysztof Majzerowicz-Jaszcz <krzysztof.majzerowicz-jaszcz@intel.com>
 2022-03-04 19:12:51 +01:00
Robert Baldyga
90ff4afcda Check superblock CRC before it is used 
Superblock can be used during load of other sections, so we need to check
its CRC before other sections are loaded.

Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
Signed-off-by: Krzysztof Majzerowicz-Jaszcz <krzysztof.majzerowicz-jaszcz@intel.com>
 2022-03-04 19:12:08 +01:00
Krzysztof Majzerowicz-Jaszcz
06f2140090 Removing ocf_metadata_sb_crc_recovery 
Removing ocf_metadata_sb_crc_recovery - not used

Signed-off-by: Krzysztof Majzerowicz-Jaszcz <krzysztof.majzerowicz-jaszcz@intel.com>
 2022-03-04 19:10:47 +01:00
Robert Baldyga
1cce6bf24b
Merge pull request #664 from robertbaldyga/improve-bf 
Extend BF queue protection to cache device queue
 2022-03-04 18:50:43 +01:00
Robert Baldyga
45cc56f40d Extend BF queue protection to cache device queue 
So far the only resource protected by backfill queue blocking was internal
OCF request queue. Move unblock to backfill io completion to protect also
queue of underlying cache device.

Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-03-02 20:59:51 +01:00
Robert Baldyga
87d71f319e
Merge pull request #662 from jfckm/fix-invalid-message-try-add 
Fix message when try-adding already opened core
 2022-03-01 14:06:30 +01:00
Jan Musial
e0cd0a4882 Fix message when try-adding already opened core 
Signed-off-by: Jan Musial <jan.musial@intel.com>
 2022-02-18 12:54:13 +01:00
Michal Mielewczyk
116676c18d Verify cache id duing the activate 
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
 2022-02-17 15:02:03 +01:00
Robert Baldyga
49abe816ce
Merge pull request #649 from pdebski21/1023 
fix for issue #1023
 2022-02-07 16:17:14 +01:00
Robert Baldyga
805ea14529 Remove runtime recovery in standby mode 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-02-01 03:11:50 +01:00
Robert Baldyga
76684ed8a9
Merge pull request #642 from robertbaldyga/parallelize 
Parallelize metadata initialization
 2022-02-07 13:53:45 +01:00
Robert Baldyga
e30fd48338
Merge pull request #656 from jfckm/extend-metadata-probe 
Include cache mode and cache line size in metadata probe
 2022-02-04 13:01:10 +01:00
Jan Musial
8522b0b6e6 Include cache mode and cache line size in metadata probe 
Signed-off-by: Jan Musial <jan.musial@intel.com>
 2022-02-04 08:15:05 +01:00
Robert Baldyga
c176daeec1
Merge pull request #640 from pdebski21/superblock_mismatch 
added error code for superblock mismatch
 2022-02-03 15:30:03 +01:00
Robert Baldyga
6a665ea6b1 Shuffle entries within freelists 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-01-31 06:59:28 +01:00
Robert Baldyga
481e5b7b9b Introduce bisect generator utility 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-01-31 06:59:28 +01:00
Robert Baldyga
93391c78d8 Parallelize ACP recovery 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-01-31 06:59:28 +01:00
Robert Baldyga
b70492ad3d Parallelize ALRU recovery 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-01-31 06:59:28 +01:00
Robert Baldyga
8cc71cc9cb Remove ocf_cleaning_init_cache_block() from metadata rebuild 
Cleaning policy initializaton initializes metadata for all cache lines
anyway, so this step is not needed.

Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-01-28 19:30:41 +01:00
Robert Baldyga
48bed40dd7 Reconstruct freelist during metadata rebuild 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-01-28 19:30:39 +01:00
Robert Baldyga
f3e4f8c2db Parallelize ocf_mngt_rebuild_metadata() 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-01-28 19:29:52 +01:00
Robert Baldyga
036aca41b3 Parallelize ocf_lru_populate() 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-01-28 19:29:21 +01:00
Robert Baldyga
6611b25d1e Initialize LRU lists in domain of cache lines 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-01-28 19:29:21 +01:00
Robert Baldyga
57fd5c1f20 Introduce ocf_parallelize utility 
Introduce utility that allows to parallelize management operation across
all available io queues.

Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-01-28 19:29:21 +01:00
Robert Baldyga
a947127f55 Introduce ocf_lru_add_free() function 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-01-28 19:29:21 +01:00
Robert Baldyga
b82d30a0ef Add missing hb lock functions implementation 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-01-28 19:29:21 +01:00
Robert Baldyga
25e2551964 Check core status during recovery based on core metadata 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-01-28 19:29:21 +01:00
Robert Baldyga
568c565497 Init properties before loading superblock 
Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
 2022-01-28 19:29:21 +01:00
Piotr Debski
9b980d3f22 fix for issue #1023 
Better error for core size mismatch during activation/load

adding pyocf test for new error code

Signed-off-by: Piotr Debski <piotr.debski@intel.com>
 2022-01-25 05:18:16 +01:00